Commit Graph

5506 Commits

Author SHA1 Message Date
Sveta Smirnova
f189f8382e Revert "PT-2083 - Pt-archiver --charset option is not working for MySQL8.0"
This reverts commit 284a1f945e.
2023-12-29 17:19:41 +03:00
dependabot[bot]
450e9cd7a3 Bump actions/setup-go from 4 to 5
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-29 17:19:41 +03:00
Sveta Smirnova
f1d431ee50 PT-2083 - Pt-archiver --charset option is not working for MySQL8.0
- Changed logic, introduced by commit 1d1c13fbcb
- Added test case
2023-12-29 17:19:41 +03:00
Artem Gavrilov
f4b01c37a6 Merge pull request #725 from percona/dependabot/go_modules/golang.org/x/crypto-0.16.0
Bump golang.org/x/crypto from 0.15.0 to 0.16.0
2023-12-29 17:19:41 +03:00
Artem Gavrilov
9cd46954fe Merge pull request #726 from percona/dependabot/go_modules/github.com/rs/zerolog-1.31.0
Bump github.com/rs/zerolog from 1.30.0 to 1.31.0
2023-12-29 17:19:41 +03:00
dependabot[bot]
0f3af52bd2 Bump golang.org/x/crypto from 0.15.0 to 0.16.0
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.16.0.
- [Commits](https://github.com/golang/crypto/compare/v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-29 17:19:41 +03:00
Artem Gavrilov
a6ed1371cb Merge pull request #727 from percona/dependabot/go_modules/github.com/google/go-cmp-0.6.0
Bump github.com/google/go-cmp from 0.5.9 to 0.6.0
2023-12-29 17:19:41 +03:00
Sveta Smirnova
6b595cb3db Merge pull request #721 from oblitorum/PT-2277_impossible_on_condition
PT-2277 - fix pt-visual-explain for 'Impossible ON condition' case
2023-12-29 17:19:41 +03:00
Sveta Smirnova
e71736c2d9 Merge pull request #706 from percona/Follow_PR-429_unstop_option_with_testcase
Follow PR-429 unstop option with testcase
2023-12-29 17:19:41 +03:00
dependabot[bot]
2c9222c95d Bump github.com/rs/zerolog from 1.30.0 to 1.31.0
Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.30.0 to 1.31.0.
- [Release notes](https://github.com/rs/zerolog/releases)
- [Commits](https://github.com/rs/zerolog/compare/v1.30.0...v1.31.0)

---
updated-dependencies:
- dependency-name: github.com/rs/zerolog
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-29 17:19:40 +03:00
dependabot[bot]
5f28690b13 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0
Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.9 to 0.6.0.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](https://github.com/google/go-cmp/compare/v0.5.9...v0.6.0)

---
updated-dependencies:
- dependency-name: github.com/google/go-cmp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-29 17:19:40 +03:00
Sveta Smirnova
23f7357cb7 Merge pull request #669 from ylacancellera/galera-log-explainer
Add pt-galera-log-explainer
2023-12-29 17:19:40 +03:00
Sveta Smirnova
a33d63b52c PR-669 - Add pt-galera-log-explainer
- Exceptions for identifiers and Galera library errors in .typos.toml
2023-12-29 17:19:40 +03:00
Sveta Smirnova
e4c7bb6e82 PR-669 - Add pt-galera-log-explainer
- Added exception for Go tests into .typos.toml
2023-12-29 17:19:40 +03:00
Sveta Smirnova
95cef030d9 PR-669 - Add pt-galera-log-explainer
- Added exception into .typos.toml for src/go/pt-galera-log-explainer/tests/
2023-12-29 17:19:40 +03:00
Sveta Smirnova
86b1f2986f PR-669 - Add pt-galera-log-explainer
- Added exception for IST into .typos.toml
2023-12-29 17:19:40 +03:00
Sveta Smirnova
7ca88e7b59 Merge branch '3.x' into galera-log-explainer 2023-12-29 17:19:39 +03:00
Sveta Smirnova
dc07968b31 PR-669 - Add pt-galera-log-explainer
- Sync README.rst and docs/pt-galera-log-explainer.rst
2023-12-29 17:19:25 +03:00
Yoann La Cancellera
68e1b25001 preallocate lastcontexts map 2023-12-29 17:19:25 +03:00
Yoann La Cancellera
5a0574c828 Move: chan closing in "main" func 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
5030769bc8 Rename ctx to logCtx, remove any mention of ctx 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
8ccd547042 Fix: missed errors, minor formatting issues 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
671706c0da Imp: use strings.builder for conflicts 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
1e132b25fd Add: parallel on 2 unit tests 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
da3acc8e57 Update src/go/pt-galera-log-explainer/README.rst
Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
fd9d09d9ae Fix: README with -vvv, --grep-args, regex-list 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
d1f7c72a9f PR-669 - Add pt-galera-log-explainer percona#669
- Commented out whois command in README.rst
- Copied README.rst into docs directory, so user manual will include
  this tool
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
a5cf09a79e Remove: --grep-args
Can be used to break the tool, and I actually never had an use-case
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
6d9136890a Fix: typos 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
8b84adb1e0 Remove old comments, dead code 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
4f5b089a34 Add: translate tests 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
84dcf1ef9c Commenting out whois+sed, will be re-added later 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
c910c35d3e Refactoring: migrate translations to singleton
It was using maps in each context, which would be merged between
contexts, then injected each time we needed a message to display.

It had a limitation on complicated operator setups: historical
information would be overriden by newer associations.
(e.g, that IP was for node0 yesterday, now it's node1, so associations
have been overwritten and incorrect)

It also introduced complexity, such as forcing to define closures too
many times, merging maps, it would be harder to debug, and every files
were starting from empty translation maps.
Moreover, iterating on maps is guaranteed to be random so it could create
hard-to-debug output variations on complex cases.

Now it is a singleton in translate package, still using maps but now it
associates an array of "units" storing the timestamp with each piece of information.
It is protected by rwmutex, because map are not threadsafe. (there's no
parallel processing for now)

No regressions, and it passes "operator_ambiguous_ips_list_all_no_color"
where the old system failed.
It nows also can be used as an easy to read source of information in
itself
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
ea262eff27 Add: inconsistent vote regex corner-case 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
580ccb7428 Add: shortuuid check, new date layout found 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
3eaf60bd88 Add: same ip/name limitation on README.rst 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
7513e1ded7 Add: operator member assocations regex
It existed for non-operator setup, but was not working for operators due
to k8s logs not interpreting newlines and tabs
This operator version re-uses existing regular regex handlers directly
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
d13292ba67 Improve: main_test
It must test multiple times to remove doubts.
As the tool is reading files and relying on maps, their access order are
random. It can impact some translations
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
c67047e781 Remove: propagation of ip propagation to older hash, Add: operator regression test
When adding "ownip", it was also propagating the new IP to the old hash.
But with operators, when IP where changing hash will also change, so
linking the new IP to old hash is anachronic. It is not wrong, but
depending on the order of map merges, the newest information could have
been overriden depending on the order of events.

That situation was producing X(2*number of conflicts) versions of output for operators, with
different md5sum, which could produce false-positive regression tests

So currently some information are not linked anymore, so some IPs are
not translated even though they could, but it is a limitation of using
maps as source of truth, as they are not versioned
2023-12-29 17:19:01 +03:00
Sveta Smirnova
59e0867e3a Changelog template for version 3.5.8 2023-12-28 10:47:01 +03:00
Sveta Smirnova
8369cfc42a Merge pull request #747 from percona/release-v3.5.7
Release v3.5.7
v3.5.7
2023-12-23 02:07:45 +03:00
Sveta Smirnova
7617e20e48 Date in release notes 2023-12-22 23:49:01 +03:00
Sveta Smirnova
be9bade155 Corrrected version for build tools 2023-12-22 23:38:42 +03:00
Sveta Smirnova
5b61ec79b5 Version and release notes updated 2023-12-22 23:34:57 +03:00
Sveta Smirnova
58cfb21740 Merge pull request #738 from percona/dependabot/go_modules/github.com/google/uuid-1.5.0
Bump github.com/google/uuid from 1.4.0 to 1.5.0
2023-12-22 23:23:10 +03:00
dependabot[bot]
6fb5dad85e Bump github.com/google/uuid from 1.4.0 to 1.5.0
Dependabot couldn't find the original pull request head commit, e6c2b03cb4e7570a374c59c568d51136ae9d82ce.
2023-12-22 20:22:25 +00:00
Sveta Smirnova
4ecc4838fb Merge pull request #739 from percona/dependabot/go_modules/k8s.io/api-0.29.0
Bump k8s.io/api from 0.28.4 to 0.29.0
2023-12-22 23:21:43 +03:00
dependabot[bot]
f87a07d007 Bump k8s.io/api from 0.28.4 to 0.29.0
Dependabot couldn't find the original pull request head commit, 7e14040fd776d305c702dc277a37a74f7b1cf813.
2023-12-22 20:19:16 +00:00
Sveta Smirnova
425ac80d6c Merge pull request #722 from alina-derkach-oaza/PT-2291-RN-3.5.6
PT-2291 Release notes for Percona Toolkit version 3.5.6
2023-12-22 23:11:32 +03:00
Sveta Smirnova
baf12f793d Update percona-toolkit.pod
Suggestion added by Eleonora when merged https://github.com/percona/percona-toolkit/pull/745
2023-12-22 23:11:32 +03:00