Commit Graph

883 Commits

Author SHA1 Message Date
Brian Fraser fraserb@gmail.com
12bd26022a Fix a section() bug.
Turns out that awk's indexes are documented to start from 1;
So what happens if you use 0? Apparently it's undefined behavior, so
substr(var, 0, 5);
and
substr(var, 1, 5);
May or may not actually do the same thing. In Debian 6, the former
doesn't quite work, and actually returns something like substr(var, 1, 4),
which broke section()'s output.
2012-04-03 10:55:51 -03:00
Daniel Nichter
0dd19a6fc9 Fix typo. 2012-04-02 20:10:10 -06:00
Daniel Nichter
c4927399bd Merge fix-table-status-bug-960513. 2012-04-02 19:47:58 -06:00
Daniel Nichter
806fafdb31 Update modules in pt-online-schema-change. 2012-04-02 19:37:07 -06:00
Daniel Nichter
c1feb83b96 Uncomment cleanup lines in alter_active_table.t. 2012-04-02 19:32:48 -06:00
Daniel Nichter
4ee198e8cd Add XXX comment about improperly copying . 2012-04-02 19:29:59 -06:00
Daniel Nichter
403c93db3b Handle Key_name or key_name in NibbleIterator::_get_index_cardinality(). 2012-04-02 19:24:38 -06:00
Daniel Nichter
5eaa565566 Catch lost cleanup task (should rarely happen). 2012-04-02 19:20:56 -06:00
Daniel Nichter
34ada21344 Add comment about code that will fail with new Cxn due to NAME_lc. 2012-04-02 19:12:28 -06:00
Daniel Nichter
02e9d2eed9 Merge preserve-foreign-keys-bug-969726. 2012-04-02 18:22:51 -06:00
Brian Fraser fraserb@gmail.com
c0dedd19bf - section() revamp
- Redirect STDERR for the collection part in both tools
- rm_tempdir in sigtrap
- A part of pt-mysql-summary still depended on the system being run,
  rather than the samples being read. Now it works properly.
2012-04-02 19:25:17 -03:00
Daniel Nichter
867789ff87 Merge pt-table-usage-docs. 2012-04-02 16:04:26 -06:00
Brian Fraser fraserb@gmail.com
6dbbd6de3b The previous merge went a bit wrong, and left the libraries unsynced with the tools; This commit fixes it. 2012-04-02 13:36:17 -03:00
Daniel Nichter
c04b85a066 Update SchemaIterator, TableParser, and NibbleIterator in tools that use them. All tools' tests still pass. 2012-03-31 09:59:15 -06:00
Brian Fraser fraserb@gmail.com
761f8a5aac Merge more of Baron's changes, also re-implement the MySQL Executables section
Plus other bugfixes.
2012-03-30 23:00:57 -03:00
baron@percona.com
dacc36994e Update documentation 2012-03-30 20:47:56 -04:00
Daniel Nichter
2bae569429 Don't use TABLE STATUS, use CREATE TABLE instead for the table's engine. 2012-03-30 18:46:08 -06:00
Daniel Nichter
1cd990a0f0 Update SchemaIterator in pt-table-sync. Make the module handle NAME_lc or not. 2012-03-30 18:15:54 -06:00
Brian Fraser fraserb@gmail.com
978b236985 Save the config file itself, not just its path. 2012-03-30 20:18:39 -03:00
Daniel Nichter
a18c08f16a Add pt-table-usage and update SQLParser.pm from Maatkit. 2012-03-30 16:52:36 -06:00
Daniel Nichter
34602e89fe Add pt-table-usage, copied and converted from mk-table-usage. 2012-03-30 16:45:10 -06:00
Daniel Nichter
4300f2908b Add pt-fingerprint. 2012-03-30 16:07:37 -06:00
Daniel Nichter
1b80d06c4a Merge fix-no-stalk-bug-955860. 2012-03-30 15:45:13 -06:00
Daniel Nichter
83b9d1e245 Merge fix-pt-upgrade-docs-bug-953461. 2012-03-30 15:24:30 -06:00
Daniel Nichter
a76d5df7fb Write very basic OUTPUT section for pt-upgrade. 2012-03-30 15:18:53 -06:00
baron
06dc18ec46 clean up a couple of things causing tests to fail for me, and remove a feature that's not quite ready yet, and add another feature for innodb compression 2012-03-30 17:07:05 -04:00
baron
d44e8b539b clean up a couple of things causing tests to fail for me, and remove a feature that's not quite ready yet, and add another feature for innodb compression 2012-03-30 17:04:25 -04:00
Daniel Nichter
427a069801 Test that vmstatu runs for --run-time with --no-stalk. 2012-03-30 15:02:45 -06:00
Brian Fraser fraserb@gmail.com
af5d9d7e90 Merged Baron's changes 2012-03-30 17:28:53 -03:00
Brian Fraser fraserb@gmail.com
562a550a39 Fixes 2012-03-30 17:23:55 -03:00
Brian Fraser fraserb@gmail.com
53a6230e9c Bug 963225 v2: Updated tests and more samples 2012-03-30 17:21:48 -03:00
baron@percona.com
6e9a483ee1 more slight doc tweaks 2012-03-30 15:46:14 -04:00
baron@percona.com
8e4d1fe005 docs and a few tweaks 2012-03-30 15:34:28 -04:00
Brian Fraser fraserb@gmail.com
b007016215 lib/Cxn.pm: Silence a warning (in 5.14)
I think this warning actually happens everywhere, but because of
how it happens, it gets masked by older versions of Perl.

Basically, Cxn's DESTROY method checks if $self->{dbh}, and if true,
calls ->disconnect on that. However, during global destruction --
when DESTROY is called -- you have no assurances that DESTROY
will be called before the dbh was already reaped.

This commit makes sure that the $self->{dbh} we have inside DESTROY
is actually a reference.
2012-03-30 16:03:04 -03:00
Brian Fraser fraserb@gmail.com
33954b72f9 Silence warnings from lib/QueryAdvisorRules.pm 2012-03-30 15:58:00 -03:00
Brian Fraser fraserb@gmail.com
8a4bc61a6b Fix test failures in t/lib/SQLParser.t from an lc() on a variable without a default on lib/Schema.pm 2012-03-30 15:47:37 -03:00
Daniel Nichter
94d9483d03 Make vmstat, iostat, and mpstat run for --run-time not --interval. 2012-03-30 11:35:32 -06:00
Brian Fraser fraserb@gmail.com
33a4096663 Fix CPU_ARCH collection for Linux 2012-03-30 13:44:21 -03:00
Daniel Nichter
c19c6caf0b Merge fix-quoting-bug-967451. 2012-03-30 10:42:18 -06:00
Daniel Nichter
98885c8150 Make t/pt-table-sync/check_privs.t reliable. 2012-03-30 10:39:16 -06:00
Daniel Nichter
a1cba706ec Update TableChunker in pt-table-sync, pt-upgrade, and pt-online-schema-change. 2012-03-30 10:37:16 -06:00
Daniel Nichter
688570de79 Quote chunk col in char chunk sql. 2012-03-30 10:31:36 -06:00
Daniel Nichter
a0fa29f30b Merge fix-risks-docs-bug-949653. 2012-03-30 10:09:47 -06:00
Daniel Nichter
8dc348baa1 Document risk of breaking replication if master-slave schemas or table structs differ. 2012-03-30 10:02:37 -06:00
baron@percona.com
26944c11cc Update samples and tests for SlowLogWriter.pm and SlowLogParser.pm for bug 963225 2012-03-29 22:16:53 -04:00
baron@percona.com
45b66a4e1a merge upstream 2012-03-29 21:47:58 -04:00
baron@percona.com
3f668362e7 fix a few bugs 2012-03-29 21:39:31 -04:00
baron@percona.com
f707656dee docs; small quoting fix 2012-03-29 21:26:22 -04:00
Daniel Nichter
296829b8e5 Add myself as a author. 2012-03-29 17:10:30 -06:00
Daniel Nichter
3d0cae5a60 Fix and test --alter-fk-method=none. 2012-03-29 16:53:11 -06:00