Commit Graph

916 Commits

Author SHA1 Message Date
Daniel Nichter dd333380f2 Ignore the new 5.6 mysql stats tables in SchemaIterator and update that module in all tools and updated affected samples. 2012-12-05 18:27:12 +00:00
Daniel Nichter 9fc08fd411 In pt-upgrade: remove query_cache_type=0 from --set-vars and add --[no]disable-query-cache and only disable it if it's already on to avoid the new MySQL 5.6.8 error. 2012-12-05 10:18:53 -07:00
Daniel Nichter 0b25accdf6 Merge trunk r478. 2012-12-04 16:54:50 -07:00
Daniel Nichter 0ad52d0003 Update DSNParser in pt-table-usage and pt-visual-explain to avoid https://refute.testnoir.com/percona-toolkit/jobs/percona-toolkit-mysql-5.6/2/results/errors#18960 because Sandbox sets {L} but new DSNParser is needed to check for and delete it. 2012-12-04 15:42:14 -07:00
Brian Fraser d2f1742606 Merged fix-917770-pt-config-diff-uninit-value-crash 2012-12-04 13:43:40 -03:00
Brian Fraser e0c8fac54e Merged doc-patch-empty-replicate-table-1074179 2012-12-04 13:42:22 -03:00
Brian Fraser a7a0da3bc9 Refactor _parse_varvals.
Now it takes two arguments: A regexp and a string to match against.
_parse_varvals itself was split in three:  _preprocess_varvals,
_parse_varvals, and _process_val.

This also modifies the three places that call _parse_varvals; For
two, no real changes were needed, but parse_mysqld() required a fix
to deal with the two final lines of mysqld --help --verbose:

   To see what values a running MySQL server is using, type
   'mysqladmin variables' instead of 'mysqld --verbose --help'.
2012-12-04 05:02:56 -03:00
Daniel Nichter c094494f1f Fix CMD_MYSQL and CMD_MYSQLDUMP in pt-mysql-summary so they can be specified on cmd line, then do so in pt-mysql-summary.t so mysqldump 5.6 is used with 5.6 because earlier versions don't work with MySQL 5.6. 2012-12-04 01:31:52 +00:00
Daniel Nichter e7c3e908bb Create percona_test.sentinel in start-sandbox so wait_for_slave() works for other sandboxes. skip_all for skip_innodb.t with 5.6 because of http://bugs.mysql.com/67798. 2012-12-04 00:14:20 +00:00
Daniel Nichter e69533e492 Test with MyISAM tables. Add PXC section to pt-archiver docs. 2012-11-30 19:25:35 +00:00
Brian Fraser 76a010abee Fix for 917770: Use of uninitialized value in substitution (s///) at pt-config-diff line 1996
This turned out to be two bugs mangled into one.

First, _parse_varvals can deal with (var, undef), but not with (undef).
This is a problem because two of the trhee spots that call
_parse_varvals can return undef because of this:

      map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ }
      grep { $_ !~ m/^\s*#/ }  # no # comment lines
      split("\n", $mysqld_section)

The problem is twofold. First, we are not skipping empty or
whitespace-only lines. That means that the map will fail,
and pass an undef to _parse_varvals. So this ended up in
a triple fix: Make _parse_varvals deal with a sole undef,
skip empty/whitespace lines, and change that map to

	map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ ? ($1, $2) : () }

so even if the regex fails in the future, no sole undef
will be passed down the chain.
2012-11-30 16:17:45 -03:00
Brian Fraser 739babd9bf Remove the B<> and reword the new text 2012-11-29 22:48:13 -03:00
Daniel Nichter 90a91cd384 Merge pt-osc-pxc-tests. 2012-11-29 17:10:51 -07:00
Daniel Nichter 8549fe5d99 Test and require wsrep_OSU_method=TOI. 2012-11-29 23:26:53 +00:00
Daniel Nichter 13318a9710 Update modules in ptc. 2012-11-29 22:32:31 +00:00
Daniel Nichter 9e97edebd2 Check PXC version in ptc and pt-osc, die if < 5.5.28. 2012-11-29 22:26:46 +00:00
Daniel Nichter 10c8654a49 Update PXC section in ptc and pt-osc docs to say that 5.5.28-23.7 is required, not 5.5.27-23.6 because of bug 1040108. 2012-11-29 22:09:32 +00:00
Brian Fraser e71d3adb96 Merged fix-1079341-pt-osc-skip-myisam-fk-checks 2012-11-29 17:15:56 -03:00
Brian Fraser 2614eabd31 Merged fix-1074179-ptc-replicate-check-only-filters 2012-11-29 17:14:14 -03:00
Brian Fraser b37c138ec8 Merged fix-1052475-ptc-uninit-crash-slave-errors 2012-11-29 17:12:29 -03:00
Brian Fraser cddead8a69 Merged fix-831525-pqd-mangled-help 2012-11-29 17:10:54 -03:00
Brian Fraser 713457226a Merged fix-887638-ptqa-negative-at-byte 2012-11-29 17:09:33 -03:00
Daniel Nichter e9d064c816 Fix a code comment. 2012-11-28 21:19:52 +00:00
Daniel Nichter 824c34b5d2 Only check --alter if given. Fix some tests, add add_col to make some tests work on PXC or not. 2012-11-28 21:11:29 +00:00
Daniel Nichter d515e3b382 r472 was a miscommit: it includes new --check-alter check for cluster node+MyISAM node and pxc.t. 2012-11-28 17:58:40 +00:00
Daniel Nichter 61b352a04d Fix sandbox/load-sakila-db so it exits on error. 2012-11-28 17:55:35 +00:00
Daniel Nichter ea1c6f6ca9 Add lock_in_share_mode option to NibbleIterator. Silence query_table.pl diag messages. 2012-11-27 17:41:05 +00:00
Daniel Nichter 9d1004ddbb Check and update tool versions, release notes, user docs, etc. before build. 2012-11-19 18:47:13 +00:00
Daniel Nichter 92e1242d00 Update Percona::Toolkit::VERSION and Changelog. 2012-11-19 18:41:34 +00:00
Daniel Nichter 2c85a47a45 Alphabetize the opts and fix 2 typos. 2012-11-19 11:19:33 -07:00
Daniel Nichter 38b9230d8c Finish PXC section of ptc docs. 2012-11-19 11:09:14 -07:00
Daniel Nichter e0f0ea0cdb Rewrite and enhance lib/Percona/XtraDB/Cluster.pm and t/pt-table-checksum/pxc.t. Change how ptc handles various cluster issues. Change lib/Sandbox.pm subs like start_sandbox() and start_cluster(). PXC docs in ptc are a work in progress. 2012-11-18 22:05:30 -07:00
Daniel Nichter 07bee85a00 Don't check binlog_format on cluster nodes. 2012-11-17 12:55:18 -07:00
Brian Fraser 55a17166c6 Merged fix-1041391-rowchecker-wrong-debug-statement 2012-11-16 11:36:59 -03:00
Brian Fraser b031df3a7e Doc patch emphasizing how --empty-replicate-table works 2012-11-16 11:21:44 -03:00
Brian Fraser 54e9dc1a46 Fix for 1079341: Skip foreign key checks on MyISAM tables 2012-11-16 10:58:30 -03:00
Brian Fraser 06115737ee Fix for 887638: pt-query-digest prints negative byte offset 2012-11-15 15:17:03 -03:00
Brian Fraser 26e1e3bc19 Build percona-toolkit-2.1.6 2012-11-13 12:22:01 -03:00
Brian Fraser c811d60ae1 Pushed the lib/Percona/Toolkit.pm version, and added extra tests to t/lib/Percona/Toolkit.t 2012-11-13 12:10:25 -03:00
Daniel Nichter 0670d27eb0 Merge pt-osc-default-engine 2012-11-10 10:18:02 -07:00
Brian Fraser 57740c4101 Missing /g in a Quoter regex 2012-11-10 09:54:39 -03:00
Brian Fraser cafb2b3fb5 Merged fix-1062563-1063912-ptc-pxc-bugs 2012-11-09 18:41:32 -03:00
Brian Fraser d7a239b369 Fix for 1074179: pt-table-checksum does't ignore tables for --replicate-check-only 2012-11-09 16:37:56 -03:00
Brian Fraser 511a402911 Merged fix-1047335-crashed-tables 2012-11-09 13:48:17 -03:00
Brian Fraser d827c7228d Merged OptionParser-remove-optional_value & updated modules 2012-11-09 13:31:13 -03:00
Daniel Nichter 240e7481f0 Remove duplicate code block I created by merge bits and pieces of branches, thereby confusing bzr. 2012-11-09 08:45:23 -07:00
Daniel Nichter 66c4c8b98b Merge fix-1045317-pt-osc-statistics 2012-11-09 08:44:09 -07:00
Daniel Nichter 1ec018fd82 Simplify and reword --statistics code, tests, and docs. 2012-11-08 18:05:02 -07:00
Daniel Nichter da50daf0f7 Merge pt-osc-data-loss-bug-1068562 2012-11-08 16:38:07 -07:00
Brian Fraser 7beb0b518e Reverted a few unnecessary changes 2012-11-08 17:47:00 -03:00