Commit Graph

4524 Commits

Author SHA1 Message Date
Daniel Nichter
81caf6addc Convert size \d+[KMGT] opts in parse_options.sh. 2012-01-26 10:44:55 -07:00
baron@percona.com
5acec0d38e initial documentation 2012-01-25 16:11:09 -05:00
Daniel Nichter
dd44a9b851 Add --test-matching to replace testing via STDIN/ARGV. 2012-01-25 11:37:10 -07:00
Daniel Nichter
73bc7cdcf8 Change default --dest to /var/lib/pt-stalk. Don't check --dest unless --collect. Fix POD formatting for --function. 2012-01-24 14:22:19 -07:00
Daniel Nichter
77e5e4c3f2 Simpler test for +w access to --log. 2012-01-24 13:24:07 -07:00
Daniel Nichter
b47679cf97 Implement --[no]collect. 2012-01-24 13:20:07 -07:00
Daniel Nichter
c2fd3f54c2 Use "yes" for true, "" for false. Use $PO_DIR instead of $TMP_DIR/po. Add and test Baron's code for 'Options and values after processing arguments'. Make --help exit 0 unless there were errors. 2012-01-24 12:49:18 -07:00
Daniel Nichter
42a8e39635 Use better Bash. 2012-01-24 12:28:41 -07:00
Daniel Nichter
36c14f492a Don't use grep -q. 2012-01-24 12:15:29 -07:00
Daniel Nichter
c965d7c172 Fix POD syntax error. 2012-01-24 12:07:42 -07:00
Daniel Nichter
fa6a6cb8ff Merge lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0-docs r155. 2012-01-24 12:01:47 -07:00
Daniel Nichter
3c97ae27d1 Add and test --config to pt-stalk. 2012-01-24 11:50:48 -07:00
Daniel Nichter
4905e3503c Handle --config FILE[,FILE,...] in parse_options.sh. 2012-01-24 11:18:41 -07:00
Daniel Nichter
0a81ddeaad Merge lp:~percona-toolkit-dev/percona-toolkit/fix-zombie-bug-919819. 2012-01-24 10:01:06 -07:00
Daniel Nichter
0f1687608d Ignore SIGCHLD to avoid zombies. 2012-01-24 09:55:18 -07:00
Daniel Nichter
cab3bb6eab Update parse_options.sh in pt-stalk. 2012-01-23 10:54:43 -07:00
Daniel Nichter
034f76d77e Fix handling EXT_ARGV. 2012-01-23 10:53:41 -07:00
Daniel Nichter
0d348ce289 Make parse_options work with everything: cmd line, config files, values with spaces, op val, op=val, etc. 2012-01-23 10:30:42 -07:00
Daniel Nichter
65a3ab5157 Handle values with spaces. Still needs work; one test is failing. 2012-01-21 13:59:02 -07:00
baron@percona.com
b13ff30bb7 finish docs 2012-01-21 11:19:50 -05:00
baron@percona.com
63ea85e755 docs 2012-01-21 09:15:45 -05:00
Daniel Nichter
acbc6b4622 Parse config files. Refactor parse_option.sh. Print --help and --version to STDOUT. 2012-01-20 11:34:51 -07:00
Daniel Nichter
f5f388e617 Merge lp:~percona-toolkit-dev/percona-toolkit/fix-bug-915598. 2012-01-19 13:08:05 -07:00
Daniel Nichter
2b9e578908 Fix util/update-modules. Use Cxn in pt-config-diff to make --ask-pass work. 2012-01-19 13:04:42 -07:00
Daniel Nichter
88304e69fb Replace MKDEBUG with PTDEBUG in modules. 2012-01-19 12:46:56 -07:00
Daniel Nichter
51b93a6235 Fix --help description interpolation. 2012-01-19 12:20:33 -07:00
Daniel Nichter
ba4b4f3059 Log how pt-stalk was ran. Update modules in tool. Tweak 'Starting' and 'Exiting' log lines. 2012-01-19 11:51:24 -07:00
Daniel Nichter
9e29cc205a Make test quiet. 2012-01-19 11:13:01 -07:00
Daniel Nichter
2412e01aa0 Use which to get programs. Don't create file unless the program or file exists. 2012-01-19 10:46:48 -07:00
Brian Fraser
ad552756b2 Automatic headers & improvements. 2012-01-18 19:01:19 -03:00
Brian Fraser
5b43ed0d5e More changes as per Baron's review.
Tries to implement a facsimile to http://www.xaprb.com/blog/2011/03/18/how-to-gather-statistics-at-regular-intervals/
For both sampling and rendering.
2012-01-18 05:19:48 -03:00
Daniel Nichter
6e2b670af6 Die if --log, --pid, or --dest aren't accessible. Also die if po dir isn't accessible. 2012-01-17 13:12:08 -07:00
Daniel Nichter
b2bac5c765 Quote in tmpdir.sh and fix typo in doc. 2012-01-17 12:15:49 -07:00
Brian Fraser
3a66cf5187 Removed lib/pt_diskstats.pm, since it's no longer needed. 2012-01-17 11:41:15 -03:00
Brian Fraser
05fec15473 Fixes as per Baron's review. 2012-01-17 11:40:01 -03:00
Brian Fraser
076c0d70b1 (Whoops. Forgot to commit the changed tests) 2012-01-16 09:48:59 -03:00
Brian Fraser
d01d838b64 Several changes as per Baron & Daniel's mails.
Most importantly, it replaces --zero-rows with --show-inactive, and
changes the default logic used to decide when to print a device.
2012-01-16 09:37:53 -03:00
Daniel Nichter
894c492c6d Update Bash libs. Quote stuff in tool's code. Remove flock. 2012-01-13 10:23:45 -07:00
Daniel Nichter
cfce6e6eb2 More quoting and tweaking re Baron's review. 2012-01-13 10:02:17 -07:00
Daniel Nichter
87d12c9802 Don't warn about invalid lines, just debug them. Anchor TS pattern. Unset --sample-time unless --group-by sample. 2012-01-12 14:26:31 -07:00
Daniel Nichter
60e16254d3 Correction to r140: only the test marked in this diff needs to be fixed. 2012-01-12 12:09:01 -07:00
Daniel Nichter
9404ff84ef Rewrite pt-diskstats.t but all tests need to be fixed. Update modules in pt-diskstats, use PTDEBUG, check regex opts. Remove output_fh from Diskstats. Fix DiskstatsMenu header so update-modules can see it. 2012-01-12 12:06:50 -07:00
Daniel Nichter
8d70a272fe Simplify parse_diskstats_line() and _calc_delta_for(). Use UPPERCASE for constants. Don't save unused values in dev stats array. Use actual values from an OptionParser/pt-diskstats. 2012-01-12 10:09:40 -07:00
Brian Fraser
3165b3c0f8 Slew of changes from Daniel's review. 2012-01-12 10:37:49 -03:00
Daniel Nichter
a9afea4506 Quote vals in Bash libs. Add tests for log_warn_die.sh and alt_cmds.sh. Make --help test path independent. 2012-01-11 11:31:41 -07:00
Brian Fraser
6d47e958c7 Change ->filter_zeroed_rows into ->zero_rows. 2012-01-10 16:28:32 -03:00
Brian Fraser
f173069109 Stop using /(?=)/ since /.+/ is good enough.
Originally, DiskstatsMenu differentiated between an empty pattern
entered by the user (which in the shell version meant "match all")
and any other valid pattern by replacing it with /(?=)/.

However, Diskstats now carries the original string, inside the
OptionParser object, so the above was redundant.
2012-01-10 16:10:50 -03:00
Brian Fraser
eaae370f81 Removed the handling of the partition format.
/proc/diskstats actually has two formats, one for devices, one for
partitions. The latter wasn't handled by the original pt-diskstats,
but one of the previous commits introducing some minimal handling
for that. This commit removes that, since the partition format
doesn't have enough information to be useful.
2012-01-10 14:28:24 -03:00
Brian Fraser
13210d1978 Explicit setter for filename. 2012-01-10 14:16:44 -03:00
Brian Fraser
5ad1bc4fbb Explicit setter for device_regex and column_regex. 2012-01-10 14:14:32 -03:00