Brian Fraser
ad552756b2
Automatic headers & improvements.
2012-01-18 19:01:19 -03:00
Daniel Nichter
6e2b670af6
Die if --log, --pid, or --dest aren't accessible. Also die if po dir isn't accessible.
2012-01-17 13:12:08 -07:00
Brian Fraser
05fec15473
Fixes as per Baron's review.
2012-01-17 11:40:01 -03:00
Brian Fraser
d01d838b64
Several changes as per Baron & Daniel's mails.
...
Most importantly, it replaces --zero-rows with --show-inactive, and
changes the default logic used to decide when to print a device.
2012-01-16 09:37:53 -03:00
Daniel Nichter
cfce6e6eb2
More quoting and tweaking re Baron's review.
2012-01-13 10:02:17 -07:00
Daniel Nichter
87d12c9802
Don't warn about invalid lines, just debug them. Anchor TS pattern. Unset --sample-time unless --group-by sample.
2012-01-12 14:26:31 -07:00
Daniel Nichter
9404ff84ef
Rewrite pt-diskstats.t but all tests need to be fixed. Update modules in pt-diskstats, use PTDEBUG, check regex opts. Remove output_fh from Diskstats. Fix DiskstatsMenu header so update-modules can see it.
2012-01-12 12:06:50 -07:00
Daniel Nichter
8d70a272fe
Simplify parse_diskstats_line() and _calc_delta_for(). Use UPPERCASE for constants. Don't save unused values in dev stats array. Use actual values from an OptionParser/pt-diskstats.
2012-01-12 10:09:40 -07:00
Brian Fraser
3165b3c0f8
Slew of changes from Daniel's review.
2012-01-12 10:37:49 -03:00
Daniel Nichter
a9afea4506
Quote vals in Bash libs. Add tests for log_warn_die.sh and alt_cmds.sh. Make --help test path independent.
2012-01-11 11:31:41 -07:00
Brian Fraser
6d47e958c7
Change ->filter_zeroed_rows into ->zero_rows.
2012-01-10 16:28:32 -03:00
Brian Fraser
13210d1978
Explicit setter for filename.
2012-01-10 14:16:44 -03:00
Brian Fraser
5ad1bc4fbb
Explicit setter for device_regex and column_regex.
2012-01-10 14:14:32 -03:00
Brian Fraser
93279a03da
Explicit setter for out_fh.
2012-01-10 14:05:02 -03:00
Brian Fraser
187d921069
Explicit setter for filter_zeroed_rows
2012-01-10 13:46:05 -03:00
Brian Fraser
25909caa4e
Explicit setters for (curr|prev|first)_ts.
2012-01-10 13:40:51 -03:00
Brian Fraser
b4289010b1
Several fixes. --save-samples and --help should work now.
2012-01-10 10:47:50 -03:00
Daniel Nichter
d1bd7a9f3b
Change MKDEBUG to PTDEBUG. Remove 1.0.2 from release notes.
2011-12-30 09:23:41 -07:00
Daniel Nichter
cf10e3e521
Merge lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-2.0.
2011-12-29 17:39:26 -07:00
Daniel Nichter
c58dfca1b5
Use latest Quoter::(de)serialize_list() in pt-table-checksum and pt-table-sync. Add more char_chunking.t tests for pt-table-checksum.
2011-12-29 17:25:38 -07:00
Brian Fraser
1f06ea093a
Modified (de)serialize_list to handle undefs and empty string elements better.
2011-12-29 17:22:17 -03:00
Daniel Nichter
6088ffa43d
Use new Quoter (de)serialize_list() in pt-table-checksum and pt-table-sync.
2011-12-28 17:12:12 -07:00
Brian Fraser
85817a795c
Slight improvement to the deserialize regex and its test output.
2011-12-28 20:08:30 -03:00
Daniel Nichter
4197b09f53
Adjust code spacing, tweak comments, do only (de)serialize tests with database, give tests names.
2011-12-28 15:47:50 -07:00
Brian Fraser
88e82d665d
Include serialize_list() and deserialize_list() to roundtrip through a DB.
2011-12-28 16:44:49 -03:00
Daniel Nichter
09cd535d3a
Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs.
2011-12-27 15:37:09 -07:00
Daniel Nichter
f122861808
Fix --where with one nibble. Update chunk_index.t.
2011-12-27 11:12:40 -07:00
Brian Fraser
d3ef9edaaa
Several corrections as per Daniel and Baron's feedback.
...
Still TODO: Attributes still have a single method that doubles
as a getter and setter. The constructor for Diskstats is still
weird -- A tad more stricter than it should be, if anything.
->print_rest is still rest, even though that's hardly
memorable, mostly because of a lack of ideas on what to
rename it. The main loop in the Menu is still a while (1).
As a nice perk, it's nearly twice as fast now! It also adds a
_very_ experimental --memory-for-speed argument, which
turns on memoization for the current biggest bottleneck.
2011-12-22 19:24:56 -03:00
Daniel Nichter
1d8da408fc
Revert to r243 to undo pt-table-sync changes.
2011-12-22 12:06:25 -07:00
Daniel Nichter
cfc57c71af
Make pt-table-sync --replicate work with pt-table-checksum 2.0.
2011-12-22 10:10:22 -07:00
Daniel Nichter
457fa70668
Fix TableSyncer trace msg, implement --explain, fix locking/committing. Add aux dbh, dbh opts, and disconnect() to Cxn.
2011-12-21 21:12:03 -07:00
Daniel Nichter
ec8471ba28
Finish rewriting TableSyncer and updating its test. Add RowSyncerBidirectional.pm. Add GENLOG switch to start-sandbox.
2011-12-21 12:10:57 -07:00
Daniel Nichter
4c8fd5c080
Rewrite TableSyncer to use only NibbleIterator. Add RowSyncer. Return hashref from NibbleIterator.
2011-12-21 01:19:50 -07:00
Brian Fraser
467254aca3
Fixes to the Menu; additionally, changed the accepted format for samples.
...
Also made it hide rows that are all zeroes by default, as per the
blueprint.
2011-12-20 12:53:35 -03:00
Daniel Nichter
5d2e60791c
Don't add ORDER BY to nibble SQL by default.
2011-12-19 14:17:11 -07:00
Daniel Nichter
9baea8b7b6
Convert parse_option to sh, use Perl instead of awk, implement --help.
2011-12-19 12:51:47 -07:00
Daniel Nichter
3266e0aeca
Don't use OPT_TMPDIR in tmpdir.sh. Define EXT_ARGV in parse_options.sh.
2011-12-19 11:29:21 -07:00
Daniel Nichter
8439962b45
Make tests more flexible.
2011-12-19 10:44:36 -07:00
Daniel Nichter
bb315948cd
Parse disk space using df -P -k.
2011-12-19 10:22:42 -07:00
Brian Fraser
7b12dbec64
Work in progress v3: Working interactive mode, initial documentation.
...
With this most of the interactive mode should be working.
pt_diskstats.pm has the documentation and can be used for testing,
which should be in the next commit.
This commit also includes the revamped command line options.
2011-12-15 20:26:55 -03:00
Daniel Nichter
f3ac1b20c2
Add usage_or_errors() to parse_options.sh.
2011-12-15 12:01:22 -07:00
Daniel Nichter
92c8635c4a
Fix and test safeguards.sh. Implement disk space+margin check.
2011-12-14 16:12:43 -07:00
Brian Fraser
0fd09e8f6e
Work in progress v2: Redesign pt-diskstats in Perl.
2011-12-13 14:53:05 -03:00
Daniel Nichter
0cfef9134c
Collect proclist in loop.
2011-12-08 11:45:16 -07:00
Daniel Nichter
c486bf8461
Remove ON_EXIT.
2011-12-07 10:48:47 -07:00
Daniel Nichter
578896c217
Add daemon.sh.
2011-12-07 10:37:10 -07:00
Daniel Nichter
f6306c9ec0
Test collect.sh. Use --run-time instead of --interval for collect loop. Fix and require per-test test names in util/test-bash-functions. Fix OPT_ERR in parse_options.sh.
2011-12-06 13:23:47 -07:00
Daniel Nichter
c804079c0d
Add Bash libs collect.sh (pt-collect internals), safeguards.sh, and alt_cmds.sh.
2011-12-05 13:48:54 -07:00
Daniel Nichter
75d2c99d45
Parse option specs, allow negating with --no-, add more tests.
2011-12-02 11:31:31 -07:00
Daniel Nichter
173085e823
Rename tmpdir funcs. Include pid in tmpdir name.
2011-11-28 11:16:23 -07:00
