Commit Graph

214 Commits

Author SHA1 Message Date
Daniel Nichter
8db5b77a4e Change HTTPMicro to HTTP::Micro in Pingback to avoid 'subroutine redefined' errors. 2012-08-21 08:19:52 -06:00
Daniel Nichter
616a98f86c Add --[no]version-check, VersionCheck, Pingback, and HTTPMicro to tools having the version check feature. 2012-08-17 16:25:56 -06:00
Daniel Nichter
4fe1a61f0e Add lib/Percona/Toolkit.pm for $Percona::Toolkit::VERSION. Put that in pt-diskstats. Add util/tool-header to update %INC magic when bin/update-modules is ran. 2012-08-17 11:27:41 -06:00
Daniel Nichter
9d809ce5ea Use int($flags) to prevent fcntl(F_SETFL) error. Clean up ReadKeyMini.pm and Diskstats.t. 2012-08-15 13:28:14 -06:00
Brian Fraser
c08c0c6a7a Fix for 1035311: pt-diskstats shows wrong device name 2012-08-10 15:36:34 -03:00
Daniel Nichter
f8c375a249 Build percona-toolkit-2.1.3 2012-08-03 19:41:41 +01:00
Brian Fraser
53a7537d11 Updated modules for all tools 2012-08-02 09:54:25 -03:00
Brian Fraser
4266e92692 Silence tput and stty warnings in ReadKeyMini 2012-07-12 16:25:39 -03:00
Daniel Nichter
6d71b91bfe Build percona-toolkit-2.1.2 2012-06-12 07:06:39 -07:00
Baron Schwartz
47fb3d65e8 Fix a bazillion tests with ANSI sql_mode, and get rid of a bunch of MySQLDump usage. 2012-06-09 14:43:33 -04:00
Brian Fraser fraserb@gmail.com
345a21a82e Replace the last instances of MKDEBUG 2012-06-05 12:28:36 -03:00
Brian Fraser fraserb@gmail.com
6b93d51e43 ReadKeyMini: Restore STDIN flags in cooked()
This will probably resolve bug #946707: pt-sift loses STDIN after pt-diskstats
2012-06-05 12:16:49 -03:00
Daniel Nichter
5a77e8c09c Fix scrolling header for --group-by=all. 2012-05-10 14:06:52 -07:00
Daniel Nichter
5079930b72 Merge change-diskstats-group-by-default-fix-bug-952727. 2012-05-09 07:48:59 -06:00
Daniel Nichter
c3724aedca Build percona-toolkit-2.1.1 2012-04-03 12:42:45 -07:00
Daniel Nichter
f4c978c957 Build percona-toolkit-2.0.4 2012-03-07 15:41:54 -08:00
Brian Fraser fraserb@gmail.com
a252f5b7f8 Change a _d() introduced in previous commits to possily avoid crashes 2012-03-06 14:04:47 -03:00
Brian Fraser fraserb@gmail.com
2faf79e6e3 Update pt-diskstats to keep in sync with the previous commit. 2012-03-02 11:07:55 -08:00
Daniel Nichter
4d5d4da4b7 Build percona-toolkit-2.0.3 2012-02-03 16:25:29 -07:00
Daniel Nichter
2c48190676 Remove unused --[no]automatic-headers from pt-diskstats. Also remove extra headers and s/MKDEBUG/PTDEBUG/g, and add ENVIRONMENT doc section. 2012-02-03 16:20:53 -07:00
baron@percona.com
8631fbff09 explain the even-intervals rule in the docs 2012-02-03 12:24:59 -05:00
baron@percona.com
dcc6b501d1 fix merge conflict in docs 2012-02-03 12:10:02 -05:00
baron@percona.com
24203f675d docu changes 2012-02-03 12:09:00 -05:00
Brian Fraser
27323776a8 Applied Baron's patch, which changes how qtime and stime are calculated.
Also includes a second attempt at fixing the $Diskstats::printed_lines bug,
and fixed how the timestamp is chosen if --show-timestamps is in effect.
2012-02-03 14:00:40 -03:00
Brian Fraser
0a25bd038b Merge with Baron's branch, and changes as per the new spec/docs. 2012-02-03 12:11:14 -03:00
baron@percona.com
6770f1a9dc clarify documentation, serving as a spec for Brian 2012-02-02 23:13:38 -05:00
baron@percona.com
88fc42514f merge Brian's changes 2012-02-02 20:33:23 -05:00
Brian Fraser
d11856d48f Moved the calculation of {read,write}_ios_sec around a bit and marked it as TODO 2012-02-02 19:38:03 -03:00
Brian Fraser
2f3f75965a Fixed a 'Use of uninitialized value' error in Diskstats->print_deltas()
It's not clear to me how this can even happen, as the variable is
package-scoped and set during compilation, but this should fix it.
2012-02-02 11:14:20 -03:00
baron@percona.com
bfc61bd6b1 tweaks to docs 2012-02-02 08:45:32 -05:00
baron@percona.com
b837a0ca7e merge Brian's doc changes 2012-02-02 08:42:42 -05:00
baron@percona.com
13bf6c7f8f tweaks to docs, targeting the desired behavior that isn't there yet 2012-02-02 08:36:32 -05:00
Brian Fraser
b0f7bc4fc6 Tweaks requested by Baron, plus fixes.
Tweaks:
* --headers command line option, which can be used to
        enable/disable the automatic headers, and the
        automatic empty lines between samples.
* --show-timestamps, which changes the #ts line with
        a timestamp in the HH:MM:SS format.
* Always use ReadKeyMini, even when we have Term::ReadKey.
        In the latter case, use the Term::ReadKey functions,
        but if they fail, try again with our own versions.

Fix:
Looks like I forgot to actually enable the "save the current, first
and last" samples. This is now on. It should mean faster and better
output when changing --group-by modes.
2012-02-01 19:12:03 -03:00
baron@percona.com
e0d358fce1 documentation updates 2012-02-01 11:41:39 -05:00
Brian Fraser
7c4c186978 Change how Diskstats waits for its first handful of samples.
This fixes two bugs -- One a rounding error, one a desyncronization
between the main program and the data gathering daemon.

Additionally, it changes how the daemon prints the very first
sample. Before it would unconditionally wait until the time was
%$sample-time, which meant that in a worst case scenario,
a user could be left waiting for a while before seeing a line
of output.
This commit changes that first wait to only sleep if less
than 20% away from %$sample-time.
2012-02-01 12:14:09 -03:00
Brian Fraser
3de8aa530b More fixes as per Baron's review. 2012-01-31 22:44:00 -03:00
Brian Fraser
940b8d6bab Merge from Baron's doc branch 2012-01-31 13:47:09 -03:00
Brian Fraser
73c1e466d7 Several fixes & changes:
* qtime and stime computed correctly
* Interactive mode and changing groups doesn't fail
* Interactive mode no longer uses a file to gather samples.
2012-01-30 17:44:18 -03:00
baron@percona.com
5acec0d38e initial documentation 2012-01-25 16:11:09 -05:00
Brian Fraser
ad552756b2 Automatic headers & improvements. 2012-01-18 19:01:19 -03:00
Brian Fraser
5b43ed0d5e More changes as per Baron's review.
Tries to implement a facsimile to http://www.xaprb.com/blog/2011/03/18/how-to-gather-statistics-at-regular-intervals/
For both sampling and rendering.
2012-01-18 05:19:48 -03:00
Brian Fraser
05fec15473 Fixes as per Baron's review. 2012-01-17 11:40:01 -03:00
Brian Fraser
d01d838b64 Several changes as per Baron & Daniel's mails.
Most importantly, it replaces --zero-rows with --show-inactive, and
changes the default logic used to decide when to print a device.
2012-01-16 09:37:53 -03:00
Daniel Nichter
87d12c9802 Don't warn about invalid lines, just debug them. Anchor TS pattern. Unset --sample-time unless --group-by sample. 2012-01-12 14:26:31 -07:00
Daniel Nichter
9404ff84ef Rewrite pt-diskstats.t but all tests need to be fixed. Update modules in pt-diskstats, use PTDEBUG, check regex opts. Remove output_fh from Diskstats. Fix DiskstatsMenu header so update-modules can see it. 2012-01-12 12:06:50 -07:00
Daniel Nichter
8d70a272fe Simplify parse_diskstats_line() and _calc_delta_for(). Use UPPERCASE for constants. Don't save unused values in dev stats array. Use actual values from an OptionParser/pt-diskstats. 2012-01-12 10:09:40 -07:00
Brian Fraser
5098d33372 Updated tool based on the previous commits. 2012-01-10 10:55:16 -03:00
Brian Fraser
93271379d8 Tool updated based on the previous commit. 2011-12-22 19:32:51 -03:00
Brian Fraser
467254aca3 Fixes to the Menu; additionally, changed the accepted format for samples.
Also made it hide rows that are all zeroes by default, as per the
blueprint.
2011-12-20 12:53:35 -03:00
Brian Fraser
13c9c5b0bb Added the actual pt-diskstats tool.
Missing a doc overhaul and tests, but this deals with most of the
feature upgrades in the blueprint.

The shell version of pt-diskstats is now in bin has pt-diskstats-shell,
in case that's needed.
2011-12-16 13:40:22 -03:00