Daniel Nichter
87d12c9802
Don't warn about invalid lines, just debug them. Anchor TS pattern. Unset --sample-time unless --group-by sample.
2012-01-12 14:26:31 -07:00
Daniel Nichter
9404ff84ef
Rewrite pt-diskstats.t but all tests need to be fixed. Update modules in pt-diskstats, use PTDEBUG, check regex opts. Remove output_fh from Diskstats. Fix DiskstatsMenu header so update-modules can see it.
2012-01-12 12:06:50 -07:00
Daniel Nichter
8d70a272fe
Simplify parse_diskstats_line() and _calc_delta_for(). Use UPPERCASE for constants. Don't save unused values in dev stats array. Use actual values from an OptionParser/pt-diskstats.
2012-01-12 10:09:40 -07:00
Brian Fraser
3165b3c0f8
Slew of changes from Daniel's review.
2012-01-12 10:37:49 -03:00
Brian Fraser
6d47e958c7
Change ->filter_zeroed_rows into ->zero_rows.
2012-01-10 16:28:32 -03:00
Brian Fraser
13210d1978
Explicit setter for filename.
2012-01-10 14:16:44 -03:00
Brian Fraser
5ad1bc4fbb
Explicit setter for device_regex and column_regex.
2012-01-10 14:14:32 -03:00
Brian Fraser
93279a03da
Explicit setter for out_fh.
2012-01-10 14:05:02 -03:00
Brian Fraser
187d921069
Explicit setter for filter_zeroed_rows
2012-01-10 13:46:05 -03:00
Brian Fraser
25909caa4e
Explicit setters for (curr|prev|first)_ts.
2012-01-10 13:40:51 -03:00
Brian Fraser
b4289010b1
Several fixes. --save-samples and --help should work now.
2012-01-10 10:47:50 -03:00
Brian Fraser
d3ef9edaaa
Several corrections as per Daniel and Baron's feedback.
...
Still TODO: Attributes still have a single method that doubles
as a getter and setter. The constructor for Diskstats is still
weird -- A tad more stricter than it should be, if anything.
->print_rest is still rest, even though that's hardly
memorable, mostly because of a lack of ideas on what to
rename it. The main loop in the Menu is still a while (1).
As a nice perk, it's nearly twice as fast now! It also adds a
_very_ experimental --memory-for-speed argument, which
turns on memoization for the current biggest bottleneck.
2011-12-22 19:24:56 -03:00
Brian Fraser
467254aca3
Fixes to the Menu; additionally, changed the accepted format for samples.
...
Also made it hide rows that are all zeroes by default, as per the
blueprint.
2011-12-20 12:53:35 -03:00
Brian Fraser
7b12dbec64
Work in progress v3: Working interactive mode, initial documentation.
...
With this most of the interactive mode should be working.
pt_diskstats.pm has the documentation and can be used for testing,
which should be in the next commit.
This commit also includes the revamped command line options.
2011-12-15 20:26:55 -03:00
Brian Fraser
0fd09e8f6e
Work in progress v2: Redesign pt-diskstats in Perl.
2011-12-13 14:53:05 -03:00
Daniel Nichter
2f9ab4081a
Fix prepared report for statements without corresponding prep or exec.
2011-11-08 12:53:50 -07:00
Daniel Nichter
0f05ca9b94
Fix multi-column index nibbling. Remove extra spaces in generated statements.
2011-09-12 08:14:57 -06:00
Daniel Nichter
3ed822e8e6
Implement dynamic chunk size, set_chunk_size().
2011-09-12 07:32:19 -06:00
Daniel Nichter
985ee65928
Pass EXPLAIN sths to callbacks.
2011-09-11 11:10:11 -06:00
Daniel Nichter
8ce093655f
Add dms arg, remove before_row callback, pass some args to callbacks, get next boundary if no rows (so exec_nibble callback can skip nibbles).
2011-09-11 10:22:40 -06:00
Daniel Nichter
84f7c47ff4
Rename new TableChecksum to RowChecksum and revert TableChecksum to r108. This will avoid completely break TableSync*.pm and pt-table-sync.
2011-09-10 13:46:55 -06:00
Daniel Nichter
968d10ac37
Refactor TableChecksum for NibbleIterator (use only BIT_XOR, return just column list, etc.).
2011-09-10 12:21:00 -06:00
Daniel Nichter
c989bd29dd
First working NibbleIterator.
2011-09-09 17:29:28 -06:00
Daniel Nichter
7fde36a65b
Create NibbleIterator. Cleanup TableNibbler. Fix bug in SchemaIterator.
2011-09-09 11:50:19 -06:00
Daniel Nichter
a7ab27bb54
Don't get min/max a 2nd time in _chunk_char(). Use where in _chunk_char(). Test char chunking world_city.name with real range stats. Add failing pt-table-checksum char chunk --where test.
2011-08-27 11:17:28 -06:00
Daniel Nichter
2e0f607589
Pass --where to get_range_statistics().
2011-08-27 09:23:36 -06:00
Daniel Nichter
64c6ad418e
Fix MockSyncStream.t for pre-DBD::mysql 4.001.
2011-08-24 11:37:45 -06:00
Daniel Nichter
fb8f3148f5
The last Daemon.t stabilizer?
2011-08-24 11:26:18 -06:00
Daniel Nichter
a1bee06edf
One more stabilizer for Daemon.t.
2011-08-24 11:24:07 -06:00
Daniel Nichter
2c7257caff
More stabilizing Daemon.t.
2011-08-24 11:20:27 -06:00
Daniel Nichter
e134aa665b
Try to make Daemon.t more reliable.
2011-08-24 11:04:47 -06:00
Daniel Nichter
f9bfb641ca
Skip ShowErrorStatement test unless DBD::mysql >= 4.003.
2011-08-24 10:13:11 -06:00
Daniel Nichter
e93381d6b6
Make sandbox scripts simpler and more reliable. Remove "remove" option from stop-sandbox and update tests that used it.
2011-08-23 09:11:00 -06:00
Daniel Nichter
5b31ee0359
Remerge/push changes from r81.
2011-08-22 10:48:53 -06:00
Daniel Nichter
669957ae79
Test bug 819421. Cannot repro.
2011-08-22 10:45:09 -06:00
Daniel Nichter
d9c89e3ff0
Add MySQL 5.0 output samples for SchemaIterator tests. Fix mk references in daemonizes.pl so Daemon.t passes.
2011-08-19 12:17:26 -06:00
Daniel Nichter
5fadc7e759
Change last use of MAATKIT_WORKING_COPY to PERCONA_TOOLKIT_BRANCH.
2011-08-05 11:27:23 -06:00
Daniel Nichter
1a720f7c67
Removed unused modules.
2011-08-02 17:32:12 -06:00
Daniel Nichter
945cfbd153
Fix Bash tests. Add basic pt-align tests.
2011-08-02 15:14:06 -06:00
Daniel Nichter
ea0b8c3d5a
Remove unused modules and their tests.
2011-07-13 16:55:38 -06:00
Daniel Nichter
1480606bb2
Fix MasterSlave::get_slave_lag(). Revert pt-table-checksum to use old SchemaIterator. Remove pt-table-usage tests. Fix use of var from another package in pt-query-digest. Remove reference to $VERSION from pt-show-grants. Change mk- to pt- in pt-variable-advisor sample.
2011-07-13 16:36:14 -06:00
Daniel Nichter
39ea018581
Finish re-branding tools. Remove pt-schema-advisor.
2011-07-12 16:36:36 -06:00
Daniel Nichter
b805f7c92d
Remove $Revision$ and finish re-branding modules. Rename MaatkitTest.pm to PerconaTest.pm. Put copyrights on one line.
2011-07-12 15:47:07 -06:00
Daniel Nichter
64ddb421e5
Change maatkit to percona-toolkit in OptionParser defaults files.
2011-07-12 09:06:43 -06:00
Daniel Nichter
b4b6376be1
Add forked Maatkit tools in bin/ and their tests in t/.
2011-06-24 16:02:05 -06:00
Daniel Nichter
6c501128e6
Add lib/, t/lib/, and sandbox/. All modules are updated and passing on MySQL 5.1.
2011-06-24 11:22:06 -06:00
