Brian Fraser
d3ef9edaaa
Several corrections as per Daniel and Baron's feedback.
...
Still TODO: Attributes still have a single method that doubles
as a getter and setter. The constructor for Diskstats is still
weird -- A tad more stricter than it should be, if anything.
->print_rest is still rest, even though that's hardly
memorable, mostly because of a lack of ideas on what to
rename it. The main loop in the Menu is still a while (1).
As a nice perk, it's nearly twice as fast now! It also adds a
_very_ experimental --memory-for-speed argument, which
turns on memoization for the current biggest bottleneck.
2011-12-22 19:24:56 -03:00
Daniel Nichter
1d8da408fc
Revert to r243 to undo pt-table-sync changes.
2011-12-22 12:06:25 -07:00
Daniel Nichter
2760322c87
Don't bidi cmp equal rows. Commit if not --lock and using txn. Fix pt-table-sync basics.t.
2011-12-22 12:01:03 -07:00
Daniel Nichter
cfc57c71af
Make pt-table-sync --replicate work with pt-table-checksum 2.0.
2011-12-22 10:10:22 -07:00
Daniel Nichter
255b276435
Make pt-table-sync use new NibbleIterator-only TableSyncer, and also use Cxn.
2011-12-21 21:13:19 -07:00
Daniel Nichter
457fa70668
Fix TableSyncer trace msg, implement --explain, fix locking/committing. Add aux dbh, dbh opts, and disconnect() to Cxn.
2011-12-21 21:12:03 -07:00
Daniel Nichter
ec8471ba28
Finish rewriting TableSyncer and updating its test. Add RowSyncerBidirectional.pm. Add GENLOG switch to start-sandbox.
2011-12-21 12:10:57 -07:00
Daniel Nichter
4c8fd5c080
Rewrite TableSyncer to use only NibbleIterator. Add RowSyncer. Return hashref from NibbleIterator.
2011-12-21 01:19:50 -07:00
Brian Fraser
467254aca3
Fixes to the Menu; additionally, changed the accepted format for samples.
...
Also made it hide rows that are all zeroes by default, as per the
blueprint.
2011-12-20 12:53:35 -03:00
Daniel Nichter
6fad44d58c
Change SQL for --resume last chunk to fix bug 898318.
2011-12-19 15:48:52 -07:00
Daniel Nichter
d3b074b14e
Don't ORDER BY in the nibble sql.
2011-12-19 14:25:48 -07:00
Daniel Nichter
5d2e60791c
Don't add ORDER BY to nibble SQL by default.
2011-12-19 14:17:11 -07:00
Daniel Nichter
650641b052
Check --pid even if not --daemonize.
2011-12-19 13:44:40 -07:00
Daniel Nichter
482875e330
Don't rm po before --help output.
2011-12-19 12:59:38 -07:00
Daniel Nichter
c380d8c348
Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs r136.
2011-12-19 12:55:41 -07:00
Daniel Nichter
0056014339
Let desc sentence be terminated by period of question mark.
2011-12-19 12:55:14 -07:00
Daniel Nichter
5fc8ea1f70
Merge Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs r135.
2011-12-19 12:53:09 -07:00
Daniel Nichter
9baea8b7b6
Convert parse_option to sh, use Perl instead of awk, implement --help.
2011-12-19 12:51:47 -07:00
Daniel Nichter
0a88c57bf9
Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs r134.
2011-12-19 11:31:00 -07:00
Daniel Nichter
3266e0aeca
Don't use OPT_TMPDIR in tmpdir.sh. Define EXT_ARGV in parse_options.sh.
2011-12-19 11:29:21 -07:00
Daniel Nichter
5ce6fba919
Do not daemonize by default.
2011-12-19 11:10:02 -07:00
Daniel Nichter
f684641d43
Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs r133.
2011-12-19 10:50:31 -07:00
Daniel Nichter
8439962b45
Make tests more flexible.
2011-12-19 10:44:36 -07:00
Daniel Nichter
bb315948cd
Parse disk space using df -P -k.
2011-12-19 10:22:42 -07:00
Daniel Nichter
eab12a1c81
Fix typos.
2011-12-16 10:09:10 -07:00
Brian Fraser
8da8d1ff61
Diskstats.pm: Wrong math for millisecond to second.
...
Sorry about that. Mind bug on my side.
2011-12-16 13:55:31 -03:00
Brian Fraser
13c9c5b0bb
Added the actual pt-diskstats tool.
...
Missing a doc overhaul and tests, but this deals with most of the
feature upgrades in the blueprint.
The shell version of pt-diskstats is now in bin has pt-diskstats-shell,
in case that's needed.
2011-12-16 13:40:22 -03:00
Daniel Nichter
7ff088e130
Fix typo.
2011-12-16 08:13:16 -07:00
Brian Fraser
7b12dbec64
Work in progress v3: Working interactive mode, initial documentation.
...
With this most of the interactive mode should be working.
pt_diskstats.pm has the documentation and can be used for testing,
which should be in the next commit.
This commit also includes the revamped command line options.
2011-12-15 20:26:55 -03:00
Daniel Nichter
09467de2b3
Remove --execute-command.
2011-12-15 14:31:23 -07:00
Daniel Nichter
78603f5d03
Test pt-stalk. Fix disk space+margin check. Fix checking --iterations. Add EXIT_REASON. Fix grepping status var.
2011-12-15 14:28:10 -07:00
Daniel Nichter
ce63ce77cd
Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs r131 and update in pt-stalk.
2011-12-15 12:16:33 -07:00
Daniel Nichter
a172a3f2a7
Return 0 only if no --help, --verion, or opt errors.
2011-12-15 12:12:18 -07:00
Daniel Nichter
c33fe97cf7
Check disk space+margin before collecting. More code comments.
2011-12-15 12:02:47 -07:00
Daniel Nichter
f3ac1b20c2
Add usage_or_errors() to parse_options.sh.
2011-12-15 12:01:22 -07:00
Daniel Nichter
b5a14933a5
Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs r129.
2011-12-14 16:21:23 -07:00
Daniel Nichter
92c8635c4a
Fix and test safeguards.sh. Implement disk space+margin check.
2011-12-14 16:12:43 -07:00
Brian Fraser
0fd09e8f6e
Work in progress v2: Redesign pt-diskstats in Perl.
2011-12-13 14:53:05 -03:00
Brian Fraser
43b29d6374
Work in progress: Redesign pt-diskstats in Perl.
...
Mostly bits and pieces at the moments. ReadKeyMini is a portable-ish
Term::ReadKey. Used here by DiskstatsMenu, which is currently only
for show.
Diskstats has most of the logic of the old pt-diskstats, with parts
now implemented by the DiskstatsGroupBy* classes; The latter subclass
the former.
As mentioned at the start, this is a work in progress. In addition to to
not having all the parts attached, also missing are the data-gathering mode,
the command-line argument parsing, and a large amount of tests.
2011-12-08 19:26:04 -03:00
Daniel Nichter
ba7bfec6c8
Merge ~daniel-nichter/percona-toolkit/bash-tool-libs r128.
2011-12-08 14:27:05 -07:00
Daniel Nichter
2c8021e7d6
Check -x mysql, mysqladmin, and that MySQL is alive before starting.
2011-12-08 14:26:10 -07:00
Daniel Nichter
90fbfaf41f
Don't quote $EXT_ARGV so multiple opts work.
2011-12-08 14:25:35 -07:00
Daniel Nichter
3a9e586b72
Merge ~daniel-nichter/percona-toolkit/bash-tool-libs r127.
2011-12-08 13:50:18 -07:00
Daniel Nichter
36e88c8e40
Fix typo.
2011-12-08 13:49:44 -07:00
Daniel Nichter
b91020a007
Update modules in pt-stalk.
2011-12-08 13:35:48 -07:00
Daniel Nichter
6f42fa9327
Merge ~daniel-nichter/percona-toolkit/bash-tool-libs r126.
2011-12-08 13:34:47 -07:00
Daniel Nichter
9ec71db008
Collect INFORMATION_SCHEMA.INNODB_LOCK_WAITS data.
2011-12-08 13:33:50 -07:00
Daniel Nichter
1c495936c8
Get Open_tables if <= 1000.
2011-12-08 12:05:20 -07:00
Daniel Nichter
0cfef9134c
Collect proclist in loop.
2011-12-08 11:45:16 -07:00
Daniel Nichter
9355a1af5d
Merge ~daniel-nichter/percona-toolkit/bash-tool-libs r123.
2011-12-07 11:59:39 -07:00