Commit Graph

66 Commits

Author SHA1 Message Date
Daniel Nichter
696a3b5e68 Fix mem/file size shortening in pt-summary and pt-mysql-summary. 2012-06-03 14:49:35 -07:00
Daniel Nichter
cc80f278d5 Code comment why MiB, GiB, etc. are used in shorten() and update that func in pt-summary and pt-mysql-summary. 2012-05-07 16:38:30 -06:00
Daniel Nichter
fdfd305dc5 Simplify and fix report_formatting::shorten(), and add Petabyte unit (in case it's needed). Update affected test samples. Add T_DIR to util/test-bash-functions. 2012-05-07 12:16:24 -06:00
Daniel Nichter
11bfeba0ea Remove unused developer test file. 2012-04-03 12:16:58 -06:00
Daniel Nichter
0286631514 Merge summary-tools-2.1. 2012-04-03 10:14:55 -06:00
Brian Fraser fraserb@gmail.com
c0dedd19bf - section() revamp
- Redirect STDERR for the collection part in both tools
- rm_tempdir in sigtrap
- A part of pt-mysql-summary still depended on the system being run,
  rather than the samples being read. Now it works properly.
2012-04-02 19:25:17 -03:00
Brian Fraser fraserb@gmail.com
6dbbd6de3b The previous merge went a bit wrong, and left the libraries unsynced with the tools; This commit fixes it. 2012-04-02 13:36:17 -03:00
Brian Fraser fraserb@gmail.com
761f8a5aac Merge more of Baron's changes, also re-implement the MySQL Executables section
Plus other bugfixes.
2012-03-30 23:00:57 -03:00
Brian Fraser fraserb@gmail.com
562a550a39 Fixes 2012-03-30 17:23:55 -03:00
Daniel Nichter
94d9483d03 Make vmstat, iostat, and mpstat run for --run-time not --interval. 2012-03-30 11:35:32 -06:00
Brian Fraser fraserb@gmail.com
33a4096663 Fix CPU_ARCH collection for Linux 2012-03-30 13:44:21 -03:00
Brian Fraser fraserb@gmail.com
f8113b4676 A parse_ethtools() that actually works 2012-03-29 19:44:51 -03:00
Brian Fraser fraserb@gmail.com
996a76a68e pt-summary shouldn't leave empty files; both summary tools should
die if passed a --save-samples directory that has files in it.
2012-03-29 19:21:32 -03:00
Brian Fraser fraserb@gmail.com
9fbb796022 More tests for get_var 2012-03-28 15:59:16 -03:00
Brian Fraser fraserb@gmail.com
3ee8f9ba71 Fixed the Table Cache bugs.
Also makes t/lib/bash/collect_system_info.sh actually call setup_commands.
2012-03-28 15:29:57 -03:00
Brian Fraser fraserb@gmail.com
4bb5968c23 More fixes as per the reviews.
- Took out ${prefix}-
- get_var sanity
- pt-mysql-summary now follows pt-summary's suit and doesn't take
  in files to write to
- pt-summary defers setting the CMD_FOO vars to a function, as
  otherwise it would skip our PATH mungling.
2012-03-28 13:04:14 -03:00
Brian Fraser fraserb@gmail.com
ae6c1e3789 More fixes:
- pt-mysql-summary's --read-samples shouldn't need an active connection
- Bunch of pt-summary bugs, particularly several relating to disks.
2012-03-27 12:53:31 -03:00
Brian Fraser fraserb@gmail.com
0e4fa22d18 *-summary tools: Changes from the reviews. Tests for pt-mysql-summary not finished yet 2012-03-27 06:19:37 -03:00
Brian Fraser fraserb@gmail.com
63064173a9 Correct test plans & add missing files 2012-03-24 16:27:47 -03:00
Brian Fraser fraserb@gmail.com
3ffda5677b pt-summary for 2.1, also changes to pt-mysql-summary from Daniel's review 2012-03-24 14:20:09 -03:00
Brian Fraser fraserb@gmail.com
88a9a66946 pt-mysql-summary for 2.1 2012-03-20 18:29:35 -03:00
Brian Fraser fraserb@gmail.com
55c7248c54 (more syncing) 2012-03-20 17:16:06 -03:00
Brian Fraser fraserb@gmail.com
31afeb73b5 (temp commit, syncing up) 2012-03-20 11:21:16 -03:00
Daniel Nichter
b9f6c14e30 Make collect.t mysqladmin debug test more reliable. 2012-02-24 09:39:49 -07:00
Daniel Nichter
6620595fac Make collect.t mysqladmin debug test reliable. 2012-02-24 09:18:18 -07:00
Daniel Nichter
b99293d1b3 Simplify and individuate Bash tests so prove reports failures where they happen. 2012-02-23 13:58:57 -07:00
Daniel Nichter
65bf629184 Remove test debug hacks. 2012-02-21 14:23:41 -07:00
Daniel Nichter
7016b26f09 More test debug hacks. 2012-02-16 10:52:28 -07:00
Daniel Nichter
c800ba8fa1 Add test debug hack back to collect.sh. 2012-02-14 14:50:38 -07:00
Daniel Nichter
ab6bafe3ed Remove debug hack from collect.sh. 2012-02-14 14:22:17 -07:00
Daniel Nichter
2c65aa85ae Add debug hack to collect.sh. 2012-02-14 14:03:15 -07:00
Daniel Nichter
1c57fe8ee2 Conditionalize lsof test in collect.sh. 2012-02-14 11:02:28 -07:00
Daniel Nichter
c40e5db1bf Fix lib tests for MySQL 5.0. 2012-02-02 10:56:55 -07:00
Daniel Nichter
be8c0e6e18 Fix parsing opts from config file with leading and trailing space. 2012-01-30 11:15:28 -07:00
Daniel Nichter
e954505dd2 Don't print errors in data files; let the general -output file catch them. Print TS lines before data. Try to find sysctl manually. Add _pidof() to alt_cmds.sh. 2012-01-27 17:37:59 -07:00
Daniel Nichter
6b017da6fe Use new pretty --help. 2012-01-26 12:59:48 -07:00
Daniel Nichter
05ac0be136 Change --disk-byte-limit to --disk-bytes-free and --disk-pct-limit to --disk-pct-free. 2012-01-26 12:45:44 -07:00
Daniel Nichter
d7d5381863 Make check_disk_space() use bytes (given new size type options with are converted to bytes, 1k=>1024). 2012-01-26 12:19:47 -07:00
Daniel Nichter
81caf6addc Convert size \d+[KMGT] opts in parse_options.sh. 2012-01-26 10:44:55 -07:00
Daniel Nichter
c2fd3f54c2 Use "yes" for true, "" for false. Use $PO_DIR instead of $TMP_DIR/po. Add and test Baron's code for 'Options and values after processing arguments'. Make --help exit 0 unless there were errors. 2012-01-24 12:49:18 -07:00
Daniel Nichter
4905e3503c Handle --config FILE[,FILE,...] in parse_options.sh. 2012-01-24 11:18:41 -07:00
Daniel Nichter
034f76d77e Fix handling EXT_ARGV. 2012-01-23 10:53:41 -07:00
Daniel Nichter
0d348ce289 Make parse_options work with everything: cmd line, config files, values with spaces, op val, op=val, etc. 2012-01-23 10:30:42 -07:00
Daniel Nichter
65a3ab5157 Handle values with spaces. Still needs work; one test is failing. 2012-01-21 13:59:02 -07:00
Daniel Nichter
acbc6b4622 Parse config files. Refactor parse_option.sh. Print --help and --version to STDOUT. 2012-01-20 11:34:51 -07:00
Daniel Nichter
51b93a6235 Fix --help description interpolation. 2012-01-19 12:20:33 -07:00
Daniel Nichter
9e29cc205a Make test quiet. 2012-01-19 11:13:01 -07:00
Daniel Nichter
2412e01aa0 Use which to get programs. Don't create file unless the program or file exists. 2012-01-19 10:46:48 -07:00
Daniel Nichter
6e2b670af6 Die if --log, --pid, or --dest aren't accessible. Also die if po dir isn't accessible. 2012-01-17 13:12:08 -07:00
Daniel Nichter
a9afea4506 Quote vals in Bash libs. Add tests for log_warn_die.sh and alt_cmds.sh. Make --help test path independent. 2012-01-11 11:31:41 -07:00