Commit Graph

358 Commits

Author SHA1 Message Date
Sveta Smirnova 696349393c PT-2302 - pt-k8s-debug-collector cannot pass properly to pt-mysql-summary PXC root password with special characters
- typo in error message
2024-04-22 15:57:11 +03:00
Sveta Smirnova 86c3abbc15 PT-2302 - pt-k8s-debug-collector cannot pass properly to pt-mysql-summary PXC root password with special characters
- Merge branch '3.x' into PT-2302_pt-k8s-debug-collector_cannot_pass_properly_to_pt-mysql-summary_PXC_root_password_with_special_characters
- Implement fix for MongoDB
2024-04-19 16:38:24 +03:00
Artem Gavrilov 95c9020fa9 Fix typo (#801) 2024-04-18 11:48:37 +02:00
Sveta Smirnova ba08b2edf3 PT-2217 - pt-mongodb-summary gives error with psmdb6.0
- Removed not supported request for recordStats
- Adjusted docker-compose.yml, so it fires standalone server correctly
2024-04-11 18:58:39 +03:00
Sveta Smirnova e215f57c3e PT-2302 - pt-k8s-debug-collector cannot pass properly to pt-mysql-summary PXC root password with special characters
- Implemented fix in pt-k8s-debug-collector
2024-04-10 00:32:08 +03:00
Yoann La Cancellera 8acb578e80 pt-galera-log-explainer: fixed nitpicks from review 2024-03-22 15:24:03 +01:00
Yoann La Cancellera 9dbed00bee pt-galera-log-explainer: fixed nitpicks from review 2024-03-21 19:52:25 +01:00
Yoann La Cancellera 4f44d1a504 pt-galera-log-explainer: removed whois deadcode 2024-03-18 18:20:43 +01:00
Yoann La Cancellera 4e0f32acb6 pt-galera-log-explainer: typo 2024-03-18 18:20:43 +01:00
Yoann La Cancellera 421cadb1a8 pt-galera-log-explainer: add whois tree output 2024-03-18 18:20:41 +01:00
Yoann La Cancellera 6636265ef2 pt-galera-log-explainer: fixes: operator identity, keeping oldest
translations, avoiding unspecified names loops for whois command

Those bugs were not breaking behavior, but they were causing variations
of results. It would not always store the same timestamps, sometimes breaking
tests
Most of the random come from regex map iteration
2024-03-18 18:19:52 +01:00
Yoann La Cancellera 417a4ab9f4 pt-galera-log-explainer: whois regression tests 2024-03-18 18:19:45 +01:00
Yoann La Cancellera afe36e129b pt-galera-log-explainer: add whois command 2024-03-18 18:19:00 +01:00
Yoann La Cancellera bebd652600 pt-galera-log-explainer: add custom regexes parameter
That way anybody can handle non-galera specific logs in a single view

tests/expected/operator_auto_ambiguous_ips_list_all_no_color has been
updated, it was out-of-sync due to 2 previous pull requests that were
made in parallel
2024-02-19 20:15:39 +01:00
Sveta Smirnova 37d792f299 Merge pull request #764 from jobinau/3.x
All complexities and failure senarios are removed, No more dependancies
2024-02-17 20:35:20 +03:00
Yoann La Cancellera 1462c4e4af Merge pull request #765 from ylacancellera/pt-galera-log-explainer
pt-galera-log-explainer: improvments from feedbacks
2024-02-14 17:56:07 +01:00
Yoann La Cancellera 4b27054770 pt-galera-log-explainer: removing redundant loop names 2024-02-14 17:54:33 +01:00
Sveta Smirnova 4d9a406dcb PR-765 - pt-galera-log-explainer: improvments from feedbacks
- Fixed formatting in the documentation
- Synced documentation and README.rst
2024-02-13 20:40:23 +03:00
Sveta Smirnova 91209b5837 PT-2233 - pt-k8s-debug-collector needs psql in the host node
- Adjusted test TestPT_2169, because it does not depend on port for
  --resource=pg anymore
2024-02-13 19:42:18 +03:00
Yoann La Cancellera 3a5bde7c36 pt-galera-log-explainer: refactor operator detection 2024-02-09 12:12:29 +01:00
Yoann La Cancellera dbf329ee23 pt-galera-log-explainer: add --skip-operator-detection 2024-02-09 12:12:29 +01:00
Yoann La Cancellera 2e1acd587e pt-galera-log-explainer: fix debug log formatting mismatch
"extrator" log was not using the same output format as the rest
beacuse it was initialized before main()
2024-02-09 12:12:29 +01:00
Yoann La Cancellera d1459ce0bc pt-galera-log-explainer: Add pxc operator auto detection 2024-02-09 12:12:27 +01:00
Yoann La Cancellera b15cdf2d68 Add: operators identified by podname, can merge
Merge happen when podname, deployment name and namespace match
2024-02-09 12:06:35 +01:00
Jobin Augustine 7400afe174 Additonally accomodated the review comments on PR : https://github.com/percona/percona-toolkit/pull/764, further simplified the code to remove the extra CASE switch 2024-02-08 11:51:39 +05:30
Jobin Augustine a10ffbc3df All complexities and failure senarios are removed, No more dependancy on psql outside the pod, No dependancy on password authentication or portforwaring. 2024-02-07 23:44:34 +05:30
Yoann La Cancellera 51ce07ce22 Merge pull request #750 from ylacancellera/PT-2298_pt-galera-log-explainer_superfluous_lines_on_conflicts
PT-2298 pt-galera-log-explainer superfluous lines on conflicts
2024-01-26 12:36:24 +01:00
Yoann La Cancellera 3bdc4b95ba pt-galera-log-explainer: refactor conflict response 2024-01-26 12:25:45 +01:00
Yoann La Cancellera 8d3cab91d4 pt-galera-log-explainer: add --skip-merge, grep -a
--skip-merge can help for cases where merge won't work: node names
intentionally identical
grep -a enables to read logs even though they use binary format
2024-01-23 09:44:14 +01:00
Yoann La Cancellera 7dfcbc1ec5 PT-2307 include last inactive check mesages on pt-galera-log-explainer 2024-01-18 11:27:48 +01:00
Yoann La Cancellera 97cc3ebb01 PT-2298 pt-galera-log-explainer superfluous lines on conflicts 2024-01-08 18:37:57 +01:00
Sveta Smirnova a5bcc86040 Added hook for help output for new option in src/go/Makefile: build 2023-12-22 23:11:31 +03:00
Sveta Smirnova 99885fdbd5 Merge branch '3.x' into galera-log-explainer 2023-12-22 23:11:12 +03:00
Yoann La Cancellera fd95589c96 preallocate lastcontexts map 2023-12-22 23:10:34 +03:00
Yoann La Cancellera 90ae30517a Move: chan closing in "main" func 2023-12-22 23:10:34 +03:00
Yoann La Cancellera 955fd75ca9 Rename ctx to logCtx, remove any mention of ctx 2023-12-22 23:10:34 +03:00
Yoann La Cancellera bb6c5e1abd Fix: missed errors, minor formatting issues 2023-12-22 23:10:34 +03:00
Yoann La Cancellera 2a97f061db Imp: use strings.builder for conflicts 2023-12-22 23:10:34 +03:00
Yoann La Cancellera d6d4d30283 Add: parallel on 2 unit tests 2023-12-22 23:10:34 +03:00
Yoann La Cancellera aac8896e2f Update src/go/pt-galera-log-explainer/README.rst
Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
2023-12-22 23:10:34 +03:00
Yoann La Cancellera 98b7a7d52a Fix: README with -vvv, --grep-args, regex-list 2023-12-22 23:10:34 +03:00
Yoann La Cancellera 5d93fbbcc0 PR-669 - Add pt-galera-log-explainer percona#669
- Commented out whois command in README.rst
- Copied README.rst into docs directory, so user manual will include
  this tool
2023-12-22 23:10:34 +03:00
Yoann La Cancellera 27654e9853 Remove: --grep-args
Can be used to break the tool, and I actually never had an use-case
2023-12-22 23:10:34 +03:00
Yoann La Cancellera 3fae43123e Fix: typos 2023-12-22 23:10:34 +03:00
Yoann La Cancellera 7876a0511c Remove old comments, dead code 2023-12-22 23:10:34 +03:00
Yoann La Cancellera ad91b7d407 Add: translate tests 2023-12-22 23:10:34 +03:00
Yoann La Cancellera 78aebd272d Commenting out whois+sed, will be re-added later 2023-12-22 23:10:34 +03:00
Yoann La Cancellera 2091c1a1f0 Refactoring: migrate translations to singleton
It was using maps in each context, which would be merged between
contexts, then injected each time we needed a message to display.

It had a limitation on complicated operator setups: historical
information would be overriden by newer associations.
(e.g, that IP was for node0 yesterday, now it's node1, so associations
have been overwritten and incorrect)

It also introduced complexity, such as forcing to define closures too
many times, merging maps, it would be harder to debug, and every files
were starting from empty translation maps.
Moreover, iterating on maps is guaranteed to be random so it could create
hard-to-debug output variations on complex cases.

Now it is a singleton in translate package, still using maps but now it
associates an array of "units" storing the timestamp with each piece of information.
It is protected by rwmutex, because map are not threadsafe. (there's no
parallel processing for now)

No regressions, and it passes "operator_ambiguous_ips_list_all_no_color"
where the old system failed.
It nows also can be used as an easy to read source of information in
itself
2023-12-22 23:10:32 +03:00
Yoann La Cancellera e56fc45a05 Add: inconsistent vote regex corner-case 2023-12-22 23:10:08 +03:00
Yoann La Cancellera 246f875ed9 Add: shortuuid check, new date layout found 2023-12-22 23:10:08 +03:00