Brian Fraser fraserb@gmail.com
3b1f3dbbe5
Fix for 977226: pt-summary doesn't detect LSI RAID control. Patch provided by Dave Juntgen (djuntgen)
2012-07-30 12:36:55 -03:00
Daniel Nichter
487d14228b
Handle --nofoo like --no-foo in parse_options.sh and update the Bash tools.
2012-07-21 11:57:53 -06:00
Daniel Nichter
e1b39b3d5f
Use TRUE/FALSE for typeless option values in --help. Update parse_options.sh lib in Bash tools.
2012-07-21 11:40:39 -06:00
Brian Fraser fraserb@gmail.com
bc8f5a610c
Change TMPDIR to PT_TMPDIR
2012-06-11 17:51:43 -03:00
Daniel Nichter
bf2a769536
Export TMPDIR to make tmpdir.t pass.
2012-06-11 13:28:14 -07:00
Brian Fraser fraserb@gmail.com
07081d5761
tmpdir.sh: Use the -t flag for mktemp
2012-06-11 17:07:38 -03:00
Brian Fraser fraserb@gmail.com
865b3e4e9d
collect_system_info shouldn't assume that sysctl is available.
...
It isn't on CentOS 5.5. It didn't really assume that it
was always there, but rather than the produced samples file
would be.
2012-06-04 11:57:44 -03:00
Baron Schwartz
48f642551e
fix some problems that happen when there are many mysqld instances
2012-06-03 20:53:57 -04:00
Daniel Nichter
696a3b5e68
Fix mem/file size shortening in pt-summary and pt-mysql-summary.
2012-06-03 14:49:35 -07:00
Daniel Nichter
d46285342a
Use 6 X with mktemp to make it work on some platforms and update all tools.
2012-05-16 11:38:48 -06:00
Daniel Nichter
cc80f278d5
Code comment why MiB, GiB, etc. are used in shorten() and update that func in pt-summary and pt-mysql-summary.
2012-05-07 16:38:30 -06:00
Daniel Nichter
fdfd305dc5
Simplify and fix report_formatting::shorten(), and add Petabyte unit (in case it's needed). Update affected test samples. Add T_DIR to util/test-bash-functions.
2012-05-07 12:16:24 -06:00
Daniel Nichter
0286631514
Merge summary-tools-2.1.
2012-04-03 10:14:55 -06:00
Brian Fraser fraserb@gmail.com
a01de98434
Fix for a bug in 32-bit Debian.
...
Namely, awk's printf("%d") doing what it's supposed to do, cast
it's operand to (int), which screws up large numbers.
The fix is simple, although it mostly just pushes the problem
under the rug; using %.0f instead of %d.
2012-04-03 12:50:12 -03:00
Brian Fraser fraserb@gmail.com
b807088b8e
Other instances of the substr(var, 0, n) bug
2012-04-03 11:29:36 -03:00
Brian Fraser fraserb@gmail.com
cfcef354b0
section(): Less printf, more awk
2012-04-03 11:07:30 -03:00
Brian Fraser fraserb@gmail.com
12bd26022a
Fix a section() bug.
...
Turns out that awk's indexes are documented to start from 1;
So what happens if you use 0? Apparently it's undefined behavior, so
substr(var, 0, 5);
and
substr(var, 1, 5);
May or may not actually do the same thing. In Debian 6, the former
doesn't quite work, and actually returns something like substr(var, 1, 4),
which broke section()'s output.
2012-04-03 10:55:51 -03:00
Brian Fraser fraserb@gmail.com
c0dedd19bf
- section() revamp
...
- Redirect STDERR for the collection part in both tools
- rm_tempdir in sigtrap
- A part of pt-mysql-summary still depended on the system being run,
rather than the samples being read. Now it works properly.
2012-04-02 19:25:17 -03:00
Brian Fraser fraserb@gmail.com
6dbbd6de3b
The previous merge went a bit wrong, and left the libraries unsynced with the tools; This commit fixes it.
2012-04-02 13:36:17 -03:00
Brian Fraser fraserb@gmail.com
761f8a5aac
Merge more of Baron's changes, also re-implement the MySQL Executables section
...
Plus other bugfixes.
2012-03-30 23:00:57 -03:00
Brian Fraser fraserb@gmail.com
978b236985
Save the config file itself, not just its path.
2012-03-30 20:18:39 -03:00
baron
06dc18ec46
clean up a couple of things causing tests to fail for me, and remove a feature that's not quite ready yet, and add another feature for innodb compression
2012-03-30 17:07:05 -04:00
baron
d44e8b539b
clean up a couple of things causing tests to fail for me, and remove a feature that's not quite ready yet, and add another feature for innodb compression
2012-03-30 17:04:25 -04:00
Brian Fraser fraserb@gmail.com
562a550a39
Fixes
2012-03-30 17:23:55 -03:00
Daniel Nichter
94d9483d03
Make vmstat, iostat, and mpstat run for --run-time not --interval.
2012-03-30 11:35:32 -06:00
Brian Fraser fraserb@gmail.com
33a4096663
Fix CPU_ARCH collection for Linux
2012-03-30 13:44:21 -03:00
Brian Fraser fraserb@gmail.com
f8113b4676
A parse_ethtools() that actually works
2012-03-29 19:44:51 -03:00
Brian Fraser fraserb@gmail.com
996a76a68e
pt-summary shouldn't leave empty files; both summary tools should
...
die if passed a --save-samples directory that has files in it.
2012-03-29 19:21:32 -03:00
Brian Fraser fraserb@gmail.com
3ee8f9ba71
Fixed the Table Cache bugs.
...
Also makes t/lib/bash/collect_system_info.sh actually call setup_commands.
2012-03-28 15:29:57 -03:00
Brian Fraser fraserb@gmail.com
4bb5968c23
More fixes as per the reviews.
...
- Took out ${prefix}-
- get_var sanity
- pt-mysql-summary now follows pt-summary's suit and doesn't take
in files to write to
- pt-summary defers setting the CMD_FOO vars to a function, as
otherwise it would skip our PATH mungling.
2012-03-28 13:04:14 -03:00
Brian Fraser fraserb@gmail.com
ae6c1e3789
More fixes:
...
- pt-mysql-summary's --read-samples shouldn't need an active connection
- Bunch of pt-summary bugs, particularly several relating to disks.
2012-03-27 12:53:31 -03:00
Brian Fraser fraserb@gmail.com
0e4fa22d18
*-summary tools: Changes from the reviews. Tests for pt-mysql-summary not finished yet
2012-03-27 06:19:37 -03:00
Brian Fraser fraserb@gmail.com
3ffda5677b
pt-summary for 2.1, also changes to pt-mysql-summary from Daniel's review
2012-03-24 14:20:09 -03:00
Brian Fraser fraserb@gmail.com
88a9a66946
pt-mysql-summary for 2.1
2012-03-20 18:29:35 -03:00
Brian Fraser fraserb@gmail.com
55c7248c54
(more syncing)
2012-03-20 17:16:06 -03:00
Brian Fraser fraserb@gmail.com
31afeb73b5
(temp commit, syncing up)
2012-03-20 11:21:16 -03:00
Daniel Nichter
6e94c39072
Use Perl instead of awk to avoid 32-bit limitation.
2012-02-24 11:11:07 -07:00
Daniel Nichter
0ac6c35211
Fix _pidof() calls in collect.sh. Update Bash libs in pt-ioprofile.
2012-02-03 10:49:27 -07:00
Daniel Nichter
9c6b9ab33d
Use printf(%d) to avoid CentOS using floats.
2012-02-02 12:13:00 -07:00
Daniel Nichter
7be99c5140
Add _which() to alt_cmds.sh and update pt-stalk.
2012-02-02 12:04:28 -07:00
Daniel Nichter
c40e5db1bf
Fix lib tests for MySQL 5.0.
2012-02-02 10:56:55 -07:00
Daniel Nichter
cd91b583c1
Removed unused global vars.
2012-02-01 10:03:37 -07:00
Daniel Nichter
6205505263
Don't use basename and quote $dir in tmpdir.sh.
2012-01-31 10:20:37 -07:00
Daniel Nichter
be8c0e6e18
Fix parsing opts from config file with leading and trailing space.
2012-01-30 11:15:28 -07:00
Daniel Nichter
89242d9fde
Don't init a global with a global.
2012-01-30 10:20:31 -07:00
Daniel Nichter
8389da4c07
Use . instead of source. Quote func file. Verify --function. Add option_error() to parse_options.sh. Update libs in pt-stalk.
2012-01-30 09:22:25 -07:00
Daniel Nichter
d1a684b55b
Use _pidof() and _lsof() from Percona Monitoring Plugins. Use "" and "yes" exclusively in collect(). Don't exec cmds that need mysqld_pid unless mysqld_pid is defined. Use log() instead of echo.
2012-01-30 08:59:19 -07:00
Daniel Nichter
e954505dd2
Don't print errors in data files; let the general -output file catch them. Print TS lines before data. Try to find sysctl manually. Add _pidof() to alt_cmds.sh.
2012-01-27 17:37:59 -07:00
Daniel Nichter
81ae556f8b
Use local IFS.
2012-01-26 13:04:23 -07:00
Daniel Nichter
6b017da6fe
Use new pretty --help.
2012-01-26 12:59:48 -07:00
