Commit Graph

936 Commits

Author SHA1 Message Date
Brian Fraser
a3527f748c Fixed the Smooth Flushing report on 5.1, which was broken by the previous commit, and made it work on 5.5 2012-11-30 18:17:30 -03:00
Brian Fraser
76a010abee Fix for 917770: Use of uninitialized value in substitution (s///) at pt-config-diff line 1996
This turned out to be two bugs mangled into one.

First, _parse_varvals can deal with (var, undef), but not with (undef).
This is a problem because two of the trhee spots that call
_parse_varvals can return undef because of this:

      map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ }
      grep { $_ !~ m/^\s*#/ }  # no # comment lines
      split("\n", $mysqld_section)

The problem is twofold. First, we are not skipping empty or
whitespace-only lines. That means that the map will fail,
and pass an undef to _parse_varvals. So this ended up in
a triple fix: Make _parse_varvals deal with a sole undef,
skip empty/whitespace lines, and change that map to

	map  { $_ =~ m/^([^=]+)(?:=(.*))?$/ ? ($1, $2) : () }

so even if the regex fails in the future, no sole undef
will be passed down the chain.
2012-11-30 16:17:45 -03:00
Daniel Nichter
72a129bce1 Add is_cluster_mode() to lib/Sandbox.pm. 2012-11-30 18:13:04 +00:00
Brian Fraser
ee41d4deb4 Introduce feat_on_renamed, a wrapper around feat_on for renamed variables 2012-11-29 22:32:22 -03:00
Daniel Nichter
065e0a8c5e Merge 2.1 at r473. 2012-11-30 00:23:42 +00:00
Daniel Nichter
90a91cd384 Merge pt-osc-pxc-tests. 2012-11-29 17:10:51 -07:00
Daniel Nichter
8549fe5d99 Test and require wsrep_OSU_method=TOI. 2012-11-29 23:26:53 +00:00
Brian Fraser
98707e937c pt-mysql-summary: Feedback from Fred & Jay; Display wsrep_slave_threads, and also parse & display pc.ignore_sb, pc.ignore_quorum, gcache.size, gcache.dir, gcache.name, all from wsrep_provider_options 2012-11-29 19:38:50 -03:00
Brian Fraser
ff3d496cf0 pt-mysql-summary: Make sure the Status Counters don't use scientific notation 2012-11-29 18:08:59 -03:00
Brian Fraser
cddead8a69 Merged fix-831525-pqd-mangled-help 2012-11-29 17:10:54 -03:00
Brian Fraser
713457226a Merged fix-887638-ptqa-negative-at-byte 2012-11-29 17:09:33 -03:00
Brian Fraser
d496fbcf11 Tests for pt-archiver + PXC 2012-11-29 07:29:24 -03:00
Brian Fraser fraserb@gmail.com
d47b9f1f95 pt-mysql-summary: Start reporting some PXC info 2012-11-27 19:05:45 -03:00
Brian Fraser fraserb@gmail.com
f915e54a17 pt-mysql-summary: Make the "Executables" section work 2012-11-27 18:28:07 -03:00
Brian Fraser fraserb@gmail.com
bb75e6a6b7 pt-mysql-summary: Make the "Instances" section work if the instances were started with --defaults-file 2012-11-27 18:19:47 -03:00
Brian Fraser fraserb@gmail.com
84043cee75 parse_options.sh: Make sure that --help works under sh 2012-11-27 18:05:53 -03:00
Daniel Nichter
ea1c6f6ca9 Add lock_in_share_mode option to NibbleIterator. Silence query_table.pl diag messages. 2012-11-27 17:41:05 +00:00
Brian Fraser fraserb@gmail.com
79a5c39cec WIP Autodetect nodes & recurse to find new slaves 2012-11-25 18:51:06 -03:00
Brian Fraser
41d7700aa5 WIP ptc: Autodetect cluster nodes & recurse to slaves 2012-11-23 19:00:38 -03:00
Brian Fraser fraserb@gmail.com
7ae20036cb PXC: Implement find_cluster_nodes and remove_duplicate_cxns 2012-11-23 12:50:25 -03:00
Brian Fraser
b1e0aac38f Fixed various failing tests 2012-11-21 17:04:42 -03:00
Daniel Nichter
92e1242d00 Update Percona::Toolkit::VERSION and Changelog. 2012-11-19 18:41:34 +00:00
Daniel Nichter
5278451292 Don't suppress STDOUT in Sandbox.pm subs so die may have something to say. 2012-11-19 11:23:23 -07:00
Daniel Nichter
e0f0ea0cdb Rewrite and enhance lib/Percona/XtraDB/Cluster.pm and t/pt-table-checksum/pxc.t. Change how ptc handles various cluster issues. Change lib/Sandbox.pm subs like start_sandbox() and start_cluster(). PXC docs in ptc are a work in progress. 2012-11-18 22:05:30 -07:00
Daniel Nichter
e47a84daba Add _d() to Percona/XtraDB/Cluster.pm. 2012-11-17 12:28:47 -07:00
Brian Fraser
270a4710fb Removed a useless part of the regex that looked for something function-like, and made the NULL check case-insensitive 2012-11-16 12:04:14 -03:00
Brian Fraser
55a17166c6 Merged fix-1041391-rowchecker-wrong-debug-statement 2012-11-16 11:36:59 -03:00
Brian Fraser
06115737ee Fix for 887638: pt-query-digest prints negative byte offset 2012-11-15 15:17:03 -03:00
Daniel Nichter
9b105ee2d2 Make GeneralLogParser.pm understand the "as" part of a Connect command. 2012-11-14 11:38:55 -07:00
Brian Fraser
c811d60ae1 Pushed the lib/Percona/Toolkit.pm version, and added extra tests to t/lib/Percona/Toolkit.t 2012-11-13 12:10:25 -03:00
Brian Fraser fraserb@gmail.com
22ec559b38 Fix for 986847: Allow setting which commands (and extra options) pt-stalk uses through env vars 2012-11-12 11:26:01 -03:00
Brian Fraser
57740c4101 Missing /g in a Quoter regex 2012-11-10 09:54:39 -03:00
Brian Fraser
b3dd48af15 Change the behavior to resume+ignore-databases to mimic resume+ignore-tables; now it starts from the next table. 2012-11-09 22:07:10 -03:00
Brian Fraser
cafb2b3fb5 Merged fix-1062563-1063912-ptc-pxc-bugs 2012-11-09 18:41:32 -03:00
Brian Fraser
511a402911 Merged fix-1047335-crashed-tables 2012-11-09 13:48:17 -03:00
Brian Fraser
d827c7228d Merged OptionParser-remove-optional_value & updated modules 2012-11-09 13:31:13 -03:00
Daniel Nichter
da50daf0f7 Merge pt-osc-data-loss-bug-1068562 2012-11-08 16:38:07 -07:00
Brian Fraser
7beb0b518e Reverted a few unnecessary changes 2012-11-08 17:47:00 -03:00
Brian Fraser
42a9cf4b6e Merged fix-1062563-1063912-ptc-pxc-bugs and resolved conflicts, added the missing Percona::XtraDB::Cluster file 2012-11-08 17:38:04 -03:00
Brian Fraser
426d599566 Fix for 911385: pt-table-checksum v2 fails when --resume + --ignore-database is used 2012-11-08 13:42:29 -03:00
Brian Fraser
5e838050b6 Fix for 831525: pt-query-digest help output mangled 2012-11-08 13:38:09 -03:00
Brian Fraser
57b3706f1a Fixed a bug in Quoter->split_unquote, added several tests for find_renamed_cols 2012-11-08 06:13:43 -03:00
Brian Fraser
4d9805a004 Fixed a bug in full_output 2012-11-08 06:12:29 -03:00
Brian Fraser
bb47e4cdcc Removed the L option from the dsn_opts exported by PerconaTest, as it was useless and breaking tests, and added an L=1 to a leftover pt-archiver --bulk-insert call 2012-11-07 08:54:39 -03:00
Brian Fraser
86de49e727 Merged sandbox-get_dbh_for-fix 2012-11-07 04:13:50 -03:00
Brian Fraser
58b32bb5ef Merged fix-1073532-Mo-Scalar-Util-PP 2012-11-07 04:12:37 -03:00
Brian Fraser
aa79c9df57 Moved the PXC-dealing parts of Cxn.pm into Percona::XtraDB::Cluster 2012-11-07 04:06:50 -03:00
Daniel Nichter
e8cfb37341 Move ptc PXC tests from bugs.t to pxc.t. Remove 2>&1 from Sandbox.pm shell-outs: we should let errors go to stderr so we can trap them. Fix skip count in Cxn.t for PXC tests. 2012-11-06 16:10:01 -07:00
Brian Fraser
d3c7a059e7 Fixes per Daniel's review 2012-11-06 11:35:49 -03:00
Daniel Nichter
ddda26fb7f Merged fix-i26211-1058285-821722-implicit-ansi_quotes 2012-11-05 10:57:11 -07:00