Commit Graph

2988 Commits

Author SHA1 Message Date
Brian Fraser
73c1e466d7 Several fixes & changes:
* qtime and stime computed correctly
* Interactive mode and changing groups doesn't fail
* Interactive mode no longer uses a file to gather samples.
2012-01-30 17:44:18 -03:00
Daniel Nichter
be8c0e6e18 Fix parsing opts from config file with leading and trailing space. 2012-01-30 11:15:28 -07:00
Daniel Nichter
89242d9fde Don't init a global with a global. 2012-01-30 10:20:31 -07:00
Daniel Nichter
caa91f39fa Log collector PID. 2012-01-30 10:05:35 -07:00
Daniel Nichter
ae558c6442 Merge lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0-docs r157. 2012-01-30 09:29:39 -07:00
Daniel Nichter
8389da4c07 Use . instead of source. Quote func file. Verify --function. Add option_error() to parse_options.sh. Update libs in pt-stalk. 2012-01-30 09:22:25 -07:00
Daniel Nichter
d1a684b55b Use _pidof() and _lsof() from Percona Monitoring Plugins. Use "" and "yes" exclusively in collect(). Don't exec cmds that need mysqld_pid unless mysqld_pid is defined. Use log() instead of echo. 2012-01-30 08:59:19 -07:00
Daniel Nichter
e954505dd2 Don't print errors in data files; let the general -output file catch them. Print TS lines before data. Try to find sysctl manually. Add _pidof() to alt_cmds.sh. 2012-01-27 17:37:59 -07:00
baron@percona.com
950a386a72 small docs tweaks 2012-01-26 16:07:02 -05:00
baron@percona.com
244204d7a2 merge changes back from Daniel 2012-01-26 16:05:50 -05:00
Daniel Nichter
81ae556f8b Use local IFS. 2012-01-26 13:04:23 -07:00
Daniel Nichter
6b017da6fe Use new pretty --help. 2012-01-26 12:59:48 -07:00
Daniel Nichter
05ac0be136 Change --disk-byte-limit to --disk-bytes-free and --disk-pct-limit to --disk-pct-free. 2012-01-26 12:45:44 -07:00
Daniel Nichter
d7d5381863 Make check_disk_space() use bytes (given new size type options with are converted to bytes, 1k=>1024). 2012-01-26 12:19:47 -07:00
Daniel Nichter
81caf6addc Convert size \d+[KMGT] opts in parse_options.sh. 2012-01-26 10:44:55 -07:00
baron@percona.com
5acec0d38e initial documentation 2012-01-25 16:11:09 -05:00
Daniel Nichter
dd44a9b851 Add --test-matching to replace testing via STDIN/ARGV. 2012-01-25 11:37:10 -07:00
Daniel Nichter
73bc7cdcf8 Change default --dest to /var/lib/pt-stalk. Don't check --dest unless --collect. Fix POD formatting for --function. 2012-01-24 14:22:19 -07:00
Daniel Nichter
77e5e4c3f2 Simpler test for +w access to --log. 2012-01-24 13:24:07 -07:00
Daniel Nichter
b47679cf97 Implement --[no]collect. 2012-01-24 13:20:07 -07:00
Daniel Nichter
c2fd3f54c2 Use "yes" for true, "" for false. Use $PO_DIR instead of $TMP_DIR/po. Add and test Baron's code for 'Options and values after processing arguments'. Make --help exit 0 unless there were errors. 2012-01-24 12:49:18 -07:00
Daniel Nichter
42a8e39635 Use better Bash. 2012-01-24 12:28:41 -07:00
Daniel Nichter
36c14f492a Don't use grep -q. 2012-01-24 12:15:29 -07:00
Daniel Nichter
c965d7c172 Fix POD syntax error. 2012-01-24 12:07:42 -07:00
Daniel Nichter
fa6a6cb8ff Merge lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0-docs r155. 2012-01-24 12:01:47 -07:00
Daniel Nichter
3c97ae27d1 Add and test --config to pt-stalk. 2012-01-24 11:50:48 -07:00
Daniel Nichter
4905e3503c Handle --config FILE[,FILE,...] in parse_options.sh. 2012-01-24 11:18:41 -07:00
Daniel Nichter
0a81ddeaad Merge lp:~percona-toolkit-dev/percona-toolkit/fix-zombie-bug-919819. 2012-01-24 10:01:06 -07:00
Daniel Nichter
0f1687608d Ignore SIGCHLD to avoid zombies. 2012-01-24 09:55:18 -07:00
Daniel Nichter
cab3bb6eab Update parse_options.sh in pt-stalk. 2012-01-23 10:54:43 -07:00
Daniel Nichter
034f76d77e Fix handling EXT_ARGV. 2012-01-23 10:53:41 -07:00
Daniel Nichter
0d348ce289 Make parse_options work with everything: cmd line, config files, values with spaces, op val, op=val, etc. 2012-01-23 10:30:42 -07:00
Daniel Nichter
65a3ab5157 Handle values with spaces. Still needs work; one test is failing. 2012-01-21 13:59:02 -07:00
baron@percona.com
b13ff30bb7 finish docs 2012-01-21 11:19:50 -05:00
baron@percona.com
63ea85e755 docs 2012-01-21 09:15:45 -05:00
Daniel Nichter
acbc6b4622 Parse config files. Refactor parse_option.sh. Print --help and --version to STDOUT. 2012-01-20 11:34:51 -07:00
Daniel Nichter
f5f388e617 Merge lp:~percona-toolkit-dev/percona-toolkit/fix-bug-915598. 2012-01-19 13:08:05 -07:00
Daniel Nichter
2b9e578908 Fix util/update-modules. Use Cxn in pt-config-diff to make --ask-pass work. 2012-01-19 13:04:42 -07:00
Daniel Nichter
88304e69fb Replace MKDEBUG with PTDEBUG in modules. 2012-01-19 12:46:56 -07:00
Daniel Nichter
51b93a6235 Fix --help description interpolation. 2012-01-19 12:20:33 -07:00
Daniel Nichter
ba4b4f3059 Log how pt-stalk was ran. Update modules in tool. Tweak 'Starting' and 'Exiting' log lines. 2012-01-19 11:51:24 -07:00
Daniel Nichter
9e29cc205a Make test quiet. 2012-01-19 11:13:01 -07:00
Daniel Nichter
2412e01aa0 Use which to get programs. Don't create file unless the program or file exists. 2012-01-19 10:46:48 -07:00
Brian Fraser
ad552756b2 Automatic headers & improvements. 2012-01-18 19:01:19 -03:00
Brian Fraser
5b43ed0d5e More changes as per Baron's review.
Tries to implement a facsimile to http://www.xaprb.com/blog/2011/03/18/how-to-gather-statistics-at-regular-intervals/
For both sampling and rendering.
2012-01-18 05:19:48 -03:00
Daniel Nichter
6e2b670af6 Die if --log, --pid, or --dest aren't accessible. Also die if po dir isn't accessible. 2012-01-17 13:12:08 -07:00
Daniel Nichter
b2bac5c765 Quote in tmpdir.sh and fix typo in doc. 2012-01-17 12:15:49 -07:00
Brian Fraser
3a66cf5187 Removed lib/pt_diskstats.pm, since it's no longer needed. 2012-01-17 11:41:15 -03:00
Brian Fraser
05fec15473 Fixes as per Baron's review. 2012-01-17 11:40:01 -03:00
Brian Fraser
076c0d70b1 (Whoops. Forgot to commit the changed tests) 2012-01-16 09:48:59 -03:00