percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-23 04:25:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,171 Commits 139 Branches 71 Tags
51ce07ce226e818513c20d7109b60926e34f96ea
Commit Graph

5171 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Yoann La Cancellera
78aebd272d Commenting out whois+sed, will be re-added later 2023-12-22 23:10:34 +03:00
Yoann La Cancellera
2091c1a1f0 Refactoring: migrate translations to singleton 
It was using maps in each context, which would be merged between
contexts, then injected each time we needed a message to display.

It had a limitation on complicated operator setups: historical
information would be overriden by newer associations.
(e.g, that IP was for node0 yesterday, now it's node1, so associations
have been overwritten and incorrect)

It also introduced complexity, such as forcing to define closures too
many times, merging maps, it would be harder to debug, and every files
were starting from empty translation maps.
Moreover, iterating on maps is guaranteed to be random so it could create
hard-to-debug output variations on complex cases.

Now it is a singleton in translate package, still using maps but now it
associates an array of "units" storing the timestamp with each piece of information.
It is protected by rwmutex, because map are not threadsafe. (there's no
parallel processing for now)

No regressions, and it passes "operator_ambiguous_ips_list_all_no_color"
where the old system failed.
It nows also can be used as an easy to read source of information in
itself
 2023-12-22 23:10:32 +03:00
Yoann La Cancellera
e56fc45a05 Add: inconsistent vote regex corner-case 2023-12-22 23:10:08 +03:00
Yoann La Cancellera
246f875ed9 Add: shortuuid check, new date layout found 2023-12-22 23:10:08 +03:00
Yoann La Cancellera
a3f3a4d7e5 Add: same ip/name limitation on README.rst 2023-12-22 23:10:08 +03:00
Yoann La Cancellera
72fbe7496c Add: operator member assocations regex 
It existed for non-operator setup, but was not working for operators due
to k8s logs not interpreting newlines and tabs
This operator version re-uses existing regular regex handlers directly
 2023-12-22 23:10:08 +03:00
Yoann La Cancellera
4c8fe1d832 Improve: main_test 
It must test multiple times to remove doubts.
As the tool is reading files and relying on maps, their access order are
random. It can impact some translations
 2023-12-22 23:10:08 +03:00
Yoann La Cancellera
bd8f1ff5a4 Remove: propagation of ip propagation to older hash, Add: operator regression test 
When adding "ownip", it was also propagating the new IP to the old hash.
But with operators, when IP where changing hash will also change, so
linking the new IP to old hash is anachronic. It is not wrong, but
depending on the order of map merges, the newest information could have
been overriden depending on the order of events.

That situation was producing X(2*number of conflicts) versions of output for operators, with
different md5sum, which could produce false-positive regression tests

So currently some information are not linked anymore, so some IPs are
not translated even though they could, but it is a limitation of using
maps as source of truth, as they are not versioned
 2023-12-22 23:10:03 +03:00
Sveta Smirnova
ae67adbe92 Merge pull request #717 from percona/PT-2281_provide_container_name_for_copying_files_in_the_dump 
PT-2281 - provide container name for copying files in the dump
 2023-11-30 19:44:26 +03:00
Sveta Smirnova
10b70206fb Merge branch '3.x' into PT-2281_provide_container_name_for_copying_files_in_the_dump 2023-11-30 19:37:36 +03:00
Sveta Smirnova
5b55513485 Merge pull request #724 from surbhat1595/update3.x 
Fix Trivy Scan Failure - update libraries
 2023-11-30 19:35:22 +03:00
Surabhi Bhat
375b67ddf3 Fix Trivy Scan Failure - update libraries 2023-11-30 17:10:55 +05:30
Artem Gavrilov
9272c9028c Merge pull request #713 from szepeviktor/patch-1 
Fix MongoDB StorageEngine
 2023-11-29 18:25:12 +02:00
Artem Gavrilov
ebb940f1af Merge pull request #714 from szepeviktor/patch-2 
Fix MongoDB Security
 2023-11-29 18:24:03 +02:00
Alina Derkach
a49d87d12f PT-2291 Release notes for Percona Toolkit version 3.5.6 
modified:   Changelog
	modified:   Makefile.PL
	modified:   config/sphinx-build/conf.py
	modified:   docs/release_notes.rst
 2023-11-29 17:18:59 +02:00
Sveta Smirnova
fe12a19e04 Merge pull request #720 from samiahlroos/3.x 
build Go tools from top Makefile
 2023-11-29 14:29:28 +03:00
Sveta Smirnova
43ae487f40 PT-2281 - provide container name for copying files in the dump 
- Implemented error handling when container name is not specified
- Added test case for error handling
 2023-11-29 05:06:27 +03:00
Jason
b2b6311723 PT-2277 - fix pt-visual-explain for 'Impossible ON condition' case 2023-11-29 02:30:44 +08:00
Sami Ahlroos
5e1dfaf218 build Go tools from top Makefile 2023-11-28 14:29:58 +02:00
Sveta Smirnova
0d10bc96b8 Merge pull request #719 from percona/Make_OrderedBy_not_exported_fix 
Make OrderedBy not exported
 2023-11-23 22:15:34 +03:00
Sveta Smirnova
f3bd08ad0d Make OrderedBy not exported 
- Updated orderedBy call
 2023-11-23 22:14:35 +03:00
Sveta Smirnova
a2a15da674 Merge pull request #718 from percona/dependabot/go_modules/k8s.io/api-0.28.4 
Bump k8s.io/api from 0.28.3 to 0.28.4
 2023-11-23 22:11:42 +03:00
Sveta Smirnova
db5289138f Merge pull request #715 from szepeviktor/patch-3 
Fix variable collision with imported package name
 2023-11-22 21:31:43 +03:00
Sveta Smirnova
2ec78b3de4 Merge pull request #716 from szepeviktor/patch-4 
Make OrderedBy not exported
 2023-11-22 01:28:03 +03:00
Sveta Smirnova
2ecafae8e3 Merge pull request #712 from percona/ARM64_support_in_Go_Makefile 
ARM64 support for macOS
 2023-11-21 15:32:55 +03:00
Viktor Szépe
81882b67cc fix 2023-11-21 02:41:26 +00:00
dependabot[bot]
fef6fa4022 Bump k8s.io/api from 0.28.3 to 0.28.4 
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.28.3 to 0.28.4.
- [Commits](https://github.com/kubernetes/api/compare/v0.28.3...v0.28.4)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-11-20 09:18:12 +00:00
Viktor Szépe
c6b6a4086d Update src/go/lib/config/config_test.go 
Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
 2023-11-19 22:13:53 +01:00
Viktor Szépe
ed7f4b3e39 Update src/go/lib/config/config_test.go 
Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
 2023-11-19 22:13:47 +01:00
Viktor Szépe
61021d9ce6 Update src/go/lib/config/config_test.go 
Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
 2023-11-19 22:13:42 +01:00
Viktor Szépe
629ded3960 Make OrderedBy's return type exported 2023-11-17 20:47:54 +01:00
Viktor Szépe
1c5048546a Fix variable collision with imported package name 2023-11-17 20:38:08 +01:00
Viktor Szépe
2ea8f4036c Fix MongoDB Security 2023-11-17 20:34:35 +01:00
Viktor Szépe
65358b715f Fix MongoDB StorageEngine 2023-11-17 20:32:07 +01:00
Sveta Smirnova
b862945245 PT-2281 - provide container name for copying files in the dump 
- Changed getIndividualFiles function and Dumper data structure, so we
  can specify container name for PXC and other operators which store
  logs in the separate container.
 2023-11-14 16:55:56 +03:00
Artem Gavrilov
8b5fbb3f68 Merge pull request #711 from percona/dependabot/github_actions/aquasecurity/trivy-action-0.14.0 
Bump aquasecurity/trivy-action from 0.13.1 to 0.14.0
 2023-11-13 17:51:22 +02:00
Artem Gavrilov
309ba5198f Merge pull request #710 from percona/dependabot/go_modules/go.mongodb.org/mongo-driver-1.13.0 
Bump go.mongodb.org/mongo-driver from 1.12.1 to 1.13.0
 2023-11-13 17:50:52 +02:00
dependabot[bot]
6897a86cea Bump go.mongodb.org/mongo-driver from 1.12.1 to 1.13.0 
Bumps [go.mongodb.org/mongo-driver](https://github.com/mongodb/mongo-go-driver) from 1.12.1 to 1.13.0.
- [Release notes](https://github.com/mongodb/mongo-go-driver/releases)
- [Commits](https://github.com/mongodb/mongo-go-driver/compare/v1.12.1...v1.13.0)

---
updated-dependencies:
- dependency-name: go.mongodb.org/mongo-driver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-11-13 15:48:18 +00:00
Artem Gavrilov
27d91975bf Merge pull request #709 from percona/dependabot/go_modules/golang.org/x/crypto-0.15.0 
Bump golang.org/x/crypto from 0.14.0 to 0.15.0
 2023-11-13 17:47:35 +02:00
Sveta Smirnova
f9c43e9bae ARM64 support for macOS 
- Added option darwin-arm64 into Go tools Makefile
- Changed --delimiter option to its short version that works on all
  platforms
- Changed "Mongo tools" comments to "Go tools", because now Go tools are
  not only for Mongo
 2023-11-13 17:40:58 +03:00
dependabot[bot]
5391c75878 Bump aquasecurity/trivy-action from 0.13.1 to 0.14.0 
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.13.1 to 0.14.0.
- [Release notes](https://github.com/aquasecurity/trivy-action/releases)
- [Commits](https://github.com/aquasecurity/trivy-action/compare/0.13.1...0.14.0)

---
updated-dependencies:
- dependency-name: aquasecurity/trivy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-11-13 09:27:14 +00:00
dependabot[bot]
be2d60618b Bump golang.org/x/crypto from 0.14.0 to 0.15.0 
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.15.0.
- [Commits](https://github.com/golang/crypto/compare/v0.14.0...v0.15.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-11-13 09:12:39 +00:00
Sveta Smirnova
9f5fc7e50a Merge pull request #388 from cswingler/check_undefined_skip_check_slave_lag_schema_change 
Check undefined skip check slave lag schema change

Contirbutor signed corporate SLA as stated in https://github.com/percona/percona-toolkit/pull/230#issuecomment-308564024
 2023-11-12 23:31:30 +03:00
Sveta Smirnova
be2310f2b3 Merge pull request #471 from perfectayush/support-query-explain-in-json-output 
Support adding explain output for slow query in JSON report as well
 2023-11-12 23:28:49 +03:00
Sveta Smirnova
00149ab10a Merge pull request #516 from ikruglov/PT-1860-pt-osc-case-insensitive 
PT-1860 make pt-osc respect case insesitive lookup on Windows and osx
 2023-11-12 23:28:35 +03:00
Sveta Smirnova
2b440638c4 Merge pull request #604 from mikrobi/patch-1 
Only rollback destination if it's defined
 2023-11-12 23:28:13 +03:00
Sveta Smirnova
cfb1065278 Merge pull request #628 from baotiao/PT-2211_ptpmp_return_error_line 
PT-2211 This pstack return error code line number
 2023-11-12 23:27:58 +03:00
Sveta Smirnova
927b34904e Merge pull request #705 from percona/PT-2279_Option_charset_is_confusing_when_set_to_utf8mb4 
PT-2279 - Option --charset is confusing when set to utf8mb4
 2023-11-12 23:27:38 +03:00
Sveta Smirnova
52cc6c11de Follow PR-429 unstop option with testcase 
- Review by Evgeniy - print path to the sentinel file in case of error
 2023-11-12 23:26:14 +03:00
Sveta Smirnova
3e1e9b8425 PT-1860 make pt-osc respect case insesitive lookup on Windows and osx #516 
- Run update-modules
- Adjusted fix, so it does not create extra variable to hold $EVAL_ERROR
- Adjusted test case, so it runs on Linux
 2023-11-09 17:16:43 +03:00