Daniel Nichter
b3f0f414e4
Merge lp:~percona-toolkit-dev/percona-toolkit/pt-diskstats-2.0.
2012-02-03 15:25:25 -07:00
Daniel Nichter
f517675eb4
Compare lc(index) everywhere.
2012-02-03 11:38:20 -07:00
Daniel Nichter
0ac6c35211
Fix _pidof() calls in collect.sh. Update Bash libs in pt-ioprofile.
2012-02-03 10:49:27 -07:00
Daniel Nichter
3f14a60f5d
Fix pt-ioprofile so it works without a file. Add more tests.
2012-02-03 10:42:06 -07:00
baron@percona.com
8631fbff09
explain the even-intervals rule in the docs
2012-02-03 12:24:59 -05:00
baron@percona.com
dcc6b501d1
fix merge conflict in docs
2012-02-03 12:10:02 -05:00
baron@percona.com
24203f675d
docu changes
2012-02-03 12:09:00 -05:00
Brian Fraser
27323776a8
Applied Baron's patch, which changes how qtime and stime are calculated.
...
Also includes a second attempt at fixing the $Diskstats::printed_lines bug,
and fixed how the timestamp is chosen if --show-timestamps is in effect.
2012-02-03 14:00:40 -03:00
Brian Fraser
0a25bd038b
Merge with Baron's branch, and changes as per the new spec/docs.
2012-02-03 12:11:14 -03:00
baron@percona.com
6770f1a9dc
clarify documentation, serving as a spec for Brian
2012-02-02 23:13:38 -05:00
baron@percona.com
88fc42514f
merge Brian's changes
2012-02-02 20:33:23 -05:00
Brian Fraser
d11856d48f
Moved the calculation of {read,write}_ios_sec around a bit and marked it as TODO
2012-02-02 19:38:03 -03:00
Daniel Nichter
23f1716f39
Remove set -x from pt-summary and pt-ioprofile. Update libs in pt-ioprofile.
2012-02-02 13:47:51 -07:00
Daniel Nichter
3b823df674
Merge lp:~percona-toolkit-dev/percona-toolkit/fix-bug-919352.
2012-02-02 13:37:39 -07:00
Daniel Nichter
3ce22bce88
Reword error message.
2012-02-02 13:29:45 -07:00
Brian Fraser
842bfd47ba
Bug fix for https://bugs.launchpad.net/percona-toolkit/+bug/919352
...
Plus tweaking from Baron's comment in that bug.
2012-02-02 17:05:37 -03:00
Daniel Nichter
1a1bf2bcd5
Update safeguards.sh in pt-stalk.
2012-02-02 12:17:33 -07:00
Daniel Nichter
7be99c5140
Add _which() to alt_cmds.sh and update pt-stalk.
2012-02-02 12:04:28 -07:00
Daniel Nichter
c40e5db1bf
Fix lib tests for MySQL 5.0.
2012-02-02 10:56:55 -07:00
Daniel Nichter
e67020addb
Merge back recent changes.
2012-02-02 09:46:28 -07:00
Daniel Nichter
85fdb732c8
Merge lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0 and, previously merged into that, lp:~percona-toolkit-dev/percona-toolkit/use-mktemp-871438.
2012-02-02 09:38:11 -07:00
baron@percona.com
d59a73a756
fix bug 925477
2012-02-02 11:23:24 -05:00
Daniel Nichter
02812c068c
Remove set -u from pt-mysql-summary and rm tmp dir last.
2012-02-02 08:46:31 -07:00
Daniel Nichter
e64f23a2e3
Don't use random file in mk-mext. Quote file names. Remove tmp dir.
2012-02-02 08:44:38 -07:00
Brian Fraser
2f3f75965a
Fixed a 'Use of uninitialized value' error in Diskstats->print_deltas()
...
It's not clear to me how this can even happen, as the variable is
package-scoped and set during compilation, but this should fix it.
2012-02-02 11:14:20 -03:00
baron@percona.com
bfc61bd6b1
tweaks to docs
2012-02-02 08:45:32 -05:00
baron@percona.com
b837a0ca7e
merge Brian's doc changes
2012-02-02 08:42:42 -05:00
baron@percona.com
13bf6c7f8f
tweaks to docs, targeting the desired behavior that isn't there yet
2012-02-02 08:36:32 -05:00
Brian Fraser
b0f7bc4fc6
Tweaks requested by Baron, plus fixes.
...
Tweaks:
* --headers command line option, which can be used to
enable/disable the automatic headers, and the
automatic empty lines between samples.
* --show-timestamps, which changes the #ts line with
a timestamp in the HH:MM:SS format.
* Always use ReadKeyMini, even when we have Term::ReadKey.
In the latter case, use the Term::ReadKey functions,
but if they fail, try again with our own versions.
Fix:
Looks like I forgot to actually enable the "save the current, first
and last" samples. This is now on. It should mean faster and better
output when changing --group-by modes.
2012-02-01 19:12:03 -03:00
Daniel Nichter
5c6c28a6e6
Fix bug 925007 and bug 897483.
2012-02-01 11:01:49 -07:00
Daniel Nichter
4e69f68fc8
Quote vars in trg_processlist().
2012-02-01 10:10:08 -07:00
baron@percona.com
e0d358fce1
documentation updates
2012-02-01 11:41:39 -05:00
Daniel Nichter
a62b74585a
Merge lp:~percona-toolkit-dev/percona-toolkit/use-mktemp-871438.
2012-02-01 09:37:32 -07:00
Brian Fraser
7c4c186978
Change how Diskstats waits for its first handful of samples.
...
This fixes two bugs -- One a rounding error, one a desyncronization
between the main program and the data gathering daemon.
Additionally, it changes how the daemon prints the very first
sample. Before it would unconditionally wait until the time was
%$sample-time, which meant that in a worst case scenario,
a user could be left waiting for a while before seeing a line
of output.
This commit changes that first wait to only sleep if less
than 20% away from %$sample-time.
2012-02-01 12:14:09 -03:00
Brian Fraser
3de8aa530b
More fixes as per Baron's review.
2012-01-31 22:44:00 -03:00
Daniel Nichter
a488043774
Check for mysql after parsing options so --help works even if mysql isn't in PATH.
2012-01-31 13:25:20 -07:00
Brian Fraser
55ee808310
Bugfix for https://bugs.launchpad.net/percona-toolkit/+bug/903379
2012-01-31 17:19:22 -03:00
Brian Fraser
b03ef4cf75
Merge lp:~percona-toolkit-dev/percona-toolkit/update-table-chunker-in-tools
2012-01-31 17:00:36 -03:00
Brian Fraser
2963c5d5a5
Update TableChunker in pt-online-schema-change, pt-table-sync & pt-upgrade
2012-01-31 16:48:35 -03:00
Daniel Nichter
9d3c2f5002
Apply --where to chunk size test on replicas.
2012-01-31 12:42:53 -07:00
Daniel Nichter
df73364e97
Use VALUES instead of VALUE. Update TableChunker in all tools.
2012-01-31 11:07:08 -07:00
Daniel Nichter
6205505263
Don't use basename and quote $dir in tmpdir.sh.
2012-01-31 10:20:37 -07:00
baron@percona.com
37df5da4d6
doc tweaks
2012-01-31 12:01:32 -05:00
Daniel Nichter
1a619cc47c
Test and fix typo in MasterSlave.pm and update that module in all tools.
2012-01-31 09:53:06 -07:00
Brian Fraser
940b8d6bab
Merge from Baron's doc branch
2012-01-31 13:47:09 -03:00
Daniel Nichter
afd0bf8982
rm -rf the oprofile dirs.
2012-01-31 09:16:18 -07:00
baron@percona.com
56c3545af1
update docs to mention GDB risks
2012-01-31 10:39:09 -05:00
Brian Fraser
73c1e466d7
Several fixes & changes:
...
* qtime and stime computed correctly
* Interactive mode and changing groups doesn't fail
* Interactive mode no longer uses a file to gather samples.
2012-01-30 17:44:18 -03:00
Daniel Nichter
be8c0e6e18
Fix parsing opts from config file with leading and trailing space.
2012-01-30 11:15:28 -07:00
Daniel Nichter
89242d9fde
Don't init a global with a global.
2012-01-30 10:20:31 -07:00
