9 Commits

Author	SHA1	Message	Date
Carlos Salguero	1d1c13fbcb	WIP	2018-01-16 11:11:16 -03:00
Brian Fraser fraserb@gmail.com	3d263dd6ed	Merged fix-1007938-mysqlconfig-eol-comments, resolved conflicts	2012-12-05 14:46:32 -03:00
Brian Fraser	76a010abee	Fix for 917770: Use of uninitialized value in substitution (s///) at pt-config-diff line 1996 ... This turned out to be two bugs mangled into one. First, _parse_varvals can deal with (var, undef), but not with (undef). This is a problem because two of the trhee spots that call _parse_varvals can return undef because of this: map { $_ =~ m/^([^=]+)(?:=(.*))?$/ } grep { $_ !~ m/^\s*#/ } # no # comment lines split("\n", $mysqld_section) The problem is twofold. First, we are not skipping empty or whitespace-only lines. That means that the map will fail, and pass an undef to _parse_varvals. So this ended up in a triple fix: Make _parse_varvals deal with a sole undef, skip empty/whitespace lines, and change that map to map { $_ =~ m/^([^=]+)(?:=(.*))?$/ ? ($1, $2) : () } so even if the regex fails in the future, no sole undef will be passed down the chain.	2012-11-30 16:17:45 -03:00
Brian Fraser	5fd150de31	Extra tweaks due to feedback from kaiwangchen: ; starts comments if at the start of a line	2012-11-02 01:58:12 -03:00
Brian Fraser	fdb81f763d	Merged fix-1007938-mysqlconfig-eol-comments and fixed it to only take # as a start of comment, and to respect quoted values	2012-08-02 12:21:59 -03:00
Brian Fraser fraserb@gmail.com	d387b22c07	Bug 1007938: MySQLConfig doesn't support end-of-line comments ... Patch provided by Kaiwang CHEN (~kaiwang-chen) on Launchpad.	2012-06-11 12:33:45 -03:00
Daniel Nichter	bdbb66d22b	Re-add calls to Sandbox::ok().	2012-06-03 13:54:32 -04:00
Daniel Nichter	b805f7c92d	Remove $Revision$ and finish re-branding modules. Rename MaatkitTest.pm to PerconaTest.pm. Put copyrights on one line.	2011-07-12 15:47:07 -06:00
Daniel Nichter	6c501128e6	Add lib/, t/lib/, and sandbox/. All modules are updated and passing on MySQL 5.1.	2011-06-24 11:22:06 -06:00