Commit Graph

24 Commits

Author SHA1 Message Date
Sveta Smirnova
1407b5380b PT-2109 - pt-mysql-summary throws an error when using sql_mode="ANSI_QUOTES" (#696)
* PT-2109 - pt-mysql-summary throws an error when using sql_mode="ANSI_QUOTES"

- Fixed issues still visible with SQL mode ANSI_QUOTES
- Added test cases for this mode

* PT-2109 - pt-mysql-summary throws an error when using sql_mode="ANSI_QUOTES"

- Removed keyring plugin check in the beginning of the test, because
  reported error would show up even on servers that do not have keyring
  plugin installed. Same applies to wsrep_on check and Percona Server
  features checks.
- Removed temporary dir setup, because not needed for this test.
2023-11-03 01:46:32 +03:00
Viktor Szépe
2bd40d8c39 Remove trailing spaces (#665)
* Remove trailing spaces

* PR-665 -  Remove trailing spaces

- Updated not stable test t/pt-online-schema-change/preserve_triggers.t
- Updated utilities in bin directory

* PR-665 -  Remove trailing spaces

- Fixed typos

* PR-665 -  Remove trailing spaces

- Fixed typos

---------

Co-authored-by: Sveta Smirnova <sveta.smirnova@percona.com>
2023-09-06 01:15:12 +03:00
Sveta Smirnova
9755074cd8 PT-2156 Fix tests for lib, part2 (#650)
* PT-2156 - Fix tests for lib

Fixed tests, broken by putting fix for PT-1554 into the library code, mostly by updating checksums.
Added AutoCommit option for test lib/QueryReview.t
Reset SQL mode to empty to allow TableChunker to work with invalid and zero dates

* PT-2156 - Fix tests for lib

Adjusted t/lib/SchemaIterator.t to work with version 8.0

* PT-2156 - Fix tests for lib

Adjusted b/t/lib/Processlist.t, so it reflects fix for PT-981

* PT-2156 - Fix tests for lib

Adjusted t/lib/HTTP/Micro.t, so it works with different order of parameters, returned at v.percona.com/
Adjusted test for empty files in t/lib/bash/collect.t
Disabled mysqladmin debug test in t/lib/bash/collect.t, because of PT-2242

* PT-2156 - Fix tests for lib

Added LC_NUMERRIC=POSIX into t/lib/bash/report_system_info.sh, so reports in tests are not environment-dependent
Updated expected results in t/lib/bash/report_system_info.sh, so they reflect new information, collected by pt-summary

* PT-2156 - Fix tests for lib

- Improved fix for PT-76, so it handles inline comments
- Added test case for PT-76
- Improved fix for PT-1720, so it ignores unrecognizable option only if it comes from the toolkit-wide files and still errors out if wrong option was passed via command line or the tool-specific option file.

* PT-2156 - Fix tests for lib

- Improved fix for PT-2102, so it finds running instance configuration file using PID and also does not break t/lib/bash/report_mysql_info.t test
- Removed unnecessary copy-paste from t/pt-mysql-summary/pt-2102.t test
- Adjusted number of collected files in t/lib/bash/collect_mysql_info.sh

* PT-2156 - Fix tests for lib

- Fix for PT-1543 and MyRocks collection were originally put only into lib/bash/report_mysql_info.shthat broke the logic of collecting data first, then formatting report from this data. This, in its turn, broke test t/lib/bash/report_mysql_info.sh/t/lib/bash/report_mysql_info.t, because CMD_MYSQL is not defined in this library. I rewrote these fixes, so they follow original logic of the tool (pt-mysql-summary)
- Added tests for keyring plugin, encrypted tables, and MyRocks for t/lib/bash/report_mysql_info.sh and t/pt-mysql-summary/pt-mysql-summary_encryption.t

* PT-2156 - Fix tests for lib

- Added FLUSH TABLES to t/lib/bash/collect.sh, so it does not fail opentables tests if run when more than 1000 tables open in the sandbox environment
- Changed number of expected sample files to reflect keyring colletion file

* PT-2156 - Fix tests for lib

- Added skip to some tests in lib that file when run with PXC, because not supported to work with PXC
- Adjusted configuration files for PXC, so they allow LOAD DATA/SELECT INTO OUTFILE commands
- Adjusted data samples, so they do not depend on auto increment values
- Fixed lib tests, failing with PXC

* PT-2156 - Fix tests for lib

Updated tests for pt-online-schema-change, so they work with PXC and skipped if designed for semi-synchronous replication setup

* PT-2156 - Fix tests for lib

- Added cluster-specific samples for t/lib/SchemaIterator.t
- Removed extra debugging print from t/pt-table-checksum/pt-1728.t

* PT-2156 - Fix tests for lib

Evgeniy's review on July 20

* Update t/lib/TableSyncer.t

Removed comment left after debugging

* Update t/pt-mysql-summary/pt-mysql-summary_encryption.t

Removed extra debug output

* PT-2156 - Fix tests for lib

Tabs to spaces
2023-08-02 14:50:21 +03:00
Yoann La Cancellera
7ecdae6ef6 PT-2102_pt-mysql-summary should support include in config files (#601)
* PT-2102 pt-mysql-summary should support include* in config file

includedir directories are now printed in the order of which they appear in root my.cnf

* PT-2102 pt-mysql-summary should support include* in config file

!include was not supported. Changed 'for' to 'while' to properly
test for '!includedir' and '!include'. Supports extra spaces between
files and !include.

* PT-2102 pt-mysql-summary should support include* in config file

Updates modules, added test case for !include and !includedir
Changed find_my_cnf function to make it try every regexes and only
returned when it find one

* Update pt-mysql-summary

Identation fix as suggested by review

* Update collect_mysql_info.sh

Identation as suggested by review

* PT-2102 pt-mysql-summary should support include* in config file

Fix formatting after review

---------

Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
2023-02-23 16:00:44 +03:00
Carlos Salguero
d2ea011e87 PT-1525 Added support for roles in mysql-summary 2018-04-06 15:10:09 -03:00
Carlos Salguero
f6c01fc5bf PT-1526 Add ndb status to pt-mysql-summary 2018-04-04 09:26:02 -03:00
Fernando Ipar
58d1d2c3b4 Added skel for ndb status collector 2017-10-09 22:26:46 -03:00
Carlos Salguero
511c80389f PT-152 Added SHOW SLAVE HOST to pt-mysql-summary 2017-08-29 15:45:13 -03:00
Daniel Nichter
5ff62d6956 Fix tests. 2013-12-12 05:49:59 +00:00
Daniel Nichter
b7320fc9ee Remove mysqldump prompt, add --all-databases, and make --databases or --all-databases required to do mysqldump (Schema section). 2013-12-11 20:40:57 -08:00
Brian Fraser
9e2ce2197f pt-ms & pt-stalk: Enable the standard mysql options 2013-02-25 11:21:46 -03:00
Brian Fraser fraserb@gmail.com
f915e54a17 pt-mysql-summary: Make the "Executables" section work 2012-11-27 18:28:07 -03:00
Daniel Nichter
b6072ab011 Only cat cnf file > mysql-config-file if it exists. 2012-10-24 12:43:26 -06:00
Daniel Nichter
aacdd9db17 Rewrite find_my_cnf_file() so if a port is given only that port's cnf is returned, else nothing. 2012-10-24 11:17:34 -06:00
Brian Fraser fraserb@gmail.com
bc8f5a610c Change TMPDIR to PT_TMPDIR 2012-06-11 17:51:43 -03:00
Baron Schwartz
48f642551e fix some problems that happen when there are many mysqld instances 2012-06-03 20:53:57 -04:00
Brian Fraser fraserb@gmail.com
c0dedd19bf - section() revamp
- Redirect STDERR for the collection part in both tools
- rm_tempdir in sigtrap
- A part of pt-mysql-summary still depended on the system being run,
  rather than the samples being read. Now it works properly.
2012-04-02 19:25:17 -03:00
Brian Fraser fraserb@gmail.com
761f8a5aac Merge more of Baron's changes, also re-implement the MySQL Executables section
Plus other bugfixes.
2012-03-30 23:00:57 -03:00
Brian Fraser fraserb@gmail.com
978b236985 Save the config file itself, not just its path. 2012-03-30 20:18:39 -03:00
Brian Fraser fraserb@gmail.com
4bb5968c23 More fixes as per the reviews.
- Took out ${prefix}-
- get_var sanity
- pt-mysql-summary now follows pt-summary's suit and doesn't take
  in files to write to
- pt-summary defers setting the CMD_FOO vars to a function, as
  otherwise it would skip our PATH mungling.
2012-03-28 13:04:14 -03:00
Brian Fraser fraserb@gmail.com
0e4fa22d18 *-summary tools: Changes from the reviews. Tests for pt-mysql-summary not finished yet 2012-03-27 06:19:37 -03:00
Brian Fraser fraserb@gmail.com
3ffda5677b pt-summary for 2.1, also changes to pt-mysql-summary from Daniel's review 2012-03-24 14:20:09 -03:00
Brian Fraser fraserb@gmail.com
55c7248c54 (more syncing) 2012-03-20 17:16:06 -03:00
Brian Fraser fraserb@gmail.com
31afeb73b5 (temp commit, syncing up) 2012-03-20 11:21:16 -03:00