It is a thing: 2 nodes joining at the same time, with 2 JOINERs and 2
DONORs cluster-wide
It can happen on operators with 2 garbd joining at the same time
Before, pt-galera-log-explainer was using SST metadata naively.
Basically if a node was DONOR and we found a "transfer completed"
message, we assumed the donor name we found is the correct one.
So for concurrent SSTs, donors were swapping names.
Now, it is handled by a map, indexed by a donor name. To know if a node
is actual donor or not, it now compare timestamps of events. It assumes
both "selected donor" and "shifting DONOR" messages should have happen
in less than 0.01 secs to avoid any conflict.
Regression tests coming in next commit with an operator logs having
concurrent SSTs. Another conflicts was sometimes breaking the test
depending on the order on which we read files, hence why it's not added
here yet
It was due to a silly regression when reformatting the main.go
The function iterating was doing too many things, and returning an error
when nothing was found, and a "continue" was done on the main
"timelineFromPaths" loop
It is now a simple foreach loop that does not return error so we have to
check if the localtimeline slice is empty
* PT-2248 - pt-k8s-debug-collector does not run pg_gather with K8SPG 2
- Added check for K8SPG 2, so can run pg_gather for it
- Added new allowed value for option --resource:
-- pgv2 for K8SPG 2
-- auto to auto-detect custom resource
- Option --resource has now default value "auto"
- Updated documentation
- Added test cases for new options
* PT-2248 - pt-k8s-debug-collector does not run pg_gather with K8SPG 2
- Implemented custom user and secrets handling (in case when no default
user exists).
* PT-2235 - pt-mongodb-index-check does not support option --version
Changed command version to flag version
* PT-2235 - pt-mongodb-index-check does not support option --version
Updated documentation
* PT-2236 - pt-secure-collect, pt-pg-summary do not follow PT standard for option --version
- Redirected UsageWriter to os.Stdout for kingpin, so --version output
goes to STDOUT, not to STDERR
- Adjusted text, printed by the --version flag
- Added test cases to check how --version flag works
- Adjusted test cases, so they use TOOLNAME constant
* PT-2236 - pt-secure-collect, pt-pg-summary do not follow PT standard for option --version
Run go mod tidy as requested by Artem Gavrilov
* PT-2236 - pt-secure-collect, pt-pg-summary do not follow PT standard for option --version
Renamed const TOOLNAME to toolname to follow Go coding standards
* PT-2101 - pt-mongodb-query-digest doesn't work on standalone server
Restoring test case, disabled for new sandbox that was never created.
Added debugging output to find out why the tool behaves not as expected.
Most of changes into main.go will be removed after the fix is done.
* PT-2101 - pt-mongodb-query-digest doesn't work on standalone server
- Changed code so it works with the standalone server
- Updated main_test.go so it works for MongoDB 5.0
- Removed eval.js and group.js, because these command are not supported since MongoDB 4.2
* PT-2101 - pt-mongodb-query-digest doesn't work on standalone server
Updated go.mod and go.sum from the 3.x branch
* PT-2169 - pt-k8s-debug-collector integration of pg_gather requires croping first line of the output file
Modified pt-k8s-debug-collector so it redirects only STDOUT to summary.txt
STDERR is stored in the logs and recorded in summary.txt only if summary fails with the error
Modified Makefile, so it does not include closing bracket into the version string
Created test case for the fix
* PT-2169 - pt-k8s-debug-collector integration of pg_gather requires croping first line of the output
Removed else as requested by Ege
* PT-2165 - Actual Version, GoVersion, and Build for Go tools
Removed outdated numbers from main.go, because we update these numbers in the Makefile.
* PT-2165 - Actual Version, GoVersion, and Build for Go tools
Added template version into Makefile for the latest tag.
* PT-2164 - pt-k8s-debug-collector does not have version flag
Added flag
Updated README
* PT-2164 - pt-k8s-debug-collector does not have version flag
Added test case
* PT-2164 version flag for pt-k8s-debug-collector
go fmt for src/go/pt-k8s-debug-collector/main.go
* PT-2164 version flag for pt-k8s-debug-collector
Updated docs/pt-k8s-debug-collector.rst
* RM-1153 - Percona Toolkit 3.5.1
Updated version for Perl files to 3.5.1
Updated Perl module Percona::Toolkit to version 3.5.1 and updated all scripts using this module
Manually updated Go programs
Moved ONLY_UPDATE_VERSION after definition of DATE and SERIES variables, so the script does not fail because of undefined variables
* RM-1153 - Percona Toolkit 3.5.1
Updated Changelog
Updated release date in docs/percona-toolkit.pod
* PT-2162 Release Notes 3.5.1 (#571)
modified: Makefile.PL
modified: config/sphinx-build/conf.py
modified: docs/release_notes.rst
new file: docs/rn.3-5-1.txt
Co-authored-by: Alina Derkach <“alina.derkach@percona.com”>
* PT-7 Fix syntax (#573)
Co-authored-by: Alina Derkach <81975178+alina-derkach-oaza@users.noreply.github.com>
Co-authored-by: Alina Derkach <“alina.derkach@percona.com”>
Co-authored-by: EvgeniyPatlan <evgeniy.patlan@percona.com>
* PT-2134 - Support for PostgreSQL and PS MySQL operators
For PS MySQL operator: added support of pt-mysql-summary
For PostgreSQL operator: added support for pg_gather
Options added:
- kubeconfig - path to kubeconfig
- forwardport - port to use when calling pt-*-summary tools ad pt_gather
Options changed:
- resource - now default value is (was pxc). New values added:
psql - for PostgreSQL operator
ps - for PS MySQL operator
if default value () is used: only K8 information is collected
Otherwise resource-specific summary is collected
* PT-2134_support_for_PostgreSQL_and_MySQL_operators
Fixed summary collection when connecting to PostgreSQL opertor and no resource specified
* PT-2134 - support for PostgreSQL and MySQL operators
Added test case for full supported set of values for option --resource,
added --kubeconfig and --forwardport options for test cases,
added support for environment variables KUBECONFIG_PXC, KUBECONFIG_PS, KUBECONFIG_PSMDB, KUBECONFIG_PSQL, FORWARDPORT for test cases
* PT-2134 - support for PostgreSQL and MySQL operators
updated docs/pt-k8s-debug-collector.rst,
replaced README.md in src/go/pt-k8s-debug-collector wih symbolic link to docs/pt-k8s-debug-collector.rst
to avoid having inconsistent documentation
* PT-2134 - support for PostgreSQL and MySQL operators
Removed curl STDERR from the command output
* PT-2134 - support for PostgreSQL and MySQL operators
typo in pt-k8s-debug-collector.rst
* PT-2134 - support for PostgreSQL and MySQL operators
Renamed --resource=psql to --resource=pg after review suggestion by Ege
and collecting feedback from potential users
Co-authored-by: EvgeniyPatlan <evgeniy.patlan@percona.com>
Co-authored-by: Carlos Salguero <carlos.salguero@percona.com>
* Changelog and version for Release 3.5.0
* PT-2076 add rhel9 dependency
* PT-2128 Updated version to 3.5.0
Co-authored-by: svetasmirnova <sveta.smirnova@percona.com>
Co-authored-by: EvgeniyPatlan <evgeniy.patlan@percona.com>
* PT-2105 - Collect individual log files for PXC
Combined log files are hard to read by humans. Since pt-k8-debug-collector is the tool that
accesses data from the running pods, it can copy raw log files, necessary for troubleshooting PXC issues.
So, in addition to collecting logs.txt, this adds method getIndividualFiles for the Dumper that
reads individual files from PXC pods and stores them in the resulting archive.
Additionally, this commit fixes invalid timestamps in the resulting archive.
* PT-2105 - added support for non-default namespaces
* PT-2105 Let pt-k8-debug-collector to collect individual logs in PXC pods
Added test case for this new collection.
* Update go.mod
Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>
Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>
* PT-1979 Improved mdb summary information
Added the MongoDB instance command line options to the output.
Also fixed the spacing in the replicaset section.
* Added new template file
* Upgraded deps due to security issues
* Updated changelog for (WIP) 3.3.2
* Updated changelog
* PT-7116 Updated MyState results
* PT-7116 Updated MyState results
* PT-7116 Updated MyState results
* PMM-7116 Return the error in MyState
Don't manage the error, just bubble it up.
The client must know there was an error, even when the error is no
'real' like in Mongos instances (there is no error because there is no
replicaset for mongos or standalone)
By setting SOURCE_DATE_EPOCH builds the build binaries can become
reproducible as a rebuild will take the old build date as input.
Motivation: https://reproducible-builds.org
* PMM-8575 Fixed test
Fixed sandbox used by go programs, updated all tests.
* PMM-8575 Fixed test
Fixed sandbox used by go programs, updated all tests.
* Removed Gopkg
* Switched to go 1.16
* Updated go.mod
* Upgraded deps
* Updated deps
* PMM-8489 Cluster ID for standalone server
* Updated error type
* Updated MyState to ignore errors on standalone servers
* Deleted dep files
* Revert "Deleted dep files"
This reverts commit 236303196b.
* Removed go.mod &^ updated lock
* Updated mongodb driver
* PMM-8489 Updated errors list
* PT-1930: pt-k8s-debug-collector should not attempt collecting PXC information when running against PSMDB
https://jira.percona.com/browse/PT-1930
Removed PXC resources to collect while running with `--resource psmdb`
* Add more `psmdb` resources
Also resolves https://jira.percona.com/browse/PT-1934
* Add `resourceType` function to collect summaries for PXC/PSMDB when option `--cluster` is specified
