Daniel Nichter
cfce6e6eb2
More quoting and tweaking re Baron's review.
2012-01-13 10:02:17 -07:00
Daniel Nichter
87d12c9802
Don't warn about invalid lines, just debug them. Anchor TS pattern. Unset --sample-time unless --group-by sample.
2012-01-12 14:26:31 -07:00
Daniel Nichter
60e16254d3
Correction to r140: only the test marked in this diff needs to be fixed.
2012-01-12 12:09:01 -07:00
Daniel Nichter
9404ff84ef
Rewrite pt-diskstats.t but all tests need to be fixed. Update modules in pt-diskstats, use PTDEBUG, check regex opts. Remove output_fh from Diskstats. Fix DiskstatsMenu header so update-modules can see it.
2012-01-12 12:06:50 -07:00
Daniel Nichter
8d70a272fe
Simplify parse_diskstats_line() and _calc_delta_for(). Use UPPERCASE for constants. Don't save unused values in dev stats array. Use actual values from an OptionParser/pt-diskstats.
2012-01-12 10:09:40 -07:00
Brian Fraser
3165b3c0f8
Slew of changes from Daniel's review.
2012-01-12 10:37:49 -03:00
Daniel Nichter
a9afea4506
Quote vals in Bash libs. Add tests for log_warn_die.sh and alt_cmds.sh. Make --help test path independent.
2012-01-11 11:31:41 -07:00
Brian Fraser
6d47e958c7
Change ->filter_zeroed_rows into ->zero_rows.
2012-01-10 16:28:32 -03:00
Brian Fraser
f173069109
Stop using /(?=)/ since /.+/ is good enough.
...
Originally, DiskstatsMenu differentiated between an empty pattern
entered by the user (which in the shell version meant "match all")
and any other valid pattern by replacing it with /(?=)/.
However, Diskstats now carries the original string, inside the
OptionParser object, so the above was redundant.
2012-01-10 16:10:50 -03:00
Brian Fraser
eaae370f81
Removed the handling of the partition format.
...
/proc/diskstats actually has two formats, one for devices, one for
partitions. The latter wasn't handled by the original pt-diskstats,
but one of the previous commits introducing some minimal handling
for that. This commit removes that, since the partition format
doesn't have enough information to be useful.
2012-01-10 14:28:24 -03:00
Brian Fraser
13210d1978
Explicit setter for filename.
2012-01-10 14:16:44 -03:00
Brian Fraser
5ad1bc4fbb
Explicit setter for device_regex and column_regex.
2012-01-10 14:14:32 -03:00
Brian Fraser
93279a03da
Explicit setter for out_fh.
2012-01-10 14:05:02 -03:00
Brian Fraser
ae76c73395
Explicit setter for interactive.
2012-01-10 14:01:11 -03:00
Brian Fraser
79bdf3f1d3
Explicit setter for sample_time
2012-01-10 13:52:43 -03:00
Brian Fraser
187d921069
Explicit setter for filter_zeroed_rows
2012-01-10 13:46:05 -03:00
Brian Fraser
25909caa4e
Explicit setters for (curr|prev|first)_ts.
2012-01-10 13:40:51 -03:00
Brian Fraser
9fd8e8d61d
Make a test clean up after itself.
2012-01-10 11:26:11 -03:00
Brian Fraser
01042d0fda
Use waitpid($pid, WNOHANG) instead of kill(0, $pid).
2012-01-10 11:25:18 -03:00
Brian Fraser
5098d33372
Updated tool based on the previous commits.
2012-01-10 10:55:16 -03:00
Brian Fraser
038dfeba59
Useless local pointed out by Daniel.
2012-01-10 10:53:28 -03:00
Brian Fraser
b4289010b1
Several fixes. --save-samples and --help should work now.
2012-01-10 10:47:50 -03:00
Daniel Nichter
97f42e9c07
Merge lp:~jamie-mccarthy/percona-toolkit/devel.
2012-01-09 11:12:50 -07:00
Daniel Nichter
a85dffd511
Test for bug 821709.
2012-01-09 11:10:35 -07:00
Jamie McCarthy
bf348ae167
Fix bug 821709, typo in pt-show-grants
2012-01-06 10:28:03 -05:00
Daniel Nichter
bc87f679f5
Build percona-toolkit-2.0.2
2012-01-05 12:20:21 -07:00
Daniel Nichter
254fcdb1bb
Merge lp:~percona-toolkit-dev/percona-toolkit/fix-bug-911996.
2012-01-05 12:06:10 -07:00
Daniel Nichter
520948c14e
Update sample files.
2012-01-05 11:54:27 -07:00
Daniel Nichter
f4362cb2e7
Test and fix bug 911996.
2012-01-05 11:46:38 -07:00
Brian Fraser
d6b15f4916
bin/pt-mysql-summary: Enable set -u
2012-01-03 15:10:16 -03:00
Brian Fraser
96aabd2999
bin/pt-summary: Enable set -u
2012-01-03 15:01:09 -03:00
Brian Fraser
f4b8e8356b
test-bash-functions: test_name is optional, so avoid it stopping us if set -u
2012-01-03 14:59:55 -03:00
Brian Fraser
9facff62af
pt-summary: Use mktemp through the tmpdir package.
2012-01-03 14:54:38 -03:00
Brian Fraser
f6382f03d8
pt-sift: Use mktemp through the tmpdir package.
2012-01-03 14:54:27 -03:00
Brian Fraser
e1f31e99f1
pt-mext: Use mktemp through the tmpdir package.
2012-01-03 14:54:15 -03:00
Brian Fraser
0ca763c81b
pt-mysql-summary: Use mktemp through the tmpdir package.
2012-01-03 14:52:57 -03:00
Daniel Nichter
b966f63971
Fix typos in release_notes.rst.
2011-12-30 15:53:59 -07:00
Daniel Nichter
4d473afe6d
Build percona-toolkit-2.0.1
2011-12-30 15:44:29 -07:00
Daniel Nichter
45104f8b34
Fix version so build-packages won't complain.
2011-12-30 15:42:44 -07:00
Daniel Nichter
f042ff828a
Tweak Changelog.
2011-12-30 15:36:19 -07:00
Daniel Nichter
65db1f0335
Fix SET @@binlog_format statement.
2011-12-30 14:46:18 -07:00
Daniel Nichter
2221b13cd3
Fix pod2rst output.
2011-12-30 11:42:05 -07:00
Daniel Nichter
d1bd7a9f3b
Change MKDEBUG to PTDEBUG. Remove 1.0.2 from release notes.
2011-12-30 09:23:41 -07:00
Daniel Nichter
547cbfd348
Update Changelog.
2011-12-29 17:44:21 -07:00
Daniel Nichter
cf10e3e521
Merge lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-2.0.
2011-12-29 17:39:26 -07:00
Daniel Nichter
c58dfca1b5
Use latest Quoter::(de)serialize_list() in pt-table-checksum and pt-table-sync. Add more char_chunking.t tests for pt-table-checksum.
2011-12-29 17:25:38 -07:00
Brian Fraser
1f06ea093a
Modified (de)serialize_list to handle undefs and empty string elements better.
2011-12-29 17:22:17 -03:00
Daniel Nichter
ac94de6cb0
Use new Percona-themed docs (from lp:~mauricio-stekl/percona-toolkit/pt-docs-percona-theme).
2011-12-29 10:51:55 -07:00
Daniel Nichter
6088ffa43d
Use new Quoter (de)serialize_list() in pt-table-checksum and pt-table-sync.
2011-12-28 17:12:12 -07:00
Daniel Nichter
03a86c6838
Merge lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-2.0-serialize_list-v2.
2011-12-28 16:26:31 -07:00
