Commit Graph

10 Commits

Author SHA1 Message Date
Hartley McGuire
47f7638d60 PT-2015 Fix pt-config-diff not sorting flags
Previously, flags would be compared in the exact order they are output
by MySQL, which can result in false negatives if the input ordering does
not match.

Example from the ticket:

```
[root@avvr-dbm51 ~]# pt-config-diff /etc/my.cnf h=localhost,P=3047
1 config difference
Variable                  /etc/my.cnf  avvr-dbm51
========================= ============ ============
myisam_recover_options    FORCE,BACKUP BACKUP,FORCE
```

This commit fixes the issue by sorting the flags before comparison to
ensure that any ordering differences will not report a diff.

Co-authored-by: Jonathan Gnagy <jonathan@therubyist.org>
2025-08-27 16:12:27 +00:00
Viktor Szépe
2bd40d8c39 Remove trailing spaces (#665)
* Remove trailing spaces

* PR-665 -  Remove trailing spaces

- Updated not stable test t/pt-online-schema-change/preserve_triggers.t
- Updated utilities in bin directory

* PR-665 -  Remove trailing spaces

- Fixed typos

* PR-665 -  Remove trailing spaces

- Fixed typos

---------

Co-authored-by: Sveta Smirnova <sveta.smirnova@percona.com>
2023-09-06 01:15:12 +03:00
Carlos Salguero
a6c55737f5 Updated tests & 5.7 sandbox files 2017-04-27 12:06:43 -03:00
Daniel Nichter
feab2f0925 s/Percona Inc/Percona Ireland Ltd/g 2013-01-02 17:19:16 -07:00
Brian Fraser
ac015477af Bug 1022622: pt-config-diff is case-sensitive 2012-07-27 20:12:45 -03:00
Daniel Nichter
88304e69fb Replace MKDEBUG with PTDEBUG in modules. 2012-01-19 12:46:56 -07:00
Daniel Nichter
b805f7c92d Remove $Revision$ and finish re-branding modules. Rename MaatkitTest.pm to PerconaTest.pm. Put copyrights on one line. 2011-07-12 15:47:07 -06:00
Daniel Nichter
55c69ffbc1 Move module docu to work for NaturalDocs. 2011-07-02 12:29:08 -06:00
Daniel Nichter
82931ec399 Enclose all packages blocks and add Package devel docu. 2011-06-28 17:50:02 -06:00
Daniel Nichter
6c501128e6 Add lib/, t/lib/, and sandbox/. All modules are updated and passing on MySQL 5.1. 2011-06-24 11:22:06 -06:00