percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-15 07:55:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,968 Commits 142 Branches 71 Tags
20ace5a9e94012b45db641c5dc2bc2bbd56c9275
Commit Graph

667 Commits

Author SHA1 Message Date
Daniel Nichter
b2bac5c765 Quote in tmpdir.sh and fix typo in doc. 2012-01-17 12:15:49 -07:00
Brian Fraser
3a66cf5187 Removed lib/pt_diskstats.pm, since it's no longer needed. 2012-01-17 11:41:15 -03:00
Brian Fraser
05fec15473 Fixes as per Baron's review. 2012-01-17 11:40:01 -03:00
Brian Fraser
d01d838b64 Several changes as per Baron & Daniel's mails. 
Most importantly, it replaces --zero-rows with --show-inactive, and
changes the default logic used to decide when to print a device.
 2012-01-16 09:37:53 -03:00
Daniel Nichter
cfce6e6eb2 More quoting and tweaking re Baron's review. 2012-01-13 10:02:17 -07:00
Daniel Nichter
87d12c9802 Don't warn about invalid lines, just debug them. Anchor TS pattern. Unset --sample-time unless --group-by sample. 2012-01-12 14:26:31 -07:00
Daniel Nichter
9404ff84ef Rewrite pt-diskstats.t but all tests need to be fixed. Update modules in pt-diskstats, use PTDEBUG, check regex opts. Remove output_fh from Diskstats. Fix DiskstatsMenu header so update-modules can see it. 2012-01-12 12:06:50 -07:00
Daniel Nichter
8d70a272fe Simplify parse_diskstats_line() and _calc_delta_for(). Use UPPERCASE for constants. Don't save unused values in dev stats array. Use actual values from an OptionParser/pt-diskstats. 2012-01-12 10:09:40 -07:00
Brian Fraser
3165b3c0f8 Slew of changes from Daniel's review. 2012-01-12 10:37:49 -03:00
Daniel Nichter
a9afea4506 Quote vals in Bash libs. Add tests for log_warn_die.sh and alt_cmds.sh. Make --help test path independent. 2012-01-11 11:31:41 -07:00
Brian Fraser
6d47e958c7 Change ->filter_zeroed_rows into ->zero_rows. 2012-01-10 16:28:32 -03:00
Brian Fraser
f173069109 Stop using /(?=)/ since /.+/ is good enough. 
Originally, DiskstatsMenu differentiated between an empty pattern
entered by the user (which in the shell version meant "match all")
and any other valid pattern by replacing it with /(?=)/.

However, Diskstats now carries the original string, inside the
OptionParser object, so the above was redundant.
 2012-01-10 16:10:50 -03:00
Brian Fraser
eaae370f81 Removed the handling of the partition format. 
/proc/diskstats actually has two formats, one for devices, one for
partitions. The latter wasn't handled by the original pt-diskstats,
but one of the previous commits introducing some minimal handling
for that. This commit removes that, since the partition format
doesn't have enough information to be useful.
 2012-01-10 14:28:24 -03:00
Brian Fraser
13210d1978 Explicit setter for filename. 2012-01-10 14:16:44 -03:00
Brian Fraser
5ad1bc4fbb Explicit setter for device_regex and column_regex. 2012-01-10 14:14:32 -03:00
Brian Fraser
93279a03da Explicit setter for out_fh. 2012-01-10 14:05:02 -03:00
Brian Fraser
ae76c73395 Explicit setter for interactive. 2012-01-10 14:01:11 -03:00
Brian Fraser
79bdf3f1d3 Explicit setter for sample_time 2012-01-10 13:52:43 -03:00
Brian Fraser
187d921069 Explicit setter for filter_zeroed_rows 2012-01-10 13:46:05 -03:00
Brian Fraser
25909caa4e Explicit setters for (curr|prev|first)_ts. 2012-01-10 13:40:51 -03:00
Brian Fraser
01042d0fda Use waitpid($pid, WNOHANG) instead of kill(0, $pid). 2012-01-10 11:25:18 -03:00
Brian Fraser
038dfeba59 Useless local pointed out by Daniel. 2012-01-10 10:53:28 -03:00
Brian Fraser
b4289010b1 Several fixes. --save-samples and --help should work now. 2012-01-10 10:47:50 -03:00
Daniel Nichter
cf10e3e521 Merge lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-2.0. 2011-12-29 17:39:26 -07:00
Daniel Nichter
c58dfca1b5 Use latest Quoter::(de)serialize_list() in pt-table-checksum and pt-table-sync. Add more char_chunking.t tests for pt-table-checksum. 2011-12-29 17:25:38 -07:00
Brian Fraser
1f06ea093a Modified (de)serialize_list to handle undefs and empty string elements better. 2011-12-29 17:22:17 -03:00
Brian Fraser
85817a795c Slight improvement to the deserialize regex and its test output. 2011-12-28 20:08:30 -03:00
Daniel Nichter
4197b09f53 Adjust code spacing, tweak comments, do only (de)serialize tests with database, give tests names. 2011-12-28 15:47:50 -07:00
Brian Fraser
88e82d665d Include serialize_list() and deserialize_list() to roundtrip through a DB. 2011-12-28 16:44:49 -03:00
Daniel Nichter
09cd535d3a Merge lp:~daniel-nichter/percona-toolkit/bash-tool-libs. 2011-12-27 15:37:09 -07:00
Daniel Nichter
f122861808 Fix --where with one nibble. Update chunk_index.t. 2011-12-27 11:12:40 -07:00
Daniel Nichter
b63bc4c26b Convert pt-table-checksum boundaries to SQL WHERE clauses. 2011-12-22 15:43:15 -07:00
Brian Fraser
d3ef9edaaa Several corrections as per Daniel and Baron's feedback. 
Still TODO: Attributes still have a single method that doubles
as a getter and setter. The constructor for Diskstats is still
weird -- A tad more stricter than it should be, if anything.
->print_rest is still rest, even though that's hardly
memorable, mostly because of a lack of ideas on what to
rename it. The main loop in the Menu is still a while (1).

As a nice perk, it's nearly twice as fast now! It also adds a
_very_ experimental --memory-for-speed argument, which
turns on memoization for the current biggest bottleneck.
 2011-12-22 19:24:56 -03:00
Daniel Nichter
1d8da408fc Revert to r243 to undo pt-table-sync changes. 2011-12-22 12:06:25 -07:00
Daniel Nichter
2760322c87 Don't bidi cmp equal rows. Commit if not --lock and using txn. Fix pt-table-sync basics.t. 2011-12-22 12:01:03 -07:00
Daniel Nichter
cfc57c71af Make pt-table-sync --replicate work with pt-table-checksum 2.0. 2011-12-22 10:10:22 -07:00
Daniel Nichter
457fa70668 Fix TableSyncer trace msg, implement --explain, fix locking/committing. Add aux dbh, dbh opts, and disconnect() to Cxn. 2011-12-21 21:12:03 -07:00
Daniel Nichter
ec8471ba28 Finish rewriting TableSyncer and updating its test. Add RowSyncerBidirectional.pm. Add GENLOG switch to start-sandbox. 2011-12-21 12:10:57 -07:00
Daniel Nichter
4c8fd5c080 Rewrite TableSyncer to use only NibbleIterator. Add RowSyncer. Return hashref from NibbleIterator. 2011-12-21 01:19:50 -07:00
Brian Fraser
467254aca3 Fixes to the Menu; additionally, changed the accepted format for samples. 
Also made it hide rows that are all zeroes by default, as per the
blueprint.
 2011-12-20 12:53:35 -03:00
Daniel Nichter
5d2e60791c Don't add ORDER BY to nibble SQL by default. 2011-12-19 14:17:11 -07:00
Daniel Nichter
0056014339 Let desc sentence be terminated by period of question mark. 2011-12-19 12:55:14 -07:00
Daniel Nichter
9baea8b7b6 Convert parse_option to sh, use Perl instead of awk, implement --help. 2011-12-19 12:51:47 -07:00
Daniel Nichter
3266e0aeca Don't use OPT_TMPDIR in tmpdir.sh. Define EXT_ARGV in parse_options.sh. 2011-12-19 11:29:21 -07:00
Daniel Nichter
bb315948cd Parse disk space using df -P -k. 2011-12-19 10:22:42 -07:00
Brian Fraser
8da8d1ff61 Diskstats.pm: Wrong math for millisecond to second. 
Sorry about that. Mind bug on my side.
 2011-12-16 13:55:31 -03:00
Brian Fraser
13c9c5b0bb Added the actual pt-diskstats tool. 
Missing a doc overhaul and tests, but this deals with most of the
feature upgrades in the blueprint.

The shell version of pt-diskstats is now in bin has pt-diskstats-shell,
in case that's needed.
 2011-12-16 13:40:22 -03:00
Brian Fraser
7b12dbec64 Work in progress v3: Working interactive mode, initial documentation. 
With this most of the interactive mode should be working.

pt_diskstats.pm has the documentation and can be used for testing,
which should be in the next commit.

This commit also includes the revamped command line options.
 2011-12-15 20:26:55 -03:00
Daniel Nichter
a172a3f2a7 Return 0 only if no --help, --verion, or opt errors. 2011-12-15 12:12:18 -07:00
Daniel Nichter
f3ac1b20c2 Add usage_or_errors() to parse_options.sh. 2011-12-15 12:01:22 -07:00