Commit Graph

5432 Commits

Author SHA1 Message Date
Yoann La Cancellera
da3acc8e57 Update src/go/pt-galera-log-explainer/README.rst
Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
fd9d09d9ae Fix: README with -vvv, --grep-args, regex-list 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
d1f7c72a9f PR-669 - Add pt-galera-log-explainer percona#669
- Commented out whois command in README.rst
- Copied README.rst into docs directory, so user manual will include
  this tool
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
a5cf09a79e Remove: --grep-args
Can be used to break the tool, and I actually never had an use-case
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
6d9136890a Fix: typos 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
8b84adb1e0 Remove old comments, dead code 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
4f5b089a34 Add: translate tests 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
84dcf1ef9c Commenting out whois+sed, will be re-added later 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
c910c35d3e Refactoring: migrate translations to singleton
It was using maps in each context, which would be merged between
contexts, then injected each time we needed a message to display.

It had a limitation on complicated operator setups: historical
information would be overriden by newer associations.
(e.g, that IP was for node0 yesterday, now it's node1, so associations
have been overwritten and incorrect)

It also introduced complexity, such as forcing to define closures too
many times, merging maps, it would be harder to debug, and every files
were starting from empty translation maps.
Moreover, iterating on maps is guaranteed to be random so it could create
hard-to-debug output variations on complex cases.

Now it is a singleton in translate package, still using maps but now it
associates an array of "units" storing the timestamp with each piece of information.
It is protected by rwmutex, because map are not threadsafe. (there's no
parallel processing for now)

No regressions, and it passes "operator_ambiguous_ips_list_all_no_color"
where the old system failed.
It nows also can be used as an easy to read source of information in
itself
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
ea262eff27 Add: inconsistent vote regex corner-case 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
580ccb7428 Add: shortuuid check, new date layout found 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
3eaf60bd88 Add: same ip/name limitation on README.rst 2023-12-29 17:19:24 +03:00
Yoann La Cancellera
7513e1ded7 Add: operator member assocations regex
It existed for non-operator setup, but was not working for operators due
to k8s logs not interpreting newlines and tabs
This operator version re-uses existing regular regex handlers directly
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
d13292ba67 Improve: main_test
It must test multiple times to remove doubts.
As the tool is reading files and relying on maps, their access order are
random. It can impact some translations
2023-12-29 17:19:24 +03:00
Yoann La Cancellera
c67047e781 Remove: propagation of ip propagation to older hash, Add: operator regression test
When adding "ownip", it was also propagating the new IP to the old hash.
But with operators, when IP where changing hash will also change, so
linking the new IP to old hash is anachronic. It is not wrong, but
depending on the order of map merges, the newest information could have
been overriden depending on the order of events.

That situation was producing X(2*number of conflicts) versions of output for operators, with
different md5sum, which could produce false-positive regression tests

So currently some information are not linked anymore, so some IPs are
not translated even though they could, but it is a limitation of using
maps as source of truth, as they are not versioned
2023-12-29 17:19:01 +03:00
Sveta Smirnova
59e0867e3a Changelog template for version 3.5.8 2023-12-28 10:47:01 +03:00
Sveta Smirnova
8369cfc42a Merge pull request #747 from percona/release-v3.5.7
Release v3.5.7
v3.5.7
2023-12-23 02:07:45 +03:00
Sveta Smirnova
7617e20e48 Date in release notes 2023-12-22 23:49:01 +03:00
Sveta Smirnova
be9bade155 Corrrected version for build tools 2023-12-22 23:38:42 +03:00
Sveta Smirnova
5b61ec79b5 Version and release notes updated 2023-12-22 23:34:57 +03:00
Sveta Smirnova
58cfb21740 Merge pull request #738 from percona/dependabot/go_modules/github.com/google/uuid-1.5.0
Bump github.com/google/uuid from 1.4.0 to 1.5.0
2023-12-22 23:23:10 +03:00
dependabot[bot]
6fb5dad85e Bump github.com/google/uuid from 1.4.0 to 1.5.0
Dependabot couldn't find the original pull request head commit, e6c2b03cb4e7570a374c59c568d51136ae9d82ce.
2023-12-22 20:22:25 +00:00
Sveta Smirnova
4ecc4838fb Merge pull request #739 from percona/dependabot/go_modules/k8s.io/api-0.29.0
Bump k8s.io/api from 0.28.4 to 0.29.0
2023-12-22 23:21:43 +03:00
dependabot[bot]
f87a07d007 Bump k8s.io/api from 0.28.4 to 0.29.0
Dependabot couldn't find the original pull request head commit, 7e14040fd776d305c702dc277a37a74f7b1cf813.
2023-12-22 20:19:16 +00:00
Sveta Smirnova
425ac80d6c Merge pull request #722 from alina-derkach-oaza/PT-2291-RN-3.5.6
PT-2291 Release notes for Percona Toolkit version 3.5.6
2023-12-22 23:11:32 +03:00
Sveta Smirnova
baf12f793d Update percona-toolkit.pod
Suggestion added by Eleonora when merged https://github.com/percona/percona-toolkit/pull/745
2023-12-22 23:11:32 +03:00
Sveta Smirnova
04d4329fc7 PT-2291 - Release notes for Percona Toolkit version 3.5.6
- Removed extra row for the same contribution
2023-12-22 23:11:32 +03:00
Sveta Smirnova
27f3ee1591 Merge pull request #745 from percona/release-v3.5.6
Release v3.5.6
2023-12-22 23:11:32 +03:00
Sveta Smirnova
504e64fd17 typo in Changelog 2023-12-22 23:11:32 +03:00
Sveta Smirnova
d3b4222bea Merge pull request #736 from percona/v3.5.6-version-modules-update-2
Updated modules and version
2023-12-22 23:11:32 +03:00
Sveta Smirnova
9fc0e72ea0 Update docs/release_notes.rst
Co-authored-by: Alina Derkach <alina.derkach@percona.com>
2023-12-22 23:11:32 +03:00
Sveta Smirnova
d04968b20c Updated release notes 2023-12-22 23:11:32 +03:00
Sveta Smirnova
089452e9a5 Update Changelog
Co-authored-by: Alina Derkach <alina.derkach@percona.com>
2023-12-22 23:11:32 +03:00
Sveta Smirnova
72d3805cb4 PT-2291 - Release notes for Percona Toolkit version 3.5.6
- Updated Changelog
2023-12-22 23:11:32 +03:00
EvgeniyPatlan
a7050eda92 Merge pull request #744 from EvgeniyPatlan/release-v3.5.6
ENG-7 fix version
2023-12-22 23:11:32 +03:00
Sveta Smirnova
05f193cb34 PT-2291 - Release notes for Percona Toolkit version 3.5.6
- Updated Changelog
2023-12-22 23:11:32 +03:00
Sveta Smirnova
f3ae05c9bd Merge pull request #740 from percona/dependabot/go_modules/golang.org/x/crypto-0.17.0
Bump golang.org/x/crypto from 0.16.0 to 0.17.0
2023-12-22 23:11:32 +03:00
Evgeniy Patlan
c47e6d5e83 ENG-7 fix version 2023-12-22 23:11:32 +03:00
Sveta Smirnova
a8ba844bcd More changes into Changelog and sorted output 2023-12-22 23:11:32 +03:00
Sveta Smirnova
efcfe78d7e Merge branch 'release-v3.5.6' of github.com:percona/percona-toolkit into release-v3.5.6 2023-12-22 23:11:32 +03:00
dependabot[bot]
1edf41124a Bump golang.org/x/crypto from 0.16.0 to 0.17.0
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0.
- [Commits](https://github.com/golang/crypto/compare/v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-22 23:11:32 +03:00
Evgeniy Patlan
8cf261c3f9 ENG-7 fix deb build 2023-12-22 23:11:32 +03:00
Sveta Smirnova
6cdb5a07cd More changes into Changelog 2023-12-22 23:11:32 +03:00
Sveta Smirnova
cb6955c04c updated docs/percona-toolkit.pod 2023-12-22 23:11:32 +03:00
Sveta Smirnova
3a0a0f54d3 Merge pull request #743 from EvgeniyPatlan/release-v3.5.6
ENG-7 fix deb build
2023-12-22 23:11:32 +03:00
Evgeniy Patlan
cce5583545 ENG-7 fix build on el8 2023-12-22 23:11:32 +03:00
Sveta Smirnova
d9e783e0c8 Merge remote-tracking branch 'alina-derkach-oaza/PT-2291-RN-3.5.6' into release-v3.5.6 2023-12-22 23:11:32 +03:00
Sveta Smirnova
ffafa79123 Merge pull request #742 from EvgeniyPatlan/release-v3.5.6
ENG-7 fix build on el8
2023-12-22 23:11:32 +03:00
Evgeniy Patlan
e7d15f13b0 ENG-7 fix build 2023-12-22 23:11:32 +03:00
Sveta Smirnova
becd4722db PT-2291 - Release notes for Percona Toolkit version 3.5.6
- Removed extra row for the same contribution
2023-12-22 23:11:32 +03:00