Brian Fraser
7f557759a7
Updates per Daniel's review
2012-11-01 16:51:58 -03:00
Daniel Nichter
8d82a80b5e
Update TableParser in all tools.
2012-11-01 11:33:47 -06:00
Daniel Nichter
949cf31037
Set sql_mode='' before SHOW CREATE TABLE--don't bother with replacing certain values. Move and rewrite tests to ansi_quotes.t.
2012-11-01 11:31:31 -06:00
Brian Fraser
a5a23665fe
Simplified split_grants() and added a test for mixed table & column grants on the same table
2012-11-01 06:15:54 -03:00
Brian Fraser
4b5c8969f0
Fix for 937234: pt-query-advisor issues wrong RES.001
2012-11-01 05:33:35 -03:00
Brian Fraser
1292d32538
Fix for 1052475: Crash in ptc::wait_for_last_checksum() if the slaves had errors
2012-11-01 05:00:30 -03:00
Brian Fraser
ab0e418fff
Fix for 1041391: Debug statement for Chosen hash func prints undef
2012-11-01 04:38:18 -03:00
Daniel Nichter
0fd9239500
Implement split_grants() instead of split(',', $grants) to handle spliting grants with column-level privs.
2012-10-31 14:20:43 -06:00
Daniel Nichter
0453d7dd82
Failing test case.
2012-10-31 13:16:25 -06:00
Daniel Nichter
9b6f10480c
Merge fix-938660-ptc-chunk-size-limit-0
2012-10-31 12:20:54 -06:00
Daniel Nichter
7c23608603
Always report slaves with tables too large, regardless of --chunk-size-limit.
2012-10-31 12:17:02 -06:00
Daniel Nichter
b5c48f07d1
Remove unused $limit. Make $chunk_size_limit || 1 because it's the one used for #-of-rows check on slaves. Reverse the new test because we don't want to disable the #-of-rows check.
2012-10-31 12:12:51 -06:00
Daniel Nichter
ce3c80ea45
Remove --chunk-size-limit on index check. If nibbling, the indexes must match, so --chunk-size-limit isn't a factor here.
2012-10-31 10:31:59 -06:00
Brian Fraser fraserb@gmail.com
e437ba9b3d
Updated Mo in all tools
2012-10-31 12:21:47 -03:00
Brian Fraser
dce8db5be1
Fix for 823431: pt-query-advisor hangs on big queries
...
This was caused by a regex backtracking itself to a halt. The solution
was to add a positive lookahead that searches for the floating but mandatory
substrings that the regex needs; if those exist, then eventually it will
match, but if they don't, it'll fail quickly.
2012-10-31 06:48:54 -03:00
Brian Fraser
64fe380986
Updated modules in all tools
2012-10-31 06:18:34 -03:00
Brian Fraser
572ee45185
Merged fix-1052722-pt-fifo-split-n-minus-1-rows-initially
2012-10-30 22:14:11 -03:00
Brian Fraser
b9bfe6114c
Merged fix-821715-enable-local-infile-in-dsn
2012-10-30 22:12:57 -03:00
Brian Fraser
cb3fb74082
Fix for 1045317: Added a --statistics option to pt-osc
2012-10-30 21:45:52 -03:00
Daniel Nichter
376572e637
Merge fix-995896-cat-in-daemon
2012-10-30 17:04:22 -06:00
Daniel Nichter
4ceecaf929
Update Daemon.pm in all tools.
2012-10-30 16:59:36 -06:00
Daniel Nichter
3d38ad0672
Remove doc example that doesn't exist.
2012-10-30 16:19:23 -06:00
Brian Fraser
ad4d69b3e2
Removed local $EVAL_ERROR, added a test using t/lib/samples/broken_tbl.frm, and updated all modules
2012-10-30 19:02:03 -03:00
Brian Fraser
35f5f8d1e4
Fix for 1047335: SchemaIterator fails when it encounters a crashed table
2012-10-30 18:35:49 -03:00
Brian Fraser
22f20c524f
Remove the use of local $EVAL_ERROR in ptc
2012-10-30 17:58:09 -03:00
Brian Fraser
9424ff7003
Removed a spurious change in the previous commit
2012-10-30 16:12:02 -03:00
Brian Fraser
d5a3a6e59c
Update per Daniel's comments & some minor fixes
2012-10-30 15:15:38 -03:00
Brian Fraser fraserb@gmail.com
6e3d3e6c96
Removed optional_value, made --version-check have default: off, updated the tools and documentation with the changes, and added the auto value to Pingback.pm
2012-10-30 12:42:42 -03:00
Brian Fraser fraserb@gmail.com
19f55542a2
Fix for 1059732: pt-table-checksum doesn't test all hash functions
2012-10-30 12:38:31 -03:00
Brian Fraser fraserb@gmail.com
1e3cc6131c
Fix for 938660: pt-table-checksum chunk-size-limit of 0 does not disable chunk size limit checking
2012-10-30 11:55:49 -03:00
Brian Fraser fraserb@gmail.com
fcf5fbcc6f
Fix for 1068562: pt-online-schema-change loses data when renaming columns
2012-10-30 11:50:13 -03:00
Daniel Nichter
45ae32ceb2
Presume STATEMENT binlog format if < 5.1.5 and still check other slaves in case they're newer versions of MySQL.
2012-10-26 17:06:21 -06:00
Daniel Nichter
302cb7f457
Don't check binlog_format on slaves ! >= 5.1.5.
2012-10-26 16:24:33 -06:00
Daniel Nichter
467d0ca7b1
Add deprecation notice to pt-log-player for PT 2.2.
2012-10-25 15:10:00 -06:00
Daniel Nichter
bb44887615
Update collect_mysql_info in pt-mysql-summary.
2012-10-24 12:45:10 -06:00
Daniel Nichter
aacdd9db17
Rewrite find_my_cnf_file() so if a port is given only that port's cnf is returned, else nothing.
2012-10-24 11:17:34 -06:00
Daniel Nichter
f6527695b8
Document extra --run-time-related waits.
2012-10-23 18:21:23 -06:00
Daniel Nichter
8ef6ee451f
Wait for collectors before exiting. Use wait_until instead of sleep in pt-stalk.t, and add lots of diag info when tests fail.
2012-10-23 14:42:41 -06:00
Daniel Nichter
b406f02f5b
Test and fix deadlock parsing with partition info.
2012-10-22 15:30:29 -06:00
Brian Fraser fraserb@gmail.com
4a22e1e545
Fix for 1052722: pt-fifo-split is processing n-1 rows initially
2012-10-22 18:04:38 -03:00
Daniel Nichter
3e39ab54b8
Make pt-osc --quiet disable --progress.
2012-10-22 14:23:05 -06:00
Daniel Nichter
0d4d008f79
Update OptionParser in all tools.
2012-10-22 12:17:08 -06:00
Daniel Nichter
e9c24579bf
Merge fix-pt-osc-del-trg-bug-1062324.
2012-10-22 11:34:52 -06:00
Daniel Nichter
575c94b29e
Add --default-engine to pt-osc.
2012-10-22 08:44:44 -06:00
Daniel Nichter
4a494d1a20
Remove all_privs tests. Update Percona::Toolkit::VERSION.
2012-10-20 17:59:28 -06:00
Daniel Nichter
ca2675dd98
Merge fix-978133-remove-pqd-priv-checks
2012-10-19 17:17:56 -06:00
Daniel Nichter
f50d8e9120
Remove TableParser::check_table() privs check (re bug 1036747).
2012-10-19 17:14:07 -06:00
Daniel Nichter
a3d5f3d346
Add hint to error messages about what to do if the table doesn't exist.
2012-10-19 17:10:40 -06:00
Daniel Nichter
e32289ae0c
Merge fix-938068-ptc-slave-binlog-formats
2012-10-19 17:01:15 -06:00
Daniel Nichter
d7bfcc8fd9
Tweak warning. Enhance docu around --check-binlog-format.
2012-10-19 16:57:53 -06:00
