Sveta Smirnova
2b350d908e
PT-2250 - pt-table-checksum reports error if recursion method is DSN
...
- We are now setting parent to current source server in get_cxn_from_dsn_table
2025-11-25 17:00:12 +03:00
Sveta Smirnova
247bc246fb
Merge pull request #1013 from percona/PMM-11406-percona-toolkit-update
...
PMM-11406 Better check to prevent errors from missing fields.
2025-11-12 21:41:55 +03:00
Jiří Čtvrtka
7a26991fb3
PMM-11406 Another typo.
2025-10-02 13:44:30 +02:00
Jiří Čtvrtka
d016effd18
PMM-11406 Fix typos in repo.
2025-10-02 13:39:09 +02:00
Sveta Smirnova
64ced79f7d
Merge pull request #1005 from percona/PT-2289_Allow_pt-stalk_do_disable_ps-lock-transactions_data_collection_via_parameter
...
Pt 2289 allow pt stalk do disable ps lock transactions data collection via parameter
2025-09-16 13:40:22 +03:00
Sveta Smirnova
bfeaa98379
PT-2289 - Allow pt-stalk do disable ps-lock-transactions data collection via parameter
...
- Fixed typo found during review
2025-09-10 18:19:03 +03:00
Sveta Smirnova
2ac8385d2d
Merge pull request #1012 from nilnandan/PT-2014-pt-config-diff_does_not_honor_case_insensitivity_flag
...
PT-2014 - Updated MySQLConfigComparer.pm so now it can honor case insensitivity…
2025-09-10 18:16:33 +03:00
Sveta Smirnova
f550652dbf
PT-2014 - pt-config-diff does not honor case insensitivity flag
...
- Fixed the proposed fix
- Fixed proposed configuration files
- Added test case
2025-09-09 19:25:13 +03:00
nilnandan
4e190a34ef
Updated MySQLConfigComparer.pm so now it can honor case insensitivity. cnf1 and cnf2 are test files.
2025-09-08 14:12:12 +00:00
Sveta Smirnova
cdc24c10f0
PT-2289 - Allow pt-stalk do disable ps-lock-transactions data collection via parameter
...
- Implemented _should_skip function as was suggested
2025-09-05 16:08:43 +03:00
Sveta Smirnova
66d20ae6da
PT-2289 - Allow pt-stalk do disable ps-lock-transactions data collection via parameter
...
- Adjusted the implementation
- Created test cases
2025-09-03 00:41:06 +03:00
Sveta Smirnova
2b5ceb9fee
Merge pull request #1002 from Shopify/PT-2015_fix_comparing_unsorted_flags
...
PT-2015 Fix pt-config-diff not sorting flags
2025-09-02 14:56:24 +03:00
Sveta Smirnova
68a4540a3d
PT-2289 - Allow pt-stalk do disable ps-lock-transactions data collection via parameter
...
- Implemented feature
- Started working on the test
2025-09-01 18:17:04 +03:00
Sveta Smirnova
0d0e7210f7
PT-2322 - pt-mysql-summary does not detect jemalloc.
...
- Added fix and test case. Fix checks for end of word (space or newline) instead of space.
2025-08-29 15:09:12 +03:00
Hartley McGuire
47f7638d60
PT-2015 Fix pt-config-diff not sorting flags
...
Previously, flags would be compared in the exact order they are output
by MySQL, which can result in false negatives if the input ordering does
not match.
Example from the ticket:
```
[root@avvr-dbm51 ~]# pt-config-diff /etc/my.cnf h=localhost,P=3047
1 config difference
Variable /etc/my.cnf avvr-dbm51
========================= ============ ============
myisam_recover_options FORCE,BACKUP BACKUP,FORCE
```
This commit fixes the issue by sorting the flags before comparison to
ensure that any ordering differences will not report a diff.
Co-authored-by: Jonathan Gnagy <jonathan@therubyist.org >
2025-08-27 16:12:27 +00:00
Sveta Smirnova
6854715795
Merge pull request #891 from ehooi/PT-2401
...
PT-2401 - remove check to fix the 'table does not exist' problem when lower_case_table_names=2 is set
2025-08-26 19:44:15 +03:00
Sveta Smirnova
495869da3e
PT-2440 - Support for MariaDB 10.5
...
- Updated non-libraries code in bin/pt-heartbeat, bin/pt-replica-restart, and bin/pt-slave-delay
- Adjusted lib/Sandbox.pm, so it does not require SSL for MariaDB
- Adjusted test case, so it is in line with other tests
2025-08-23 03:32:33 +03:00
Nyele93
a97c422851
PT-2465 patch fix for erroneous flavour mismatch in mariadb-10.5.x and above. This patch includes the fixed regex for checking DB flavour to include the case-insensitive marker i on the searches for MariaDB
2025-08-18 17:42:10 +03:00
Sveta Smirnova
3d0c0c623f
Merge branch '3.x' into HEAD
2025-08-15 17:18:09 +03:00
Sveta Smirnova
75feef2f96
PT-2401 - pt-online-schema-change 'table does not exist' on macos
...
- Modified code, so it still checks table name but based on the lower_case_table_names option
2025-08-15 17:16:37 +03:00
Sveta Smirnova
734d6231c2
PT-2052 - Tools should default to unbuffered stdout/stderr
...
- Added option --[no]buffer-stdout, enabled by default
2025-08-05 18:24:01 +03:00
nilnandan
6588510632
PT-1718 - Have pt-stalk collect performance_schema.threads along with information_schema.processlist
...
- Update collect.sh file and add code for collecting threads details.
- Add PT-1718-threads.t test file for testing this fix.
2025-07-30 14:11:43 +00:00
Marek Knappe
6c9ed6ed5b
Changed optionparser to allow for default: no to be false and run update-modules #PT-2457
2025-06-25 10:58:43 +10:00
Sveta Smirnova
d5d39a83fa
Merge pull request #890 from dbnski/long-variable-values
...
pt-config-diff: MySQL truncates run-time variable values longer than 1024 characters
2025-06-22 15:53:09 +03:00
Maciej Dobrzanski
55f2167ed0
- Updated MySQLConfig.pm to correctly support very long variable values
...
- Added test cases for pt-config-diff
2025-06-06 20:39:24 +02:00
Taehyung Lim
5989d2883c
remove check to fix the 'table does not exist' problem when lower_case_table_names=2 is set
2025-05-19 20:09:04 +09:00
Sveta Smirnova
ef2dbd887f
PT-2129 - pt-online-schem-change and other tools fail on non-readable version check file
...
- Implemented fix in lib/VersionCheck.pm
- Updated modules in all tools
- Added test case to t/pt-query-digest/version_check.t
2025-03-29 23:22:44 +03:00
Sveta Smirnova
5a4bd2f1da
Merge pull request #910 from percona/typos_2025_01
...
Fixed typos found by the GitHub workflow
2025-01-14 18:10:12 +03:00
Sveta Smirnova
6f62b4dc63
Merge pull request #907 from percona/remove_unused_variable_force_concat_enums
...
Remove unused variable force_concat_enums
2025-01-14 18:08:33 +03:00
Sveta Smirnova
0a98a81370
Merge pull request #863 from hpoettker/PT-2378_table_sync_with_more_fp_precision
...
PT-2378 - extended FP precision in pt-table-sync
2025-01-14 18:06:55 +03:00
Sveta Smirnova
f837672d1d
Merge pull request #861 from hpoettker/PT-2377_table_sync_with_utf8_json
...
PT-2377 - fixed pt-table-sync for JSON utf8 strings
2025-01-14 18:04:41 +03:00
Henning Poettker
1e581be06a
PT-2378 - extended FP precision in pt-table-sync
...
pt-table-sync now uses up to 17 decimal digits when writing
floating point numbers in the generated SQL statements.
This is necessary to prevent unintended data changes.
2025-01-13 09:31:51 +01:00
Sveta Smirnova
3e69100477
Fixed typos found by the GitHub workflow
2025-01-10 23:07:03 +03:00
Sveta Smirnova
1bec1fdde8
Remove unused variable force_concat_enums
...
- Removed variable
- Adjusted utils/update-modules, so it does not process symlinks
2024-12-31 20:14:16 +03:00
Sveta Smirnova
ce20bc7dd1
Merge pull request #860 from hpoettker/PT-2375_table_sync_with_generated_columns
...
PT-2375 - fixed pt-table-sync for tables with generated columns
2024-12-27 18:08:08 +03:00
Henning Poettker
16b06dcfc2
PT-2377 - fixed pt-table-sync for JSON utf8 strings
...
The MySQL driver DBD::mysql does not decode JSON values as utf8
although MySQL uses utf8mb4 for all JSON strings.
This change decodes JSON values as utf8 (when not already done)
such that SQL statements are generated correctly.
2024-12-27 13:46:55 +01:00
Sveta Smirnova
02ada0ddc9
Release 3.7.0
...
- Updated version
2024-12-19 18:41:01 +03:00
Artem Gavrilov
c4260e5d7a
Fix typos
2024-12-18 16:11:27 +02:00
Henning Poettker
5f14441d19
PT-2375 - fixed pt-table-sync for tables with generated columns
...
Previously, pt-table-sync generated DML statements that included
the generated columns of a table, which is however rejected by
the database and not necessary for the required sync statements.
2024-11-14 23:51:40 +01:00
Sveta Smirnova
8b802722db
PT-2340 - Support MySQL 8.4
...
- Adjusted tools and tests which fail due to fixed update-modules command
- Adjsted t/pt-table-checksum/basics.t test for 8.0
2024-11-13 21:23:39 +03:00
Sveta Smirnova
bb66ab0845
PT-2340 - Support MySQL 8.4
...
- Implemented functions get_replica_name and get_source_name in lib/MasterSlave.pm I did not implement similar functions in other places, because they set other variables as well, not only replica_name or source_name.
2024-11-13 02:04:39 +03:00
Sveta Smirnova
a1093ff12c
PT-2340 - Support MySQL 8.4
...
- s/slave lag/replica lag/ in tests
- reverted rename of COM_REGISTER_SLAVE to COM_REGISTER_REPLICA, because the constant still named COM_REGISTER_SLAVE in 8.4
- removed some slave leftovers from pt-replica-find
2024-11-12 15:18:36 +03:00
Sveta Smirnova
86fe021434
PT-2340 - Support MySQL 8.4
...
- Updated modules
2024-10-04 19:06:01 +03:00
Sveta Smirnova
fcb2d549b8
PT-2340 - Support MySQL 8.4
...
- Adjusted pt-variable-advisor, so it reflects current defaults
2024-10-04 19:02:07 +03:00
Sveta Smirnova
33086769a1
PT-2340 - Support MySQL 8.4
...
- Added test for replica lag check for pt-archiver
- Re-added deprecated slave- options
- Added tests for deprecation warnings and for legacy options for pt-archiver
- Removed practically not supported options --replica-user and --replica-password from pt-archiver, pt-kill, pt-query-digest
- Added legacy source/replica options (master/slave) variants and tests for pt-heartbeat, pt-online-schema-change, pt-replica-find, pt-replica-restart, pt-table-checksum, pt-table-sync
- Updated modules after lib/MasterSlave.pm change
2024-10-04 18:27:00 +03:00
Sveta Smirnova
ea6bd77501
PT-2340 - Support MySQL 8.4
...
- Moved data collection for THP from lib/bash/report_system_info.sh to lib/bash/collect_system_info.sh, so pt-summary reports THP status on the machine where samples were collected, not on the machine where an engineer examines samples.
2024-09-06 13:08:45 +03:00
Sveta Smirnova
d03bd604a1
PT-2340 - Support MySQL 8.4
...
- Fixed typos
- Added tests for MyRocks and TokuDB clustered indexes into t/pt-duplicate-key-checker/clustered_keys.t
- Updated modules
2024-09-04 18:32:58 +03:00
Sveta Smirnova
94bcfd2b69
PT-2340 - Support MySQL 8.4
...
- Updated documentation
2024-09-03 20:05:26 +03:00
Sveta Smirnova
e3e352d1d6
PT-2340 - Support MySQL 8.4
...
- Fixed comparison operators for VersionCheck calls
2024-08-27 13:45:37 +03:00
Sveta Smirnova
1006101bb4
PT-2340 - Support MySQL 8.4
...
- Added deprecation warning to pt-slave-delay
- Re-enabled tests for pt-slave-delay to check the warning
- Disabled pt-slave-delay for MySQL 8.1+
2024-08-26 22:26:09 +03:00