Commit Graph

1911 Commits

Author SHA1 Message Date
Sveta Smirnova 19aa46d1a5 PT-1052 include numa information in pt tool output (#547)
* PT-1052: fix for pt-summary

* Re-added fix from commit 71fae6d117 into proper place: library directory
Added tests for PT-1052 (pt-summary only)

* Fixed tests for pt-summary,
set locale for pt-summary tests, so they are not affected by user environment.
Finished tests for PT-1052

* Added fix for PT-1983 into the proper place: library file

* PT-1052: fix for pt-stalk which now includes numastat data
2022-08-15 15:45:24 +03:00
Sveta Smirnova ac3843bcb7 Pt 1897 lock information in8.0 in pt stalk (#544)
* PT-1897 pt-stalk on MySQL 8 not collecting lock information

For version prior 8.0 pt-stalk continue using Information Schema INNODB_LOCKS and INNODB_LOCK_WAITS tables for collecting lock information.
For version 8.0 and higher pt-stalk uses tables data_locks and data_lock_waits in Performance Schema

* PT-1897 - Better MariaDB support

We cannot simply compare version number with 8.0 to identify if lock tables are in Performance Schema,
because MariaDB 10.x still have them in the Information Schema.
Therefore added additional flag, indicating which syntax we should use

* Tests for PT-1897
2022-07-25 10:01:14 -03:00
Sveta Smirnova 8ebc9534c6 Pt 2075 fix tests for pt stalk (#541)
* Added mysql.proxies_priv to list of exceptions from checks in Sandbox.pm

* Fixed test for slave_status for 5.7+
2022-07-11 15:55:16 +03:00
Sveta Smirnova 22ed941238 PT-1218: pt-stalk ominous open_tables function (#535)
After discussion change only affects error message that is more user-friendly now.
I also added two tests that check how open_tables function works in both cases:
with number of open tables less tha 1000 and greater than 1000
2022-03-22 09:33:05 -03:00
svetasmirnova 3767e57e15 PT-2037 - added test for the situation when both --system-only and --mysql-only are specified 2022-01-27 19:21:04 +03:00
svetasmirnova 623fdaec91 PT-2037 - option --system-only for pt-stalk
This commit:
1. Moves all changes to the proper place: lib/bash/collect.sh
2. Refactors pt-stalk so it is more modular
3. Places fix for PT-1734 into the right place: lib/bash/collect.sh
4. Fixes tests for PT-1336
2022-01-22 21:21:05 +03:00
svetasmirnova 1f6c95f524 PT-2037 - reviewer suggestions
Refactoring pt-stalk to make it easier to call system and MySQL data collections separately
2022-01-21 04:12:43 +03:00
svetasmirnova d6e899404e PT-2037 Option --system-only for pt-stalk
Option --system-only triggers only operating system related captures, ignoring all others.
2022-01-19 18:41:05 +03:00
Sveta Smirnova b2860eee31 PT-1336 pt-stalk removes user files from destination (#524)
* PT-1336 Added file name checks and -maxdepth 1 parameter

* PT-1336 pt-stalk removes user files from the destination directory

* Added check that files to be removed were created by pt-stalk

* Added option -maxdepth 1 to find command, so the tool does not search for files in the nested directories

* Added unit tests

* This should fix PT-1812 also
2021-12-10 09:18:18 -03:00
Carlos Salguero c5a22407a7 PT-2016 pt-table-sync and CRC32 columns (#521)
* PT-2016 CRC32 on key

* PT-2016 Added tests

* Removed commented out line
2021-11-03 13:53:30 -03:00
Carlos Salguero 0d2c48456f PT-1627 Improve pt-mysql-summary jemalloc detection (#514)
* PT-1627 Changed jemalloc detection function

* Updated Tests
2021-10-01 09:19:25 -03:00
Carlos Salguero 9d6508da5f PT-1900 pt-query-digest not hiding parameter properly sometimes when parameter=binary (#510)
* PT-1900 WIP

* Fixed quoted strings regexes

* PT-1900 Fixed query rewriter to properly handle quoted text

* Fixed merge conflicts with 3.x branch
2021-09-27 08:23:23 -03:00
Sergey Kuzmichev ad593c6de9 Fix for PT-1983: pt-summary has missing records for memory due to dmidecode changes (#513)
* Fix for PT-1983 pt-summary missing one DIMM

This is a fix for PT-1983. dmidecode now doesn't print "Speed: UKNOWN" for
missing DIMMs. pt-summary code relies on the Speed field to be there, and when
it's missing, rows get concatenated (or rather not broken down correctly).
Adjusted the relevant code to not rely on the Speed field to be present.

* Added test for the fix for PT-1983

Due to dmidecode changes in 3.2, pt-summary needs to be able to work
with memory-related info with some missing fields in the dmidecode
output. This commit adds a test with dmidecode output modified to
include new format.

In addition, fixing test that are failing due to commit c9ec74c251

* PT-1983: updated changelog to reflect the bug fixed
2021-09-08 07:32:30 -03:00
Carlos Salguero ecf43e2a17 PT-1985 pt-deadlock db schema check (#502) 2021-07-29 12:15:53 -03:00
Carlos Salguero 543f30c073 PT-1986 Check schema exists upon start (#503) 2021-07-29 12:15:23 -03:00
yoku0825 dcf237ef8c Fix test PT-1966 (#493)
* Detect raising error for PT-1966

* Fix non-duplicated column name for PT-1966

* More good way to catch an error. (PT-1966)

- https://github.com/percona/percona-toolkit/pull/493#pullrequestreview-678426876

* Add Changelog (PT-1966)

- https://github.com/percona/percona-toolkit/pull/493
2021-06-17 10:28:54 -03:00
Carlos Salguero 0b97e1f471 PT-1747 pt-online-schema-change was bringing the database into a broken state (#491)
* PT-1717 Updated behavior for FKs

* Fixed rename_columns.t

* Fixed pt-244.t

* fixed drop swap test

* Fixed test for MySQL 8.0

* Updated test for MySQL 8

* Updated test for MySQL 8
2021-06-03 12:00:43 -03:00
Carlos Salguero e570cecbab PT-1914 Column data lost when 'Generated' is in the column comment (#482)
* PMM-1914 Fixed column parsing having generated

Fixed table parser code that errouneously considered a column as
generated when the default was empty DEFAULT '' and the COMMENT had
the word 'Generated'.

* PMM-1914 Updated TableParser in all programs

* PT-1914 Updated changelog

* PT-1914 Added test
2021-03-09 11:46:05 -03:00
Carlos Salguero 4f78d5450c PT-1919 drop-swap can drop triggers (#483)
* PT-1919 drop-swap can drop triggers

* PT-1919 Update changelog
2021-03-05 11:32:03 -03:00
Carlos Salguero 9ef2b56f4d PT-1905 Reverse triggers (#477)
* PT-1905 Reverse triggers

* WIP

* PT-1905 Updated reverse triggers creation

* PT-1905 Fixed trigger creation
2021-01-12 13:58:34 -03:00
Carlos Salguero 71c9902532 PT-1898 pt archiver keeps transaction open (#479)
* PT-1898 WIP

* PT-1898 Added commit for open txns

* PT-1898 Added commit for open txns

* PT-1898 removed dev leftover
2021-01-12 13:40:51 -03:00
Carlos Salguero e1b7a6a1fd PT-1857 heartbeat can't reconnect (#475)
* PT-1857 pt-heartbeat reconnect

* PT-1857 Updated changelog
2020-12-24 16:23:42 -03:00
Carlos Salguero 2233224ff6 PT-1528 pt-online-schema-change "Invalid utf8mb4 character string (#473)
* PT-1528 [WIP] Proposed solution

* PT-1528 Ingore UTF8 warning
2020-12-24 16:22:46 -03:00
Carlos Salguero b716d128c0 PT-1908 Increased query id column size in report (#472) 2020-11-17 12:09:19 -03:00
Carlos Salguero d7a7a1c7a5 PT-169 Handle drop-swap errors in pt-online-schema-change (#467)
* PT-169 Fixed drop-swap error handling

* PT-169 Fixed drop_swap error handling
2020-10-12 15:36:45 -03:00
Mateus Dubiela Oliveira d6ada6a7bf PT-1869: Enable slave list reloading (#456)
* PT-1869: Enable slave list reloading

* PT-1869: Fix pt-osc/slave_lag sample sizes for more consistent testing results

* PT-1869: Move slaves_to_skip to get_slaves_cb
2020-08-12 11:30:56 -03:00
Carlos 8ff3451362 PT-1853 Changed wording 2020-06-30 20:54:08 -03:00
Carlos 9f2b72e0df PT-1853 Added disable fk checks in MySQL 2020-06-30 20:09:39 -03:00
Carlos Salguero c6b4bd747e PT-1852 Added --no-check-foreing-keys to pt-osc 2020-06-21 18:53:47 -03:00
Carlos Salguero 6dbf807dfa Fixed Fk tests 2020-04-16 16:12:40 -03:00
Carlos Salguero 208fb86586 Revert "Merge pull request #427 from percona/PT-1747"
This reverts commit 25b637d4bd, reversing
changes made to 38c169031e.
2020-04-03 14:40:35 -03:00
Carlos Salguero 54f90e4bdf PT-1802 WIP 2020-04-02 09:57:45 -03:00
Carlos Salguero 45522dea28 Renamed dubious tests 2020-04-01 15:39:16 -03:00
Carlos Salguero b5a593dc16 Updated TableNibbler 2020-03-31 13:19:26 -03:00
Carlos Salguero fc631efb32 Fixed long_fk_constraints.t 2020-03-31 11:27:04 -03:00
Carlos Salguero a3ab87b12e Fixed pt-archiver tests 2020-03-30 14:57:02 -03:00
Carlos Salguero f0ee14d479 WIP 2020-03-30 08:21:05 -03:00
Carlos Salguero 2821b847b3 PT-1766 Fixed DIFF_ROWS calculation
- Fixed DIFF_ROWS calculation
- Removed unused param --force-concat-enums
2019-12-23 08:42:38 -03:00
Carlos Salguero e97d80cde0 PT-1747 Updated MySQL version check 2019-11-26 10:04:56 -03:00
Carlos Salguero 53213e0582 Merge branch '3.0' into PT-1707 2019-10-29 08:57:38 -03:00
Carlos Salguero e656274493 PT-1707 Updated DSNParser in all apps 2019-10-29 08:53:26 -03:00
Carlos Salguero 0c50d8f708 Merge pull request #420 from percona/PT-1760
PT-1760 regression on slave with replication channels
2019-10-15 19:02:36 -03:00
Carlos Salguero 13f7afc49d PT-1757 Fixed NibbleIterator undef 2019-10-14 14:44:57 -03:00
Carlos Salguero 6a302e2b07 PT-1757 Implemented fallback in NibbleIterator
Since now NibbleIterator can fallback to nibble (from one chunk) pt-osc
can nibble tables even if due to unacurate stats, it choses one nible as
the initial nibbling method.
2019-10-13 21:58:56 -03:00
Carlos Salguero a6e0b0d324 WIP 2019-10-08 13:10:26 -03:00
Carlos Salguero 605b97959c PT-1760 DSN parser overrides values if F= was specified 2019-10-01 11:20:18 -03:00
Carlos Salguero 522f8c5821 PT-1760 Updated DSNParser module 2019-10-01 08:26:42 -03:00
Carlos Salguero 9ed892692a PT-297 removed debug code 2019-09-20 13:50:44 -03:00
Carlos Salguero 10fe056242 WIP 2019-09-19 14:29:55 -03:00
Carlos Salguero ed6ebcedbd Updated changelog and tests 2019-09-06 06:25:52 -03:00