percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-11 21:51:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

PT-1485 pt-mysql-summary has broken Security section in versions bigger then 5.6

Browse Source
This commit is contained in:
Carlos Salguero
2018-02-26 12:47:48 -03:00
parent 3fbdcfdf14
commit f5ef9d28c5
3 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog
View File

@@ -6,6 +6,7 @@ v3.0.7
* Feature PT-633 : Added --mysql-only option to pt-stalk for RDS * Feature PT-633 : Added --mysql-only option to pt-stalk for RDS
* Fixed bug PT-1256: pt-table-sync does not use the character set for the table it is synchronizing * Fixed bug PT-1256: pt-table-sync does not use the character set for the table it is synchronizing
* Fixed bug PT-1455: pt-osc is stuck when the table that is being altered is filtered out in the slave * Fixed bug PT-1455: pt-osc is stuck when the table that is being altered is filtered out in the slave
* Fixed bug PT-1485: pt-mysql-summary has broken Security section in versions bigger then 5.6
* Fixed bug PMM-1905: Explain fails if encounters negative "ntoreturn" * Fixed bug PMM-1905: Explain fails if encounters negative "ntoreturn"
v3.0.6 released 2017-12-20 v3.0.6 released 2017-12-20

5
bin/pt-mysql-summary
View File

@@ -927,6 +927,9 @@ collect_mysql_processlist () {
collect_mysql_users () { collect_mysql_users () {
$CMD_MYSQL $EXT_ARGV -ss -e 'SELECT COUNT(*), SUM(user=""), SUM(password=""), SUM(password NOT LIKE "*%") FROM mysql.user' 2>/dev/null $CMD_MYSQL $EXT_ARGV -ss -e 'SELECT COUNT(*), SUM(user=""), SUM(password=""), SUM(password NOT LIKE "*%") FROM mysql.user' 2>/dev/null
if [ "$?" -ne 0 ]; then
$CMD_MYSQL $EXT_ARGV -ss -e 'SELECT COUNT(*), SUM(user=""), SUM(authentication_string=""), SUM(authentication_string NOT LIKE "*%") FROM mysql.user' 2>/dev/null
fi
} }
collect_mysql_show_slave_hosts () { collect_mysql_show_slave_hosts () {
@@ -2195,7 +2198,7 @@ report_jemalloc_enabled() {
local JEMALLOC_LOCATION='' local JEMALLOC_LOCATION=''
for PID in $(pidof mysqld); do for PID in $(pidof mysqld); do
grep -qc jemalloc /proc/${PID}/environ || ldd $(which mysqld) | grep -qc jemalloc grep -qc jemalloc /proc/${PID}/environ || ldd $(which mysqld) 2>/dev/null | grep -qc jemalloc
JEMALLOC_STATUS=$? JEMALLOC_STATUS=$?
if [ $JEMALLOC_STATUS = 1 ]; then if [ $JEMALLOC_STATUS = 1 ]; then
echo "jemalloc is not enabled in MySQL config for process with ID ${PID}" echo "jemalloc is not enabled in MySQL config for process with ID ${PID}"

5
t/pt-mysql-summary/pt-mysql-summary.t
View File

@@ -66,6 +66,11 @@ like(
"InnoDB section present" "InnoDB section present"
); );
like(
$out,
qr/Users \| 2/,
"Security works"
);
# --read-samples # --read-samples
for my $i (2..7) { for my $i (2..7) {