PT-2014 - pt-config-diff does not honor case insensitivity flag

- Fixed the proposed fix
- Fixed proposed configuration files
- Added test case

bin/pt-config-diff

@@ -3696,7 +3696,7 @@ sub _normalize_value {
    my ($val, $is_dir, $base_path) = @args{qw(value is_directory base_path)};
 
    $val = defined $val ? $val : '';
-   $val = $alt_val_for{lc($val)} if exists $alt_val_for{lc($val)};
+   $val = $alt_val_for{uc($val)} if exists $alt_val_for{uc($val)};
 
    if ( $val ) {
       if ( $is_dir ) {

lib/MySQLConfigComparer.pm

@@ -294,7 +294,7 @@ sub _normalize_value {
    my ($val, $is_dir, $base_path) = @args{qw(value is_directory base_path)};
 
    $val = defined $val ? $val : '';
-   $val = $alt_val_for{lc($val)} if exists $alt_val_for{lc($val)};
+   $val = $alt_val_for{uc($val)} if exists $alt_val_for{uc($val)};
 
    if ( $val ) {
       if ( $is_dir ) {

t/lib/MySQLConfigComparer.t

@@ -425,6 +425,30 @@ is_deeply(
    "..but can be turned off"
 );
 
+# ############################################################################
+# https://perconadev.atlassian.net/browse/PT-2014
+# pt-config-diff does not honor case insensitivity flag for boolean values
+# ############################################################################
+$c1 = new MySQLConfig(
+   file                => "$trunk/$sample/pt-2014-1.txt",
+   TextResultSetParser => $trp,
+);
+$c2 = new MySQLConfig(
+   file                => "$trunk/$sample/pt-2014-2.txt",
+   TextResultSetParser => $trp,
+);
+{
+    my $diff = $cc->diff(
+      configs => [$c1, $c2],
+    );
+
+    is_deeply(
+        $diff,
+        undef,
+        "Boolean values are the same regardless of the case"
+    ) or diag(Dumper($diff));
+}
+
 # #############################################################################
 # Done.
 # #############################################################################

t/lib/samples/configs/pt-2014-1.txt

@@ -2,8 +2,6 @@
 log_bin=1
 gtid_mode=on
 read_only=off
-autocommit=yes
 autocommit=no
 binlog_format=mixed
 skip_name_resolve=true
-skip_name_resolve=false

t/lib/samples/configs/pt-2014-2.txt

@@ -0,0 +1,7 @@
+[mysqld]
+log_bin=on
+gtid_mode=True
+read_only=FALSE
+autocommit=0
+binlog_format=MIXED
+skip_name_resolve=TRUE

t/pt-config-diff/samples/cnf2

@@ -1,9 +0,0 @@
-[mysqld]
-LOGBIN=1
-gtid_mode=ON
-read_only=OFF
-autocommit=YES
-autocommit=NO
-binlog_format=MIXED
-skip_name_resolve=TRUE
-skip_name_resolve=FALSE