Fix and test read-only handling in QueryIterator.

bin/pt-upgrade

@@ -5271,7 +5271,7 @@ sub next {
       }
 
       if ( $self->read_only ) {
-         if ( $event->{arg} !~ m/(?:^SELECT|(?:\*\/\s*SELECT))/i ) {
+         if ( $event->{arg} !~ m{^(?:/\*[^!].*?\*/)?\s*(?:SELECT|SET)}i ) {
             PTDEBUG && _d('Skipping non-SELECT query');
             $self->stats->{not_select}++;
             next EVENT;

lib/QueryIterator.pm

@@ -215,7 +215,7 @@ sub next {
       }
 
       if ( $self->read_only ) {
-         if ( $event->{arg} !~ m/(?:^SELECT|(?:\*\/\s*SELECT))/i ) {
+         if ( $event->{arg} !~ m{^(?:/\*[^!].*?\*/)?\s*(?:SELECT|SET)}i ) {
             PTDEBUG && _d('Skipping non-SELECT query');
             $self->stats->{not_select}++;
             next EVENT;

t/lib/QueryIterator.t

@@ -10,39 +10,31 @@ use strict;
 use warnings FATAL => 'all';
 use English qw(-no_match_vars);
 use Test::More;
-use Data::Dumper;
 
-use FileIterator;
 use QueryRewriter;
+use FileIterator;
 use QueryIterator;
-use SlowLogParser;
+use RawLogParser;
 use PerconaTest;
 
-my $parser    = SlowLogParser->new();
+use constant PTDEBUG => $ENV{PTDEBUG} || 0;
-my $qr        = QueryRewriter->new();
-my $file_iter = FileIterator->new();
 
-my $oktorun = 1;
+use Data::Dumper;
-my $sample  = "t/lib/samples/slowlogs";
+$Data::Dumper::Indent    = 1;
+$Data::Dumper::Sortkeys  = 1;
+$Data::Dumper::Quotekeys = 0;
+
+my $sample = "$trunk/t/lib/samples/";
+
+my $file_iter = FileIterator->new();
+my $parser    = RawLogParser->new();
+my $qr        = QueryRewriter->new();
+my $query_iter;
 
 sub test_query_iter {
    my (%args) = @_;
-
+   my $file = $args{file};
-   my $files = $file_iter->get_file_itr(
+   my $name = $args{name};
-      @{$args{files}}
-   );
-
-   my $query_iter = QueryIterator->new(
-      file_iter   => $files,
-      parser      => $args{parser} || $parser,
-      fingerprint => sub { return $qr->fingerprint(@_) },
-      oktorun     => sub { return $oktorun },
-      # Optional args
-      default_database => $args{default_database},
-      ($args{filter}       ? (filter       => $args{filter})       : ()),
-      ($args{read_only}    ? (read_only    => $args{read_only})    : ()),
-      ($args{read_timeout} ? (read_timeout => $args{read_timeout}) : ()),
-   );
 
    my @events;
    while ( my $event = $query_iter->next() ) {
@@ -56,74 +48,37 @@ sub test_query_iter {
    ) or diag(Dumper(\@events));
 }
 
-my $slow001_events = [
+my $files = $file_iter->get_file_itr(
-   {
+   "$sample/rawlogs/rawlog002.txt",
-      Lock_time => '0',
+);
-      Query_time => '2',
-      Rows_examined => '0',
-      Rows_sent => '1',
-      arg => 'select sleep(2) from n',
-      bytes => 22,
-      cmd => 'Query',
-      db => 'test',
-      fingerprint => 'select sleep(?) from n',
-      host => 'localhost',
-      ip => '',
-      pos_in_log => 0,
-      ts => '071015 21:43:52',
-      user => 'root',
-   },
-   {
-      Lock_time => '0',
-      Query_time => '2',
-      Rows_examined => '0',
-      Rows_sent => '1',
-      arg => 'select sleep(2) from test.n',
-      bytes => 27,
-      cmd => 'Query',
-      db => 'sakila',
-      fingerprint => 'select sleep(?) from test.n',
-      host => 'localhost',
-      ip => '',
-      pos_in_log => 359,
-      ts => '071015 21:45:10',
-      user => 'root',
-   }
-];
 
-test_query_iter(
+$query_iter = QueryIterator->new(
-   name   => "slow001.txt, defaults",
+   file_iter   => $files,
-   files  => [
+   parser      => $parser,
-      "$trunk/$sample/slow001.txt"     
+   fingerprint => sub { return $qr->fingerprint(@_) },
-   ],
+   oktorun     => sub { return 1 },
-   expect => $slow001_events,
+   read_only   => 1,
 );
 
 test_query_iter(
-   name         => "slow001.txt, read_timeout=5",
+   name   => "rawlog002.txt read-only",
-   read_timeout => 5,
+   expect => [
-   files        => [
+      {  pos_in_log  => 0,
-      "$trunk/$sample/slow001.txt"     
+         arg         => 'SELECT c FROM t WHERE id=1',
-   ],
+         bytes       => 26,
-   expect => $slow001_events,
+         cmd         => 'Query',
-);
+         Query_time  => 0,
+         fingerprint => 'select c from t where id=?',
+      },
+      {  pos_in_log  => 27,
+         arg         => '/* Hello, world! */ SELECT * FROM t2 LIMIT 1',
+         bytes       => 44,
+         cmd         => 'Query',
+         Query_time  => 0,
+         fingerprint => 'select * from t? limit ?',
+      }
 
-test_query_iter(
-   name      => "slow001.txt, read_only",
-   read_only => 1,
-   files     => [
-      "$trunk/$sample/slow001.txt"     
    ],
-   expect => $slow001_events,
-);
-
-test_query_iter(
-   name   => "slow001.txt, in-line filter",
-   filter => '$event->{db} eq "test"',
-   files  => [
-      "$trunk/$sample/slow001.txt"     
-   ],
-   expect => [ $slow001_events->[0] ],
 );
 
 # #############################################################################

t/lib/samples/rawlogs/rawlog002.txt

@@ -0,0 +1,4 @@
+SELECT c FROM t WHERE id=1
+/* Hello, world! */ SELECT * FROM t2 LIMIT 1
+INSERT INTO t (a, b) VALUES ('foo', 'bar')
+INSERT INTO t SELECT * FROM monkeys