percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-12-19 01:09:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

PT-2424 - Typo in pt-table-checksum error message "--resume and --no-empty-replicate-table are mutually exclusive"

Browse Source 
- Fixed typo
- Added test case
This commit is contained in:
Sveta Smirnova
2025-03-27 21:09:10 +03:00
parent 25f4ee6d80
commit e964e17f21
2 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bin/pt-table-checksum
View File

@@ -10272,11 +10272,11 @@ sub main {
if ( $o->get('truncate-replicate-table') && $o->get('resume') ) { if ( $o->get('truncate-replicate-table') && $o->get('resume') ) {
die "--resume and truncate-replicate-table are mutually exclusive"; die "--resume and truncate-replicate-table are mutually exclusive";
} }
if ( $o->get('truncate-replicate-table') && !$o->get('empty-replicate-table') ) { if ( $o->get('truncate-replicate-table') && !$o->get('empty-replicate-table') ) {
die "--resume and --no-empty-replicate-table are mutually exclusive"; die "--truncate-replicate-table and --no-empty-replicate-table are mutually exclusive";
} }
# ######################################################################## # ########################################################################

23
t/pt-table-checksum/bugs.t
View File

@@ -378,6 +378,29 @@ is(
diag(`/tmp/12346/stop >/dev/null`); diag(`/tmp/12346/stop >/dev/null`);
diag(`/tmp/12346/start >/dev/null`); diag(`/tmp/12346/start >/dev/null`);
# #############################################################################
# typo in pt-table-checksum error message
# https://perconadev.atlassian.net/browse/PT-2424
# #############################################################################
$output = output(sub {
pt_table_checksum::main($source_dsn,
qw(--no-empty-replicate-table --truncate-replicate-table)
)},
stderr => 1,
);
unlike(
$output,
qr/--resume and --no-empty-replicate-table are mutually exclusive/,
"PT-2424: no typo in the error message"
);
like(
$output,
qr/--truncate-replicate-table and --no-empty-replicate-table are mutually exclusive/,
"PT-2424: correct error message"
);
# #
# ############################################################################# # #############################################################################