mirror of
https://github.com/percona/percona-toolkit.git
synced 2025-09-28 00:21:56 +00:00
Merge pt-osc-data-loss-bug-1068562
This commit is contained in:
Daniel Nichter
225
t/pt-online-schema-change/find_renamed_cols.t
Normal file
225
t/pt-online-schema-change/find_renamed_cols.t
Normal file
@@ -0,0 +1,225 @@
|
||||
#!/usr/bin/env perl
|
||||
|
||||
BEGIN {
|
||||
die "The PERCONA_TOOLKIT_BRANCH environment variable is not set.\n"
|
||||
unless $ENV{PERCONA_TOOLKIT_BRANCH} && -d $ENV{PERCONA_TOOLKIT_BRANCH};
|
||||
unshift @INC, "$ENV{PERCONA_TOOLKIT_BRANCH}/lib";
|
||||
};
|
||||
|
||||
use strict;
|
||||
use warnings FATAL => 'all';
|
||||
use English qw(-no_match_vars);
|
||||
use Test::More;
|
||||
|
||||
use Data::Dumper;
|
||||
use PerconaTest;
|
||||
|
||||
require "$trunk/bin/pt-online-schema-change";
|
||||
|
||||
my $q = Quoter->new;
|
||||
my $tp = TableParser->new(Quoter => $q);
|
||||
|
||||
sub test_func {
|
||||
my ($alter, $renamed_cols) = @_;
|
||||
die "No alter arg" unless $alter;
|
||||
die "No renamed_cols arg" unless $renamed_cols;
|
||||
(my $show_alter = $alter) =~ s/\n/\\n/g;
|
||||
|
||||
my %got_renamed_cols = eval {
|
||||
pt_online_schema_change::find_renamed_cols($alter, $tp);
|
||||
};
|
||||
if ( $EVAL_ERROR ) {
|
||||
is_deeply(
|
||||
undef,
|
||||
$renamed_cols,
|
||||
$show_alter,
|
||||
) or diag($EVAL_ERROR);
|
||||
}
|
||||
else {
|
||||
is_deeply(
|
||||
\%got_renamed_cols,
|
||||
$renamed_cols,
|
||||
$show_alter,
|
||||
) or diag(Dumper(\%got_renamed_cols));
|
||||
}
|
||||
}
|
||||
|
||||
# #############################################################################
|
||||
# Single column alters
|
||||
# #############################################################################
|
||||
|
||||
test_func(
|
||||
"change old_column_name new_column_name varchar(255) NULL",
|
||||
{
|
||||
old_column_name => 'new_column_name',
|
||||
},
|
||||
);
|
||||
|
||||
# Case-sensitive?
|
||||
test_func(
|
||||
"CHANGE old_column_name new_column_name VARCHAR(255) NULL",
|
||||
{
|
||||
old_column_name => 'new_column_name',
|
||||
},
|
||||
);
|
||||
|
||||
# Optional COLUMN?
|
||||
test_func(
|
||||
"CHANGE column old_column_name new_column_name VARCHAR(255) NULL",
|
||||
{
|
||||
old_column_name => 'new_column_name',
|
||||
},
|
||||
);
|
||||
|
||||
# Space-sensitive?
|
||||
test_func(
|
||||
"CHANGE a z VARCHAR(255) NULL",
|
||||
{
|
||||
a => 'z',
|
||||
},
|
||||
);
|
||||
|
||||
# Backtick-sensitive?
|
||||
test_func(
|
||||
"CHANGE `a` `z` VARCHAR(255) NULL",
|
||||
{
|
||||
a => 'z',
|
||||
},
|
||||
);
|
||||
|
||||
# Column named column?
|
||||
test_func(
|
||||
"CHANGE `column` new_column_name VARCHAR(255) NULL",
|
||||
{
|
||||
column => 'new_column_name',
|
||||
},
|
||||
);
|
||||
|
||||
|
||||
# Extended ascii?
|
||||
test_func(
|
||||
"CHANGE `café` `tête-à-tête` INT",
|
||||
{
|
||||
'café' => 'tête-à-tête',
|
||||
},
|
||||
);
|
||||
|
||||
# UTF-8?
|
||||
if( Test::Builder->VERSION < 2 ) {
|
||||
foreach my $method ( qw(output failure_output) ) {
|
||||
binmode Test::More->builder->$method(), ':encoding(UTF-8)';
|
||||
}
|
||||
}
|
||||
test_func(
|
||||
"CHANGE `\x{30cb}` `\x{30cd}` INT",
|
||||
{
|
||||
"\x{30cb}" => "\x{30cd}",
|
||||
},
|
||||
);
|
||||
# Mixed backtick-sensitive?
|
||||
test_func(
|
||||
"CHANGE `a` z VARCHAR(255) NULL",
|
||||
{
|
||||
a => 'z',
|
||||
},
|
||||
);
|
||||
|
||||
test_func(
|
||||
"CHANGE a `z` VARCHAR(255) NULL",
|
||||
{
|
||||
a => 'z',
|
||||
},
|
||||
);
|
||||
|
||||
# Ansi quotes-sensitive? (should matter)
|
||||
test_func(
|
||||
qq{CHANGE "a" "z" VARCHAR(255) NULL},
|
||||
{
|
||||
a => 'z',
|
||||
},
|
||||
);
|
||||
|
||||
# Embedded backticks?
|
||||
test_func(
|
||||
"CHANGE `a``a` z VARCHAR(255) NULL",
|
||||
{
|
||||
'a`a' => 'z',
|
||||
},
|
||||
);
|
||||
|
||||
# Emebedded spaces?
|
||||
test_func(
|
||||
"CHANGE `a yes ` z VARCHAR(255) NULL",
|
||||
{
|
||||
'a yes ' => 'z',
|
||||
},
|
||||
);
|
||||
|
||||
test_func(
|
||||
"CHANGE ` yes ` `\nyes!\na` VARCHAR(255) NULL",
|
||||
{
|
||||
' yes ' => "\nyes!\na",
|
||||
},
|
||||
);
|
||||
|
||||
test_func(
|
||||
"CHANGE ` yes ` `\nyes!\na` VARCHAR(255) NULL",
|
||||
{
|
||||
' yes ' => "\nyes!\na",
|
||||
},
|
||||
);
|
||||
|
||||
# #############################################################################
|
||||
# Two column alters
|
||||
# #############################################################################
|
||||
|
||||
test_func(
|
||||
"CHANGE a z VARCHAR(255) NULL, CHANGE foo bar INT",
|
||||
{
|
||||
a => 'z',
|
||||
foo => 'bar',
|
||||
},
|
||||
);
|
||||
|
||||
# Pathological
|
||||
test_func(
|
||||
"CHANGE a `CHANGE a z VARCHAR(255) NOT NULL` VARCHAR(255) NULL, CHANGE foo bar INT",
|
||||
{
|
||||
a => 'CHANGE a z VARCHAR(255) NOT NULL',
|
||||
foo => 'bar',
|
||||
},
|
||||
);
|
||||
|
||||
|
||||
# #############################################################################
|
||||
# Fake alters
|
||||
# #############################################################################
|
||||
|
||||
# Not really renamed.
|
||||
test_func(
|
||||
"CHANGE foo foo FLOAT",
|
||||
{
|
||||
},
|
||||
);
|
||||
|
||||
# Not really renamed, should ignore case
|
||||
test_func(
|
||||
"CHANGE foo FOO FLOAT",
|
||||
{
|
||||
},
|
||||
);
|
||||
|
||||
TODO: {
|
||||
local $::TODO = "We don't parse the entire alter statement, what looks like a CHANGE COLUMNS";
|
||||
# Not really an alter, pathological
|
||||
test_func(
|
||||
"MODIFY `CHANGE a z VARCHAR(255) NOT NULL` FLOAT",
|
||||
{
|
||||
},
|
||||
);
|
||||
}
|
||||
|
||||
# #############################################################################
|
||||
# Done.
|
||||
# #############################################################################
|
||||
done_testing;
|
||||
204
t/pt-online-schema-change/rename_columns.t
Normal file
204
t/pt-online-schema-change/rename_columns.t
Normal file
@@ -0,0 +1,204 @@
|
||||
#!/usr/bin/env perl
|
||||
|
||||
BEGIN {
|
||||
die "The PERCONA_TOOLKIT_BRANCH environment variable is not set.\n"
|
||||
unless $ENV{PERCONA_TOOLKIT_BRANCH} && -d $ENV{PERCONA_TOOLKIT_BRANCH};
|
||||
unshift @INC, "$ENV{PERCONA_TOOLKIT_BRANCH}/lib";
|
||||
};
|
||||
|
||||
use strict;
|
||||
use warnings FATAL => 'all';
|
||||
use English qw(-no_match_vars);
|
||||
use Test::More;
|
||||
|
||||
use Data::Dumper;
|
||||
use PerconaTest;
|
||||
use Sandbox;
|
||||
|
||||
require "$trunk/bin/pt-online-schema-change";
|
||||
|
||||
my $dp = new DSNParser(opts=>$dsn_opts);
|
||||
my $sb = new Sandbox(basedir => '/tmp', DSNParser => $dp);
|
||||
my $master_dbh = $sb->get_dbh_for('master');
|
||||
my $slave_dbh = $sb->get_dbh_for('slave1');
|
||||
|
||||
if ( !$master_dbh ) {
|
||||
plan skip_all => 'Cannot connect to sandbox master';
|
||||
}
|
||||
elsif ( !$slave_dbh ) {
|
||||
plan skip_all => 'Cannot connect to sandbox slave1';
|
||||
}
|
||||
|
||||
# The sandbox servers run with lock_wait_timeout=3 and it's not dynamic
|
||||
# so we need to specify --lock-wait-timeout=3 else the tool will die.
|
||||
my $master_dsn = 'h=127.1,P=12345,u=msandbox,p=msandbox';
|
||||
my @args = (qw(--lock-wait-timeout 3));
|
||||
my $output;
|
||||
my $exit_status;
|
||||
my $sample = "t/pt-online-schema-change/samples/";
|
||||
|
||||
# ############################################################################
|
||||
# https://bugs.launchpad.net/percona-toolkit/+bug/1068562
|
||||
# pt-online-schema-change loses data when renaming columns
|
||||
# ############################################################################
|
||||
|
||||
$sb->load_file('master', "$sample/data-loss-bug-1068562.sql");
|
||||
|
||||
($output, $exit_status) = full_output(
|
||||
sub { pt_online_schema_change::main(@args,
|
||||
"$master_dsn,D=bug1068562,t=simon",
|
||||
"--alter", "change old_column_name new_column_name varchar(255) NULL",
|
||||
qw(--execute)) },
|
||||
);
|
||||
|
||||
is(
|
||||
$exit_status,
|
||||
255,
|
||||
"Die if --execute without --no-check-alter"
|
||||
);
|
||||
|
||||
like(
|
||||
$output,
|
||||
qr/Specify --no-check-alter to disable this check/,
|
||||
"--check-alter error message"
|
||||
);
|
||||
|
||||
($output, $exit_status) = full_output(
|
||||
sub { pt_online_schema_change::main(@args,
|
||||
"$master_dsn,D=bug1068562,t=simon",
|
||||
"--alter", "change old_column_name new_column_name varchar(255) NULL",
|
||||
qw(--execute --no-check-alter)) },
|
||||
);
|
||||
|
||||
my $rows = $master_dbh->selectall_arrayref("SELECT * FROM bug1068562.simon ORDER BY id");
|
||||
|
||||
is_deeply(
|
||||
$rows,
|
||||
[ [qw(1 a)], [qw(2 b)], [qw(3 c)] ],
|
||||
"bug1068562.simon: No data lost"
|
||||
) or diag(Dumper($rows));
|
||||
|
||||
# #############################################################################
|
||||
# Now try with sakila.city.
|
||||
# #############################################################################
|
||||
|
||||
my $orig = $master_dbh->selectall_arrayref(q{SELECT city FROM sakila.city});
|
||||
|
||||
($output, $exit_status) = full_output(
|
||||
sub { pt_online_schema_change::main(@args,
|
||||
"$master_dsn,D=sakila,t=city",
|
||||
"--alter", "change column `city` `some_cities` varchar(50) NOT NULL",
|
||||
qw(--execute --alter-foreign-keys-method auto --no-check-alter)) },
|
||||
);
|
||||
|
||||
is(
|
||||
$exit_status,
|
||||
0,
|
||||
"sakila.city: Exit status 0",
|
||||
);
|
||||
|
||||
my $mod = $master_dbh->selectall_arrayref(q{SELECT some_cities FROM sakila.city});
|
||||
|
||||
is_deeply(
|
||||
$orig,
|
||||
$mod,
|
||||
"sakila.city: No data missing after first rename"
|
||||
);
|
||||
|
||||
($output, $exit_status) = full_output(
|
||||
sub { pt_online_schema_change::main(@args,
|
||||
"$master_dsn,D=sakila,t=city",
|
||||
"--alter", "change column `some_cities` city varchar(50) NOT NULL",
|
||||
qw(--execute --alter-foreign-keys-method auto --no-check-alter)) },
|
||||
);
|
||||
|
||||
my $mod2 = $master_dbh->selectall_arrayref(q{SELECT city FROM sakila.city});
|
||||
|
||||
is_deeply(
|
||||
$orig,
|
||||
$mod2,
|
||||
"sakila.city: No date missing after second rename"
|
||||
);
|
||||
|
||||
|
||||
# #############################################################################
|
||||
# Try with sakila.staff
|
||||
# #############################################################################
|
||||
|
||||
$orig = $master_dbh->selectall_arrayref(q{SELECT first_name, last_name FROM sakila.staff});
|
||||
|
||||
($output, $exit_status) = full_output(
|
||||
sub { pt_online_schema_change::main(@args,
|
||||
"$master_dsn,D=sakila,t=staff",
|
||||
"--alter", "change column first_name first_name_mod varchar(45) NOT NULL, change column last_name last_name_mod varchar(45) NOT NULL",
|
||||
qw(--execute --alter-foreign-keys-method auto --no-check-alter)) },
|
||||
);
|
||||
|
||||
$mod = $master_dbh->selectall_arrayref(q{SELECT first_name_mod, last_name_mod FROM sakila.staff});
|
||||
|
||||
is_deeply(
|
||||
$orig,
|
||||
$mod,
|
||||
"sakila.staff: No columns went missing with a double rename"
|
||||
);
|
||||
|
||||
($output, $exit_status) = full_output(
|
||||
sub { pt_online_schema_change::main(@args,
|
||||
"$master_dsn,D=sakila,t=staff",
|
||||
"--alter", "change column first_name_mod first_name varchar(45) NOT NULL, change column last_name_mod last_name varchar(45) NOT NULL",
|
||||
qw(--execute --alter-foreign-keys-method auto --no-check-alter)) },
|
||||
);
|
||||
|
||||
$mod2 = $master_dbh->selectall_arrayref(q{SELECT first_name, last_name FROM sakila.staff});
|
||||
|
||||
is_deeply(
|
||||
$orig,
|
||||
$mod2,
|
||||
"sakila.staff: No columns went missing when renaming the columns back"
|
||||
);
|
||||
|
||||
|
||||
# #############################################################################
|
||||
# --dry-run and other stuff
|
||||
# #############################################################################
|
||||
|
||||
($output, $exit_status) = full_output(
|
||||
sub { pt_online_schema_change::main(@args,
|
||||
"$master_dsn,D=sakila,t=staff",
|
||||
"--alter", "change column first_name first_name_mod varchar(45) NOT NULL, change column last_name last_name_mod varchar(45) NOT NULL",
|
||||
qw(--dry-run --alter-foreign-keys-method auto)) },
|
||||
);
|
||||
|
||||
is(
|
||||
$exit_status,
|
||||
0,
|
||||
"No error with --dry-run"
|
||||
);
|
||||
|
||||
like(
|
||||
$output,
|
||||
qr/first_name to first_name_mod, last_name to last_name_mod/ms,
|
||||
"--dry-run warns about renaming columns"
|
||||
);
|
||||
|
||||
# CHANGE COLUMN same_name same_name
|
||||
|
||||
($output, $exit_status) = full_output(
|
||||
sub { pt_online_schema_change::main(@args,
|
||||
"$master_dsn,D=sakila,t=staff",
|
||||
"--alter", "change column first_name first_name varchar(45) NOT NULL",
|
||||
qw(--execute --alter-foreign-keys-method auto)) },
|
||||
);
|
||||
|
||||
unlike(
|
||||
$output,
|
||||
qr/fist_name to fist_name/,
|
||||
"No warning if CHANGE col col"
|
||||
);
|
||||
|
||||
# #############################################################################
|
||||
# Done.
|
||||
# #############################################################################
|
||||
$sb->wipe_clean($master_dbh);
|
||||
ok($sb->ok(), "Sandbox servers") or BAIL_OUT(__FILE__ . " broke the sandbox");
|
||||
done_testing;
|
||||
11
t/pt-online-schema-change/samples/data-loss-bug-1068562.sql
Normal file
11
t/pt-online-schema-change/samples/data-loss-bug-1068562.sql
Normal file
@@ -0,0 +1,11 @@
|
||||
drop database if exists bug1068562;
|
||||
create database bug1068562;
|
||||
use bug1068562;
|
||||
|
||||
CREATE TABLE `simon` (
|
||||
`id` int(11) NOT NULL,
|
||||
`old_column_name` varchar(255) DEFAULT NULL,
|
||||
PRIMARY KEY (`id`)
|
||||
) ENGINE=InnoDB;
|
||||
|
||||
insert into simon values (1,'a'),(2,'b'),(3,'c');
|
||||
Reference in New Issue
Block a user