percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-11 13:40:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for the first bug in 1034717: Illegal division by zero if base == 1

Browse Source
This commit is contained in:
Brian Fraser
2012-08-22 17:03:35 -03:00
parent 250847455d
commit d3eabbd511
4 changed files with 71 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
t/lib/TableChunker.t
View File

@@ -25,9 +25,6 @@ my $dbh = $sb->get_dbh_for('master');
if ( !$dbh ) {
plan skip_all => 'Cannot connect to sandbox master';
}
else {
plan tests => 94;
}
$sb->create_dbs($dbh, ['test']);
@@ -1358,9 +1355,42 @@ is_deeply(
"Caclulate chunks for `key` col (bug 967451)"
);
# #############################################################################
# Bug 1034717: Divison by zero error when all columns tsart with the same char
# https://bugs.launchpad.net/percona-toolkit/+bug/1034717
# #############################################################################
$sb->load_file('master', "t/lib/samples/bug_1034717.sql", 'test');
$t = $tp->parse( $tp->get_create_table($dbh, 'bug_1034717', 'table1') );
%params = $c->get_range_statistics(
dbh => $dbh,
db => 'bug_1034717',
tbl => 'table1',
chunk_col => 'field1',
tbl_struct => $t,
);
local $EVAL_ERROR;
eval {
$c->calculate_chunks(
dbh => $dbh,
db => 'bug_1034717',
tbl => 'table1',
tbl_struct => $t,
chunk_col => 'field1',
chunk_size => '50',
%params,
);
};
like(
$EVAL_ERROR,
qr/^\QCannot chunk table `bug_1034717`.`table1` using the character column field1, most likely because all values start with the /,
"Bug 1034717: Catches the base == 1 case and dies"
);
# #############################################################################
# Done.
# #############################################################################
$sb->wipe_clean($dbh);
ok($sb->ok(), "Sandbox servers") or BAIL_OUT(__FILE__ . " broke the sandbox");
exit;
done_testing;