percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2026-04-26 01:02:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixes per Daniel's review

Browse Source
This commit is contained in:
Brian Fraser
2012-11-06 11:35:49 -03:00
parent 78da81fea5
commit d3c7a059e7
21 changed files with 48 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bin/pt-archiver
+1 -1
View File
@@ -7087,7 +7087,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-config-diff
+1 -1
View File
@@ -4669,7 +4669,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-deadlock-logger
+1 -1
View File
@@ -4584,7 +4584,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-diskstats
+1 -1
View File
@@ -5461,7 +5461,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-duplicate-key-checker
+1 -1
View File
@@ -5216,7 +5216,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-find
+1 -1
View File
@@ -4335,7 +4335,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-fk-error-logger
+1 -1
View File
@@ -3831,7 +3831,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-heartbeat
+1 -1
View File
@@ -5734,7 +5734,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-index-usage
+1 -1
View File
@@ -7262,7 +7262,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-kill
+1 -1
View File
@@ -7237,7 +7237,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-online-schema-change
+1 -1
View File
@@ -9900,7 +9900,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-query-advisor
+1 -1
View File
@@ -8499,7 +8499,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-query-digest
+1 -1
View File
@@ -16994,7 +16994,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-slave-delay
+1 -1
View File
@@ -4414,7 +4414,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-slave-restart
+1 -1
View File
@@ -5331,7 +5331,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-table-checksum
+1 -1
View File
@@ -11184,7 +11184,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-table-sync
+1 -1
View File
@@ -12316,7 +12316,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-upgrade
+1 -1
View File
@@ -12902,7 +12902,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
bin/pt-variable-advisor
+1 -1
View File
@@ -5686,7 +5686,7 @@ MAGIC_version_check
https, http, auto, off https, http, auto, off
C<auto> first tries using C<https>, and resolts to C<http> if that fails. C<auto> first tries using C<https>, and resorts to C<http> if that fails.
Keep in mind that C<https> might not be available if Keep in mind that C<https> might not be available if
C<IO::Socket::SSL> is not installed on your system, although C<IO::Socket::SSL> is not installed on your system, although
C<--version-check http> should work everywhere. C<--version-check http> should work everywhere.
t/lib/Pingback.t
+8 -7
View File
@@ -513,16 +513,17 @@ SKIP: {
# Check that the --v-c OPT validation works everywhere # Check that the --v-c OPT validation works everywhere
# ############################################################################# # #############################################################################
for my $exec ( grep { slurp_file($_) =~ /package Pingback;/ } use File::Basename qw(basename);
grep { !/~/ }
glob("$trunk/bin/*") my @vc_tools = grep { chomp; basename($_) =~ /\A[a-z-]+\z/ }
) `grep --files-with-matches Pingback $trunk/bin/*`;
{
my $output = `$exec --version-check ftp`; foreach my $tool ( @vc_tools ) {
my $output = `$tool --version-check ftp`;
like( like(
$output, $output,
qr/\Q* --version-check invalid value ftp. Accepted values are https, http, auto and off/, qr/\Q* --version-check invalid value ftp. Accepted values are https, http, auto and off/,
"Valid values for v-c are checked in $exec" "Valid values for v-c are checked in $tool"
); );
} }