Fixes per Daniel's review

This commit is contained in:
Brian Fraser
2012-11-06 11:35:49 -03:00
parent 78da81fea5
commit d3c7a059e7
21 changed files with 48 additions and 47 deletions

View File

@@ -513,16 +513,17 @@ SKIP: {
# Check that the --v-c OPT validation works everywhere
# #############################################################################
for my $exec ( grep { slurp_file($_) =~ /package Pingback;/ }
grep { !/~/ }
glob("$trunk/bin/*")
)
{
my $output = `$exec --version-check ftp`;
use File::Basename qw(basename);
my @vc_tools = grep { chomp; basename($_) =~ /\A[a-z-]+\z/ }
`grep --files-with-matches Pingback $trunk/bin/*`;
foreach my $tool ( @vc_tools ) {
my $output = `$tool --version-check ftp`;
like(
$output,
qr/\Q* --version-check invalid value ftp. Accepted values are https, http, auto and off/,
"Valid values for v-c are checked in $exec"
qr/\Q* --version-check invalid value ftp. Accepted values are https, http, auto and off/,
"Valid values for v-c are checked in $tool"
);
}