percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-19 18:34:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve: main_test

Browse Source 
It must test multiple times to remove doubts.
As the tool is reading files and relying on maps, their access order are
random. It can impact some translations
This commit is contained in:
Yoann La Cancellera
2023-10-18 23:37:25 +02:00
committed by Sveta Smirnova
parent c67047e781
commit d13292ba67
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/go/pt-galera-log-explainer/main_test.go
View File

@@ -99,17 +99,22 @@ func TestMain(t *testing.T) {
t.Fatalf("error during filepath.Glob(%s): %v", test.path, err)
}
test.cmd = append(test.cmd, filepaths...)
out, err := exec.Command(toolExecutable, test.cmd...).CombinedOutput()
if err != nil {
t.Fatalf("error executing %s %s: %s: %s", toolExecutable, strings.Join(test.cmd, " "), err.Error(), string(out))
}
expected, err := ioutil.ReadFile("tests/expected/" + test.name)
if err != nil {
t.Fatalf("error loading test 'expected' file: %s", err)
}
if !cmp.Equal(out, expected) {
t.Errorf("%s: test %s failed: %s\nout: %s", toolname, test.name, strings.Join(test.cmd, " "), cmp.Diff(string(out), string(expected)))
// because there has been some cases that created few different outputs
// source of random: order of files read, map iteration order are random and it affects map merges
for i := 0; i < 5; i++ {
out, err := exec.Command(toolExecutable, test.cmd...).CombinedOutput()
if err != nil {
t.Fatalf("error executing %s %s: %s: %s", toolExecutable, strings.Join(test.cmd, " "), err.Error(), string(out))
}
expected, err := ioutil.ReadFile("tests/expected/" + test.name)
if err != nil {
t.Fatalf("error loading test 'expected' file: %s", err)
}
if !cmp.Equal(out, expected) {
t.Errorf("%s: test %s failed: %s\nout: %s", toolname, test.name, strings.Join(test.cmd, " "), cmp.Diff(string(expected), string(out)))
}
}
}