percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-10-19 08:56:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use latest Quoter::(de)serialize_list() in pt-table-checksum and pt-table-sync. Add more char_chunking.t tests for pt-table-checksum.

Browse Source
This commit is contained in:
Daniel Nichter
2011-12-29 17:25:38 -07:00
parent 1f06ea093a
commit c58dfca1b5
49 changed files with 83 additions and 25400 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/Quoter.pm
View File

@@ -149,9 +149,20 @@ sub join_quote {
sub serialize_list {
my ( $self, @args ) = @_;
return unless @args;
# If the only value is undef, which is NULL for MySQL, then return
# the same. undef/NULL is a valid boundary value, however...
return $args[0] if @args == 1 && !defined $args[0];
die "serialize_list can't handle undef (NULLs) unless they are the only value"
# ... if there's an undef/NULL value and more than one value,
# then we have no easy way to serialize the values into a list.
# We can't convert undef to "NULL" because "NULL" is a valid
# value itself, and we can't make it "" because a blank string
# is also a valid value. In practice, a boundary value with
# two NULL values should be rare.
die "Cannot serialize multiple values with undef/NULL"
if grep { !defined $_ } @args;
return join ',', map { quotemeta } @args;
}