percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-26 05:58:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

VersionParser::normalized_version: Don't use _version_split, use the values from methods instead

Browse Source
This commit is contained in:
Brian Fraser
2012-07-12 23:15:01 -03:00
parent fdcc9a2290
commit c5555234c1
2 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/VersionParser.pm
View File

@@ -94,8 +94,9 @@ sub _split_version {
# 50120
sub normalized_version {
my ( $self ) = @_;
my @version_parts = map { $_ || 0 } $self->_split_version( $self->version );
my $result = sprintf('%d%02d%02d', @version_parts);
my $result = sprintf('%d%02d%02d', map { $_ || 0 } $self->major,
$self->minor,
$self->revision);
PTDEBUG && _d($self->version, 'normalizes to', $result);
return $result;
}

20
t/lib/VersionParser.t
View File

@@ -9,7 +9,7 @@ BEGIN {
use strict;
use warnings FATAL => 'all';
use English qw(-no_match_vars);
use Test::More tests => 27;
use Test::More tests => 29;
use VersionParser;
use PerconaTest;
@@ -80,10 +80,24 @@ is(
'Parser works on a simplified version',
);
my $fractional_version = VersionParser->new('5.0.08');
is(
VersionParser->new('5.0.08')->revision,
$fractional_version->revision,
'0.8',
'In 5.0.08, the revsion is 0.8',
'Verson(5.0.08), the revision is 0.8',
);
is(
"$fractional_version",
"5.0.08",
"Version(5.0.08) stringifies to 5.0.08"
);
is(
$fractional_version->normalized_version(),
"50000",
"Version(5.0.08) normalizes to 50000"
);
# Open a connection to MySQL, or skip the rest of the tests.