percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-10 13:11:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use .data for data file in stage so it's auto-removed if zero size.

Browse Source
This commit is contained in:
Daniel Nichter
2013-05-10 11:22:52 -07:00
parent f632824bc1
commit bf094713ad
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
bin/pt-agent
View File

@@ -6187,7 +6187,7 @@ sub run_service {
# Run the tasks, spool any data. # Run the tasks, spool any data.
my @output_files; my @output_files;
my $data_file = $prefix . '.' . $service->name; my $data_file = $prefix . '.' . $service->name . '.data';
my $tmp_data_file = "$tmp_dir/$data_file"; my $tmp_data_file = "$tmp_dir/$data_file";
my $taskno = 0; my $taskno = 0;
my $metadata = {}; my $metadata = {};
@@ -6302,9 +6302,10 @@ sub run_service {
metadata => $metadata, metadata => $metadata,
stage_dir => $tmp_dir, stage_dir => $tmp_dir,
); );
(my $meta_file = $data_file) =~ s/\.data/\.meta/;
write_to_file( write_to_file(
data => as_json($metadata, json => $json), data => as_json($metadata, json => $json),
file => "$data_dir/$data_file.meta", file => "$data_dir/$meta_file",
); );
# Use system mv instead of Perl File::Copy::move() because it's # Use system mv instead of Perl File::Copy::move() because it's
@@ -6312,7 +6313,7 @@ sub run_service {
# simply move the inode, _not_ copy the file. A system mv on # simply move the inode, _not_ copy the file. A system mv on
# the same filesystem is pretty much guaranteed to do an optimized, # the same filesystem is pretty much guaranteed to do an optimized,
# i.e. quasi-atomic, move. # i.e. quasi-atomic, move.
my $cmd = "mv $tmp_data_file $data_dir/$data_file.data"; my $cmd = "mv $tmp_data_file $data_dir";
_info($cmd); _info($cmd);
system($cmd); system($cmd);
my $cmd_exit_status = $CHILD_ERROR >> 8; my $cmd_exit_status = $CHILD_ERROR >> 8;