percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-07 12:58:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #762 from percona/PT-1751_adds_--where_param_to_pt-online-schema-change

Browse Source 
PT-1751 - adds --where param to pt-online-schema-change
This commit is contained in:
Sveta Smirnova
2024-02-05 13:56:16 +03:00
committed by GitHub
parent cf255e01e4 cbc00ad761
commit be880d82d7
2 changed files with 484 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
bin/pt-online-schema-change
View File

@@ -8693,6 +8693,13 @@ sub main {
}
}
if ( $o->get('where') && !$o->get('force')
&& ( $o->get('drop-new-table') || $o->get('swap-tables') ) )
{
_die("Using option --where together with --drop-new-table and --swap-tables may lead to data loss, therefore this operation is only allowed if option --force also specified. Aborting.", UNSUPPORTED_OPERATION);
}
# See the "pod-based-option-value-validation" spec for how this may
# be automagically validated.
if ( $alter_fk_method
@@ -9254,6 +9261,7 @@ sub main {
Cxn => $cxn,
Quoter => $q,
only_same_schema_fks => $o->get('only-same-schema-fks'),
where => $o->get('where'),
);
if ( !$child_tables ) {
if ( $alter_fk_method ) {
@@ -9281,6 +9289,12 @@ sub main {
$child_table->{row_est} || '?';
}
if ( $o->get('where') && !$o->get('force') ) {
print "Child tables found and option --where specified. Rebuilding foreign key constraints may lead to errors.\n";
print "Use --force to override this check\n";
return 1;
}
# TODO: Fix self referencing foreign keys handling.
# See: https://jira.percona.com/browse/PT-1802
# https://jira.percona.com/browse/PT-1853
@@ -9900,6 +9914,7 @@ sub main {
my ($n_rows) = NibbleIterator::get_row_estimate(
Cxn => $slave,
tbl => $tbl,
where => $o->get('where'),
);
PTDEBUG && _d('Table on',$slave->name(),'has', $n_rows, 'rows');
if ( $limit && $n_rows && $n_rows > ($tbl->{chunk_size} * $limit) ) {
@@ -10230,6 +10245,7 @@ sub main {
max_rows => $max_rows,
Cxn => $cxn,
OptionParser => $o,
where => $o->get('where'),
);
if ( $alter_fk_method eq 'drop_swap' ) {
@@ -11183,6 +11199,7 @@ sub find_child_tables {
my ($n_rows) = NibbleIterator::get_row_estimate(
Cxn => $cxn,
tbl => $tbl,
where => $args{where},
);
$tbl->{row_est} = $n_rows;
@@ -11218,6 +11235,7 @@ sub determine_alter_fk_method {
my ($n_rows) = NibbleIterator::get_row_estimate(
Cxn => $cxn,
tbl => $child_tbl,
where => $args{where},
);
if ( $n_rows > $max_rows ) {
print "too many rows: $n_rows; must use drop_swap\n";
@@ -12738,7 +12756,9 @@ duplicate rows and this data will be lost.
=item --force
This options bypasses confirmation in case of using alter-foreign-keys-method = none , which might break foreign key constraints.
This option bypasses confirmation in case of using alter-foreign-keys-method = none, which might break foreign key constraints.
This option also allows to use option --where without options --no-drop-new-table and --no-swap-tables.
=item --help
@@ -13193,6 +13213,23 @@ tool.
For more information, visit L<https://www.percona.com/doc/percona-toolkit/LATEST/version-check.html>.
=item --where
type: string
Copy only rows matching this WHERE clause. You can use this option to limit
the copying to only part of the table. This is particularly useful if you want
to restart pt-online-schema-change job after it was failed.
This option is much like the -w option to mysqldump. Do not specify the WHERE
keyword. You might need to quote the value. Here is an example:
pt-online-schema-change --where "id > 12345678"
IMPORTANT. If used without options --no-drop-new-table and --no-swap-tables
may lead to data loss, therefore this operation only allowed if option --force
also specified.
=item --[no]fail-on-stopped-replication
default: yes