percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-02 02:34:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1022622: pt-config-diff is case-sensitive

Browse Source
This commit is contained in:
Brian Fraser
2012-07-27 20:12:45 -03:00
parent 192f38498c
commit ac015477af
4 changed files with 110 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/MySQLConfigComparer.pm
View File

@@ -126,6 +126,9 @@ sub new {
value_is_optional => \%value_is_optional,
any_value_is_true => \%any_value_is_true,
base_path => \%base_path,
ignore_case => exists $args{ignore_case}
? $args{ignore_case}
: 1,
};
return bless $self, $class;
@@ -172,6 +175,7 @@ sub diff {
my $config0 = $configs->[0];
my $last_config = @$configs - 1;
my $vars = $self->_get_shared_vars(%args);
my $ignore_case = $self->{ignore_case};
# Compare variables from first config (config0) to other configs (configN).
my $diffs;
@@ -197,7 +201,9 @@ sub diff {
next CONFIG if $val0 == $valN;
}
else {
next CONFIG if $val0 eq $valN;
next CONFIG if $ignore_case
? lc($val0) eq lc($valN)
: $val0 eq $valN;
# Special rules apply when comparing different inputs/formats,
# e.g. when comparing an option file to SHOW VARIABLES. This