percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-20 02:44:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

PT-2236 - pt-secure-collect, pt-pg-summary do not follow PT standard (#652)

Browse Source 
* PT-2236 - pt-secure-collect, pt-pg-summary do not follow PT standard for option --version

- Redirected UsageWriter to os.Stdout for kingpin, so --version output
  goes to STDOUT, not to STDERR
- Adjusted text, printed by the --version flag
- Added test cases to check how --version flag works
- Adjusted test cases, so they use TOOLNAME constant

* PT-2236 - pt-secure-collect, pt-pg-summary do not follow PT standard for option --version

Run go mod tidy as requested by Artem Gavrilov

* PT-2236 - pt-secure-collect, pt-pg-summary do not follow PT standard for option --version

Renamed const TOOLNAME to toolname to follow Go coding standards
This commit is contained in:
Sveta Smirnova
2023-07-31 16:59:30 +03:00
committed by GitHub
parent 91f9e27255
commit ab4bf1b1c6
11 changed files with 70 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/go/pt-mongodb-query-digest/main.go
View File

@@ -30,7 +30,7 @@ import (
)
const (
TOOLNAME = "pt-mongodb-query-digest"
toolname = "pt-mongodb-query-digest"
DEFAULT_AUTHDB = "admin"
DEFAULT_HOST = "localhost:27017"
@@ -90,16 +90,16 @@ func main() {
log.SetLevel(logLevel)
if opts.Version {
fmt.Println(TOOLNAME)
fmt.Println(toolname)
fmt.Printf("Version %s\n", Version)
fmt.Printf("Build: %s using %s\n", Build, GoVersion)
fmt.Printf("Commit: %s\n", Commit)
return
}
conf := config.DefaultConfig(TOOLNAME)
conf := config.DefaultConfig(toolname)
if !conf.GetBool("no-version-check") && !opts.NoVersionCheck {
advice, err := versioncheck.CheckUpdates(TOOLNAME, Version)
advice, err := versioncheck.CheckUpdates(toolname, Version)
if err != nil {
log.Infof("cannot check version updates: %s", err.Error())
} else if advice != "" {
@@ -361,7 +361,7 @@ func getClientOptions(opts *cliOptions) (*options.ClientOptions, error) {
func getHeaders(opts *cliOptions) []string {
h := []string{
fmt.Sprintf("%s - %s\n", TOOLNAME, time.Now().Format(time.RFC1123Z)),
fmt.Sprintf("%s - %s\n", toolname, time.Now().Format(time.RFC1123Z)),
fmt.Sprintf("Host: %s\n", opts.Host),
fmt.Sprintf("Skipping profiled queries on these collections: %v\n", opts.SkipCollections),
}