percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-11 21:51:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'pt-tcs-where-option-using-non-optimal-index-lp1576036' of github.com:percona/percona-toolkit into pt-tcs-where-option-using-non-optimal-index-lp1576036

Browse Source
This commit is contained in:
frank-cizmich
2016-05-11 18:10:05 -03:00
parent 47cc4225d8 162d4dcd28
commit a4b9b941d6
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bin/pt-table-checksum
View File

@@ -6560,7 +6560,7 @@ sub _find_best_index {
} }
} }
if (!$best_index && !$want_index) { if (!$best_index) {
PTDEBUG && _d('Auto-selecting best index'); PTDEBUG && _d('Auto-selecting best index');
foreach my $index ( $tp->sort_indexes($tbl_struct) ) { foreach my $index ( $tp->sort_indexes($tbl_struct) ) {
if ( $index eq 'PRIMARY' || $indexes->{$index}->{is_unique} ) { if ( $index eq 'PRIMARY' || $indexes->{$index}->{is_unique} ) {

4
lib/NibbleIterator.pm
View File

@@ -540,7 +540,8 @@ sub _find_best_index {
} }
} }
# still no best index? select amongst all candidates. # still no best index?
# prefer unique index. otherwise put in candidates array.
if (!$best_index) { if (!$best_index) {
PTDEBUG && _d('Auto-selecting best index'); PTDEBUG && _d('Auto-selecting best index');
foreach my $index ( $tp->sort_indexes($tbl_struct) ) { foreach my $index ( $tp->sort_indexes($tbl_struct) ) {
@@ -554,6 +555,7 @@ sub _find_best_index {
} }
} }
# choose the one with best cardinality
if ( !$best_index && @possible_indexes ) { if ( !$best_index && @possible_indexes ) {
PTDEBUG && _d('No PRIMARY or unique indexes;', PTDEBUG && _d('No PRIMARY or unique indexes;',
'will use index with highest cardinality'); 'will use index with highest cardinality');