Add code comments. Make Pingback.t tests more explicity. Don't '1 while unlink file'. Remove get_mysql_status() stub.

This commit is contained in:
Daniel Nichter
2012-08-27 15:19:35 -06:00
parent 9f79d4b7ba
commit a08bf4c4fc
3 changed files with 38 additions and 37 deletions

View File

@@ -91,11 +91,11 @@ sub get_versions {
my %versions;
foreach my $item ( values %$items ) {
next unless $self->valid_item($item);
eval {
my $func = 'get_' . $item->{type};
my $version = $self->$func(
item => $item,
item => $item,
instances => $instances,
);
if ( $version ) {
@@ -229,16 +229,6 @@ sub get_mysql_variable {
);
}
# This isn't implemented yet. It's easy to do (TYPE=mysql_status),
# but it may be overkill.
#sub get_mysql_status {
# my $self = shift;
# return $self->_get_from_mysql(
# show => 'STATUS',
# @_,
# );
#}
sub _get_from_mysql {
my ($self, %args) = @_;
my $show = $args{show};