mirror of
https://github.com/percona/percona-toolkit.git
synced 2025-10-19 17:04:00 +00:00
Add code comments. Make Pingback.t tests more explicity. Don't '1 while unlink file'. Remove get_mysql_status() stub.
This commit is contained in:
@@ -91,11 +91,11 @@ sub get_versions {
|
||||
my %versions;
|
||||
foreach my $item ( values %$items ) {
|
||||
next unless $self->valid_item($item);
|
||||
|
||||
|
||||
eval {
|
||||
my $func = 'get_' . $item->{type};
|
||||
my $version = $self->$func(
|
||||
item => $item,
|
||||
item => $item,
|
||||
instances => $instances,
|
||||
);
|
||||
if ( $version ) {
|
||||
@@ -229,16 +229,6 @@ sub get_mysql_variable {
|
||||
);
|
||||
}
|
||||
|
||||
# This isn't implemented yet. It's easy to do (TYPE=mysql_status),
|
||||
# but it may be overkill.
|
||||
#sub get_mysql_status {
|
||||
# my $self = shift;
|
||||
# return $self->_get_from_mysql(
|
||||
# show => 'STATUS',
|
||||
# @_,
|
||||
# );
|
||||
#}
|
||||
|
||||
sub _get_from_mysql {
|
||||
my ($self, %args) = @_;
|
||||
my $show = $args{show};
|
||||
|
Reference in New Issue
Block a user