From 983af3b1582229050c1d1452025a2dc3da699c2e Mon Sep 17 00:00:00 2001 From: Daniel Nichter Date: Fri, 10 May 2013 12:15:34 -0700 Subject: [PATCH] Always save response object in PWS client before returning or dying. --- bin/pt-agent | 4 ++-- lib/Percona/WebAPI/Client.pm | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bin/pt-agent b/bin/pt-agent index bb4f18be..5bdc83f0 100755 --- a/bin/pt-agent +++ b/bin/pt-agent @@ -1087,6 +1087,8 @@ sub _request { my $response = $self->ua->request($req); PTDEBUG && _d('Response', Dumper($response)); + $self->response($response); + if ( !($response->code >= 200 && $response->code < 400) ) { die Percona::WebAPI::Exception::Request->new( method => $method, @@ -1097,8 +1099,6 @@ sub _request { ); } - $self->response($response); - return; } diff --git a/lib/Percona/WebAPI/Client.pm b/lib/Percona/WebAPI/Client.pm index b12df571..9b2a0266 100644 --- a/lib/Percona/WebAPI/Client.pm +++ b/lib/Percona/WebAPI/Client.pm @@ -293,6 +293,8 @@ sub _request { my $response = $self->ua->request($req); PTDEBUG && _d('Response', Dumper($response)); + $self->response($response); + if ( !($response->code >= 200 && $response->code < 400) ) { die Percona::WebAPI::Exception::Request->new( method => $method, @@ -303,8 +305,6 @@ sub _request { ); } - $self->response($response); - return; }