diff --git a/src/go/lib/versioncheck/version_check.go b/src/go/lib/versioncheck/version_check.go index 114b2148..37409908 100644 --- a/src/go/lib/versioncheck/version_check.go +++ b/src/go/lib/versioncheck/version_check.go @@ -73,15 +73,15 @@ func checkUpdates(url string, timeout time.Duration, toolName, version string) ( if err != nil { return "", err } - advices := []Advice{} - err = json.Unmarshal(body, &advices) + var advice []Advice + err = json.Unmarshal(body, &advice) if err != nil { return "", err } - for _, advice := range advices { - if advice.ToolName == PERCONA_TOOLKIT { - return advice.Advice, nil + for _, a := range advice { + if a.ToolName == PERCONA_TOOLKIT { + return a.Advice, nil } } diff --git a/src/go/lib/versioncheck/version_check_test.go b/src/go/lib/versioncheck/version_check_test.go index 0d449df0..357a0e74 100644 --- a/src/go/lib/versioncheck/version_check_test.go +++ b/src/go/lib/versioncheck/version_check_test.go @@ -16,7 +16,7 @@ func TestCheckUpdates(t *testing.T) { body, _ := ioutil.ReadAll(r.Body) m := strings.Split(string(body), ";") - advices := []Advice{ + advice := []Advice{ { Hash: m[0], ToolName: m[1], @@ -24,7 +24,7 @@ func TestCheckUpdates(t *testing.T) { }, } - buf, _ := json.Marshal(advices) + buf, _ := json.Marshal(advice) w.Header().Set("Content-Type", "application/json") fmt.Fprint(w, string(buf)) }))