diff --git a/bin/pt-stalk b/bin/pt-stalk index 7b1a3597..f9fca9e3 100755 --- a/bin/pt-stalk +++ b/bin/pt-stalk @@ -710,16 +710,16 @@ collect() { $CMD_SYSCTL -a >> "$d/$p-sysctl" & fi if [ "$CMD_VMSTAT" ]; then - $CMD_VMSTAT 1 $OPT_INTERVAL >> "$d/$p-vmstat" & - $CMD_VMSTAT $OPT_INTERVAL 2 >> "$d/$p-vmstat-overall" & + $CMD_VMSTAT 1 $OPT_RUN_TIME >> "$d/$p-vmstat" & + $CMD_VMSTAT $OPT_RUN_TIME 2 >> "$d/$p-vmstat-overall" & fi if [ "$CMD_IOSTAT" ]; then - $CMD_IOSTAT -dx 1 $OPT_INTERVAL >> "$d/$p-iostat" & - $CMD_IOSTAT -dx $OPT_INTERVAL 2 >> "$d/$p-iostat-overall" & + $CMD_IOSTAT -dx 1 $OPT_RUN_TIME >> "$d/$p-iostat" & + $CMD_IOSTAT -dx $OPT_RUN_TIME 2 >> "$d/$p-iostat-overall" & fi if [ "$CMD_MPSTAT" ]; then - $CMD_MPSTAT -P ALL 1 $OPT_INTERVAL >> "$d/$p-mpstat" & - $CMD_MPSTAT -P ALL $OPT_INTERVAL 1 >> "$d/$p-mpstat-overall" & + $CMD_MPSTAT -P ALL 1 $OPT_RUN_TIME >> "$d/$p-mpstat" & + $CMD_MPSTAT -P ALL $OPT_RUN_TIME 1 >> "$d/$p-mpstat-overall" & fi $CMD_MYSQLADMIN $EXT_ARGV ext -i1 -c$OPT_RUN_TIME >>"$d/$p-mysqladmin" & diff --git a/lib/bash/collect.sh b/lib/bash/collect.sh index 9cba7cef..ef56a3ad 100644 --- a/lib/bash/collect.sh +++ b/lib/bash/collect.sh @@ -148,16 +148,16 @@ collect() { $CMD_SYSCTL -a >> "$d/$p-sysctl" & fi if [ "$CMD_VMSTAT" ]; then - $CMD_VMSTAT 1 $OPT_INTERVAL >> "$d/$p-vmstat" & - $CMD_VMSTAT $OPT_INTERVAL 2 >> "$d/$p-vmstat-overall" & + $CMD_VMSTAT 1 $OPT_RUN_TIME >> "$d/$p-vmstat" & + $CMD_VMSTAT $OPT_RUN_TIME 2 >> "$d/$p-vmstat-overall" & fi if [ "$CMD_IOSTAT" ]; then - $CMD_IOSTAT -dx 1 $OPT_INTERVAL >> "$d/$p-iostat" & - $CMD_IOSTAT -dx $OPT_INTERVAL 2 >> "$d/$p-iostat-overall" & + $CMD_IOSTAT -dx 1 $OPT_RUN_TIME >> "$d/$p-iostat" & + $CMD_IOSTAT -dx $OPT_RUN_TIME 2 >> "$d/$p-iostat-overall" & fi if [ "$CMD_MPSTAT" ]; then - $CMD_MPSTAT -P ALL 1 $OPT_INTERVAL >> "$d/$p-mpstat" & - $CMD_MPSTAT -P ALL $OPT_INTERVAL 1 >> "$d/$p-mpstat-overall" & + $CMD_MPSTAT -P ALL 1 $OPT_RUN_TIME >> "$d/$p-mpstat" & + $CMD_MPSTAT -P ALL $OPT_RUN_TIME 1 >> "$d/$p-mpstat-overall" & fi # Collect multiple snapshots of the status variables. We use diff --git a/t/lib/bash/collect.sh b/t/lib/bash/collect.sh index 397b902e..e5d5741e 100644 --- a/t/lib/bash/collect.sh +++ b/t/lib/bash/collect.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash -plan 20 +plan 21 TMPFILE="$TEST_TMPDIR/parse-opts-output" TMPDIR="$TEST_TMPDIR" @@ -143,6 +143,16 @@ collect "$TMPDIR/collect" "2011_12_05" > $p-output 2>&1 iters=$(cat $p-df | grep -c '^TS ') is "$iters" "2" "2 iteration/2s run time" +if [ -f "$p-vmstat" ]; then + n=$(awk '/[ ]*[0-9]/ { n += 1 } END { print n }' "$p-vmstat") + is \ + "$n" \ + "2" \ + "vmstat runs for --run-time seconds (bug 955860)" +else + is "1" "1" "SKIP vmstat not installed" +fi + # ############################################################################ # Done # ############################################################################