percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2026-04-16 01:00:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Set sql_mode='' before SHOW CREATE TABLE--don't bother with replacing certain values. Move and rewrite tests to ansi_quotes.t.

Browse Source
This commit is contained in:
Daniel Nichter
2012-11-01 11:31:31 -06:00
parent 2bcc380c68
commit 949cf31037
6 changed files with 149 additions and 206 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
t/pt-online-schema-change/bugs.t
View File

@@ -193,69 +193,9 @@ is_deeply(
$master_dbh->do(q{DROP DATABASE IF EXISTS `bug_1041372`});
# ############################################################################
# pt-online-schema-change foreign key error
# Customer issue 26211
# ############################################################################
$sb->load_file('master', "$sample/issue-26211.sql");
my $retval;
# There's two bugs here. First, see that it lives ok:
($output, $retval) = full_output(sub { pt_online_schema_change::main(@args,
'--alter-foreign-keys-method', 'auto',
'--no-check-replication-filters',
'--alter', "ENGINE=InnoDB",
'--execute', "$master_dsn,D=bug_26211,t=prm_inst")});
is(
$retval,
0,
"Issue 26211: Lives ok"
) or diag($output);
unlike(
$output,
qr/\QI need a max_rows argument/,
"Issue 26211: No error message"
);
$sb->load_file('master', "$sample/issue-26211.sql");
# And now check that it works with this SQL mode
my ($old_mode) = $master_dbh->selectrow_array('select @@sql_mode');
chomp $old_mode;
diag("Old SQL mode: $old_mode");
my $new_mode = 'NO_AUTO_VALUE_ON_ZERO,PIPES_AS_CONCAT,ANSI_QUOTES,IGNORE_SPACE,ORACLE,NO_KEY_OPTIONS,NO_TABLE_OPTIONS,NO_FIELD_OPTIONS,NO_AUTO_CREATE_USER';
diag("New SQL mode: $new_mode");
$master_dbh->do("SET GLOBAL sql_mode='$new_mode'");
# There's two bugs here. First, see that it lives ok:
($output, $retval) = full_output(sub { pt_online_schema_change::main(@args,
'--alter-foreign-keys-method', 'auto',
'--no-check-replication-filters',
'--alter', "ENGINE=InnoDB",
'--execute', "$master_dsn,D=bug_26211,t=prm_inst")});
is(
$retval,
0,
"Issue 26211 part 2: Lives ok"
);
unlike(
$output,
qr/Error/i,
"Issue 26211 part 2: No error message"
);
diag("Restoring SQL mode to $old_mode");
$master_dbh->do("set global sql_mode='$old_mode'");
$master_dbh->do(q{DROP DATABASE IF EXISTS `bug_26211`});
# #############################################################################
# Done.
# #############################################################################
$sb->wipe_clean($master_dbh);
ok($sb->ok(), "Sandbox servers") or BAIL_OUT(__FILE__ . " broke the sandbox");
done_testing;