diff --git a/bin/pt-variable-advisor b/bin/pt-variable-advisor index 30b0e03c..11d93363 100755 --- a/bin/pt-variable-advisor +++ b/bin/pt-variable-advisor @@ -3601,10 +3601,10 @@ sub get_rules { }, }, { - id => 'expire_log_days', + id => 'expire_logs_days', code => sub { my ( %args ) = @_; - return _var_eq($args{variables}->{expire_log_days}, 0) + return _var_eq($args{variables}->{expire_logs_days}, 0) && _var_seq($args{variables}->{log_bin}, "ON"); }, }, @@ -5720,7 +5720,7 @@ severity: warn Most applications should use the default REPEATABLE-READ transaction isolation level, or in a few cases READ-COMMITTED. -=item expire_log_days +=item expire_logs_days severity: warn