percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-25 21:54:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix query time diff formatting in pt-upgrade.

Browse Source
This commit is contained in:
Daniel Nichter
2013-03-14 09:20:54 -06:00
parent e27660f6a6
commit 84ab975438
4 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/UpgradeResults.pm
View File

@@ -451,10 +451,12 @@ sub _print_diffs {
my $diffno = 1;
foreach my $diff ( @$diffs ) {
my $query = $diff->[0];
my $diff_vals = $diff->[1];
print "\n-- $diffno.\n";
my $formatted_diff = $formatter->($diff->[1]);
print $formatted_diff || '?';
print "\n" . ($diff->[0] || '?') . "\n";
my $formatted_diff_vals = $formatter->($diff_vals);
print $formatted_diff_vals || '?';
print "\n" . ($query || '?') . "\n";
$diffno++;
}
@@ -531,11 +533,11 @@ sub _format_rows {
sub _format_query_times {
my ($query_times) = @_;
return unless $query_times;
my $fmt = "\n%s vs. %s seconds (%s%% increase)\n";
my $fmt = "\n%s vs. %s seconds (%sx increase)\n";
my $diff = sprintf $fmt,
($query_times->[0] || '?'),
($query_times->[1] || '?'),
($query_times->[2] || '?'),
($query_times->[3] || '?');
($query_times->[2] || '?');
return $diff;
}