percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2026-04-26 01:02:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix race condition between replicate and replicate-check.

Browse Source
This commit is contained in:
Daniel Nichter
2011-09-30 09:58:33 -06:00
parent b3cfd659b1
commit 830f855c05
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bin/pt-table-checksum
+8 -3
View File
@@ -5734,8 +5734,13 @@ sub main {
); );
} }
# Requiring "AND master_crc IS NOT NULL" avoids a race condition
# when the system is fast but replication is slow. In such cases,
# we can select on the slave before the update for $update_sth
# replicates; this causes a false-positive diff.
my $sql = "SELECT MAX(chunk) FROM $repl_table " my $sql = "SELECT MAX(chunk) FROM $repl_table "
. "WHERE db='$tbl->{db}' AND tbl='$tbl->{tbl}'"; . "WHERE db='$tbl->{db}' AND tbl='$tbl->{tbl}' "
. "AND master_crc IS NOT NULL";
MKDEBUG && _d($sql); MKDEBUG && _d($sql);
my $n_slaves = scalar @$slaves - 1; my $n_slaves = scalar @$slaves - 1;
@@ -6187,7 +6192,7 @@ sub create_repl_table {
my ($dbh, $repl_table, $o) = @args{@required_args}; my ($dbh, $repl_table, $o) = @args{@required_args};
MKDEBUG && _d('Creating --replicate table', $repl_table); MKDEBUG && _d('Creating --replicate table', $repl_table);
my $sql = $o->read_para_after(__FILE__, qr/MAGIC_create_replicate/); my $sql = $o->read_para_after(__FILE__, qr/MAGIC_create_replicate/);
$sql =~ s/CREATE TABLE checksum/CREATE TABLE $repl_table/; $sql =~ s/CREATE TABLE checksums/CREATE TABLE $repl_table/;
$sql =~ s/;$//; $sql =~ s/;$//;
MKDEBUG && _d($dbh, $sql); MKDEBUG && _d($dbh, $sql);
eval { eval {
@@ -6893,7 +6898,7 @@ this_crc, master_crc, this_cnt, master_cnt. The table may be named anything you
wish. Here is a suggested table structure, which is automatically used for wish. Here is a suggested table structure, which is automatically used for
L<"--create-replicate-table"> (MAGIC_create_replicate): L<"--create-replicate-table"> (MAGIC_create_replicate):
CREATE TABLE checksum ( CREATE TABLE checksums (
db char(64) NOT NULL, db char(64) NOT NULL,
tbl char(64) NOT NULL, tbl char(64) NOT NULL,
chunk int NOT NULL, chunk int NOT NULL,
t/pt-table-checksum/samples/static-chunk-size-results-5.1.txt
+1 -1
View File
@@ -13,7 +13,7 @@ ERRORS DIFFS ROWS CHUNKS SKIPPED TABLE
0 0 6 1 0 mysql.proc 0 0 6 1 0 mysql.proc
0 0 0 1 0 mysql.procs_priv 0 0 0 1 0 mysql.procs_priv
0 0 0 1 0 mysql.servers 0 0 0 1 0 mysql.servers
0 1 0 1 0 mysql.tables_priv 0 0 0 1 0 mysql.tables_priv
0 0 0 1 0 mysql.time_zone 0 0 0 1 0 mysql.time_zone
0 0 0 1 0 mysql.time_zone_leap_second 0 0 0 1 0 mysql.time_zone_leap_second
0 0 0 1 0 mysql.time_zone_name 0 0 0 1 0 mysql.time_zone_name