percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-10 21:19:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed a typo and added some regression tests

Browse Source
This commit is contained in:
Brian Fraser
2012-11-01 17:04:00 -03:00
parent 7f557759a7
commit 78da81fea5
21 changed files with 37 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bin/pt-archiver
View File

@@ -5091,7 +5091,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-config-diff
View File

@@ -4241,7 +4241,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-deadlock-logger
View File

@@ -3683,7 +3683,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-diskstats
View File

@@ -4794,7 +4794,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-duplicate-key-checker
View File

@@ -4607,7 +4607,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-find
View File

@@ -3447,7 +3447,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-fk-error-logger
View File

@@ -3387,7 +3387,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-heartbeat
View File

@@ -4531,7 +4531,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-index-usage
View File

@@ -6113,7 +6113,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-kill
View File

@@ -6124,7 +6124,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-online-schema-change
View File

@@ -7146,7 +7146,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-query-advisor
View File

@@ -7298,7 +7298,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-query-digest
View File

@@ -13228,7 +13228,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-slave-delay
View File

@@ -3796,7 +3796,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-slave-restart
View File

@@ -4419,7 +4419,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-table-checksum
View File

@@ -1348,7 +1348,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-table-sync
View File

@@ -9527,7 +9527,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-upgrade
View File

@@ -11595,7 +11595,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
bin/pt-variable-advisor
View File

@@ -4708,7 +4708,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

2
lib/Pingback.pm
View File

@@ -420,7 +420,7 @@ sub validate_options {
chomp(@values);
return if grep { $value eq $_ } @values;
$o->save_error("--version-check invalud value $value. Accepted values are "
$o->save_error("--version-check invalid value $value. Accepted values are "
. join(", ", @values[0..$#values-1]) . " and $values[-1]" );
}

17
t/lib/Pingback.t
View File

@@ -509,6 +509,23 @@ SKIP: {
);
}
# #############################################################################
# Check that the --v-c OPT validation works everywhere
# #############################################################################
for my $exec ( grep { slurp_file($_) =~ /package Pingback;/ }
grep { !/~/ }
glob("$trunk/bin/*")
)
{
my $output = `$exec --version-check ftp`;
like(
$output,
qr/\Q* --version-check invalid value ftp. Accepted values are https, http, auto and off/,
"Valid values for v-c are checked in $exec"
);
}
# #############################################################################
# Done.
# #############################################################################